Skip to content

Commit fa42a86

Browse files
authored
Avoid forcing dependency versions (#3309)
1 parent 4c77785 commit fa42a86

File tree

9 files changed

+8
-48
lines changed

9 files changed

+8
-48
lines changed

build.gradle

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -47,27 +47,6 @@ allprojects {
4747
repositories {
4848
mavenCentral() { metadataSources { mavenPom(); ignoreGradleMetadataRedirection() } }
4949
}
50-
51-
configurations.all {
52-
resolutionStrategy {
53-
preferProjectModules()
54-
}
55-
56-
resolutionStrategy.eachDependency { details ->
57-
if (details.requested.group == 'com.google.errorprone' && details.requested.name == 'error_prone_annotations') {
58-
details.useTarget group: 'com.google.errorprone', name: 'error_prone_annotations', version: '2.7.1'
59-
details.because "The error_prone_annotations dependency must be low to avoid forcing consumers to use newer releases"
60-
}
61-
if (details.requested.group == 'com.github.ben-manes.caffeine' && details.requested.name == 'caffeine' && details.requested.version == '3.1.7') {
62-
details.useTarget group: 'com.github.ben-manes.caffeine', name: 'caffeine', version: '3.1.6'
63-
details.because "https://github.com/ben-manes/caffeine/issues/1111"
64-
}
65-
if (details.requested.group.startsWith('com.fasterxml.jackson') && (details.requested.version == '2.16.0' || details.requested.version == '2.16.1')) {
66-
details.useTarget group: details.requested.group, name: details.requested.name, version: '2.15.3'
67-
details.because 'https://github.com/FasterXML/jackson-databind/pull/4230'
68-
}
69-
}
70-
}
7150
}
7251

7352
subprojects {

conjure-java-client-verifier/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ dependencies {
88
testImplementation project(':conjure-java-jaxrs-client')
99
testImplementation project(':conjure-java-jackson-serialization')
1010
testImplementation project(':keystores')
11-
testImplementation project(':okhttp-clients')
1211
testImplementation "org.slf4j:slf4j-api"
1312
testImplementation 'org.assertj:assertj-core'
1413
testImplementation 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml'
@@ -17,4 +16,6 @@ dependencies {
1716
testImplementation 'org.junit.jupiter:junit-jupiter'
1817
testImplementation 'org.junit.jupiter:junit-jupiter-api'
1918
testImplementation 'org.junit.jupiter:junit-jupiter-params'
19+
20+
testRuntimeOnly 'jakarta.ws.rs:jakarta.ws.rs-api'
2021
}

conjure-java-jackson-serialization/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ dependencies {
2121
implementation 'com.palantir.tritium:tritium-registry'
2222
implementation 'io.dropwizard.metrics:metrics-core'
2323

24+
testImplementation 'com.fasterxml.jackson.core:jackson-annotations'
2425
testImplementation "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml"
2526
testImplementation "org.assertj:assertj-core"
2627
testImplementation 'org.junit.jupiter:junit-jupiter'

conjure-java-jersey-jakarta-server/build.gradle

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,3 @@ dependencies {
4141
implementation 'com.palantir.safe-logging:logger'
4242

4343
}
44-
45-
configurations.all {
46-
resolutionStrategy {
47-
// Conflicts with javax.inject:javax.inject:1
48-
// This is safe to remove, the purpose of the repackaged version is to implement OSGI, which we don't use
49-
// Source: https://stackoverflow.com/a/25218230/274699
50-
exclude group: 'org.glassfish.hk2.external', module: 'jakarta.inject'
51-
}
52-
}

conjure-java-jersey-server/build.gradle

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,6 @@ dependencies {
5555
}
5656
}
5757

58-
configurations.all {
59-
resolutionStrategy {
60-
// Conflicts with javax.inject:javax.inject:1
61-
// This is safe to remove, the purpose of the repackaged version is to implement OSGI, which we don't use
62-
// Source: https://stackoverflow.com/a/25218230/274699
63-
exclude group: 'org.glassfish.hk2.external', module: 'jakarta.inject'
64-
}
65-
}
66-
6758
checkImplicitDependencies {
6859
ignore 'com.palantir.conjure.java.runtime', 'conjure-java-jersey-jakarta-server'
6960
}

conjure-java-server-verifier/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@ dependencies {
88
testImplementation project(':conjure-java-jaxrs-client')
99
testImplementation project(':conjure-java-jersey-jakarta-server')
1010
testImplementation project(':keystores')
11-
testImplementation project(':okhttp-clients')
1211
testImplementation project(':undertow-jakarta-testing')
1312
testImplementation 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml'
1413
testImplementation 'com.fasterxml.jackson.datatype:jackson-datatype-jdk8'
14+
testImplementation 'com.palantir.conjure.java:conjure-lib'
15+
testImplementation 'jakarta.ws.rs:jakarta.ws.rs-api'
1516
testImplementation 'org.junit.jupiter:junit-jupiter'
1617
testImplementation 'org.junit.jupiter:junit-jupiter-api'
1718
testImplementation 'org.junit.jupiter:junit-jupiter-params'

gradle/verifier.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ dependencies {
2727
generatedJerseyImplementation 'jakarta.ws.rs:jakarta.ws.rs-api'
2828
generatedJerseyImplementation sourceSets.generatedObjects.output
2929

30-
testImplementation 'com.palantir.conjure.java:conjure-lib'
31-
testImplementation 'jakarta.ws.rs:jakarta.ws.rs-api'
3230
testImplementation sourceSets.generatedObjects.output
3331
testImplementation sourceSets.generatedJersey.output
3432
}
@@ -102,5 +100,3 @@ test.dependsOn unpackVerifier, copyTestCases
102100

103101
checkstyleGeneratedObjects.enabled = false
104102
checkstyleGeneratedJersey.enabled = false
105-
106-
checkUnusedDependenciesTest.enabled = false

versions.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ com.fasterxml.jackson.module:jackson-module-jakarta-xmlbind-annotations:2.20.0 (
2828

2929
com.fasterxml.jackson.module:jackson-module-scala_2.12:2.20.0 (1 constraints: 3605333b)
3030

31-
com.github.ben-manes.caffeine:caffeine:3.2.3 (3 constraints: e42397a2)
31+
com.github.ben-manes.caffeine:caffeine:3.2.2 (3 constraints: e3233da2)
3232

3333
com.google.code.findbugs:jsr305:3.0.2 (7 constraints: 5f6b7728)
3434

35-
com.google.errorprone:error_prone_annotations:2.7.1 (18 constraints: bd186fb8)
35+
com.google.errorprone:error_prone_annotations:2.41.0 (18 constraints: ba1866af)
3636

3737
com.google.guava:failureaccess:1.0.3 (1 constraints: 160ae3b4)
3838

versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
com.fasterxml.jackson.*:* = 2.20.0
22
com.fasterxml.jackson.core:jackson-annotations = 2.20
3-
com.github.ben-manes.caffeine:caffeine = 3.2.3
3+
com.github.ben-manes.caffeine:caffeine = 3.2.2
44
com.google.code.findbugs:jsr305 = 3.0.2
55
com.google.guava:guava = 33.5.0-jre
66
com.netflix.concurrency-limits:* = 0.2.2

0 commit comments

Comments
 (0)