Remove obsolete performance trace logging (#7164)

Remove obsolete performance trace logging

Author: schlosna

atlasdb-client/build.gradle

@@ -63,7 +63,6 @@ dependencies {
   implementation 'com.palantir.tritium:tritium-ids'
   implementation 'com.palantir.tritium:tritium-lib'
   implementation 'com.palantir.tritium:tritium-registry'
-  implementation 'com.palantir.tritium:tritium-slf4j'
   implementation 'com.squareup:javapoet'
   implementation 'io.dropwizard.metrics:metrics-core'
   implementation 'org.apache.commons:commons-lang3'

atlasdb-client/src/main/java/com/palantir/atlasdb/util/AtlasDbMetrics.java

@@ -23,16 +23,13 @@
 import com.palantir.tritium.api.event.InstrumentationFilter;
 import com.palantir.tritium.event.InstrumentationFilters;
 import com.palantir.tritium.event.InvocationContext;
-import com.palantir.tritium.event.log.LoggingInvocationEventHandler;
-import com.palantir.tritium.event.log.LoggingLevel;
 import com.palantir.tritium.metrics.caffeine.CaffeineCacheStats;
 import com.palantir.tritium.metrics.registry.TaggedMetricRegistry;
 import com.palantir.tritium.proxy.Instrumentation;
 import java.util.Map;
 import java.util.Set;
 import java.util.function.Function;
 import java.util.stream.Collectors;
-import org.slf4j.LoggerFactory;
 
 public final class AtlasDbMetrics {
     private static final SafeLogger log = SafeLoggerFactory.get(AtlasDbMetrics.class);
@@ -75,7 +72,6 @@ public static <T, U extends T> T instrumentWithTaggedMetrics(
         return Instrumentation.builder(serviceInterface, service)
                 .withHandler(
                         new TaggedMetricsInvocationEventHandler(taggedMetrics, MetricRegistry.name(serviceInterface)))
-                .withPerformanceTraceLogging()
                 .build();
     }
 
@@ -87,7 +83,6 @@ public static <T, U extends T> T instrumentWithTaggedMetrics(
         return Instrumentation.builder(serviceInterface, service)
                 .withHandler(new TaggedMetricsInvocationEventHandler(
                         taggedMetrics, MetricRegistry.name(serviceInterface), tagFunction))
-                .withPerformanceTraceLogging()
                 .build();
     }
 
@@ -114,10 +109,6 @@ private static <T, U extends T> T instrument(
         return Instrumentation.builder(serviceInterface, service)
                 .withFilter(instrumentationFilter)
                 .withHandler(new SlidingWindowMetricsInvocationHandler(metricRegistry, name))
-                .withLogging(
-                        LoggerFactory.getLogger("performance." + name),
-                        LoggingLevel.TRACE,
-                        LoggingInvocationEventHandler.LOG_DURATIONS_GREATER_THAN_1_MICROSECOND)
                 .build(); // Ok
     }
 

changelog/@unreleased/pr-7164.v2.yml

@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: Remove obsolete performance trace logging
+  links:
+  - https://github.com/palantir/atlasdb/pull/7164

versions.lock

@@ -106,7 +106,7 @@ com.palantir.tritium:tritium-lib:0.88.0 (1 constraints: 4205573b)
 com.palantir.tritium:tritium-metrics:0.88.0 (8 constraints: dd7ce90d)
 com.palantir.tritium:tritium-proxy:0.88.0 (1 constraints: 880e9759)
 com.palantir.tritium:tritium-registry:0.88.0 (13 constraints: d6ef39ef)
-com.palantir.tritium:tritium-slf4j:0.88.0 (2 constraints: c913a771)
+com.palantir.tritium:tritium-slf4j:0.88.0 (1 constraints: 880e9759)
 com.palantir.tritium:tritium-time:0.88.0 (1 constraints: 880e9759)
 com.palantir.tritium:tritium-tracing:0.88.0 (1 constraints: 880e9759)
 com.squareup:javapoet:1.13.0 (4 constraints: 102cc1ed)