wip: fix lints

Author: mefellows

.mocharc.js

@@ -1,9 +1,10 @@
+process.env.TS_NODE_PROJECT = 'tsconfig.test.json';
+
 module.exports = {
 	exclude: '**/*.jest.spec.ts',
-	require: 'ts-node/register',
+	require: ['ts-node/register'],
 	timeout: '30000',
 	slow: '5000',
 	exit: true,
-	require: 'ts-node.js',
 	'check-leaks': true,
 };

eslint.config.mjs

@@ -1,18 +1,68 @@
-// @ts-check
-
 import eslint from '@eslint/js';
-import tseslint from 'typescript-eslint';
-
-import importPlugin from 'eslint-plugin-import';
-import chaiFriendly from 'eslint-plugin-chai-friendly';
-import mochaPlugin from 'eslint-plugin-mocha';
-import eslintConfigPrettier from 'eslint-config-prettier/flat';
+import tsPlugin from '@typescript-eslint/eslint-plugin';
+import tsParser from '@typescript-eslint/parser';
 
-export default tseslint.config(
+export default [
   eslint.configs.recommended,
-  tseslint.configs.recommended,
-  mochaPlugin.configs.recommended,
-  importPlugin.flatConfigs.recommended,
-  chaiFriendly.configs.recommendedFlat,
-  eslintConfigPrettier
-);
+  {
+    files: ['**/*.ts'],
+    ignores: ['**/*.d.ts'],
+    languageOptions: {
+      parser: tsParser,
+      globals: {
+        // Node.js globals
+        Buffer: 'readonly',
+        require: 'readonly',
+        module: 'writable',
+        exports: 'writable',
+        process: 'readonly',
+        console: 'readonly',
+        __dirname: 'readonly',
+        __filename: 'readonly',
+        // Test globals
+        describe: 'readonly',
+        context: 'readonly',
+        it: 'readonly',
+        before: 'readonly',
+        after: 'readonly',
+        beforeEach: 'readonly',
+        afterEach: 'readonly',
+      },
+    },
+    plugins: {
+      '@typescript-eslint': tsPlugin,
+    },
+    rules: {
+      'no-unused-vars': 'off',
+      '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
+      '@typescript-eslint/no-explicit-any': 'warn',
+      'no-redeclare': 'off',
+    },
+  },
+  {
+    files: ['**/*.js'],
+    languageOptions: {
+      sourceType: 'commonjs',
+      globals: {
+        module: 'writable',
+        exports: 'writable',
+        require: 'readonly',
+        Buffer: 'readonly',
+        console: 'readonly',
+        process: 'readonly',
+        __dirname: 'readonly',
+        __filename: 'readonly',
+        describe: 'readonly',
+        context: 'readonly',
+        it: 'readonly',
+        before: 'readonly',
+        after: 'readonly',
+        beforeEach: 'readonly',
+        afterEach: 'readonly',
+      },
+    },
+    rules: {
+      'no-unused-vars': ['error', { varsIgnorePattern: '^(VERIFY_PROVIDER_RESPONSE|FfiFunctionResult|FfiLogLevelFilter|FnValidationStatus)$' }],
+    },
+  },
+];

package-lock.json

@@ -93,7 +93,7 @@
     "eslint-plugin-import": "2.31.0",
     "eslint-plugin-mocha": "11.1.0",
     "express": "5.1.0",
-    "form-data": "4.0.3",
+    "form-data": "4.0.4",
     "globals": "^16.2.0",
     "grpc-promise": "1.4.0",
     "mocha": "11.6.0",
@@ -171,4 +171,4 @@
     "@pact-foundation/pact-core-linux-x64-musl": "16.1.1",
     "@pact-foundation/pact-core-windows-x64": "16.1.1"
   }
-}
+}

package.json

@@ -26,8 +26,8 @@ type BooleanFunctions<T> = {
 export const wrapAllWithCheck = <T extends BooleanFunctions<T>>(
   o: T
 ): BooleanFunctions<T> =>
-  Object.keys(o)
-    .map((key: string) => ({
-      [key]: wrapWithCheck(o[key], key),
+  (Object.keys(o) as Array<keyof T>)
+    .map((key: keyof T) => ({
+      [key]: wrapWithCheck(o[key] as BooleanFunction<T[keyof T]>, String(key)),
     }))
     .reduce((acc, curr) => ({ ...acc, ...curr }), {}) as T;

src/consumer/checkErrors.ts

@@ -107,10 +107,11 @@ export const makeConsumerPact = (
         `${address}:${requestedPort || 0}`,
         tls
       );
-      const error: keyof typeof CREATE_MOCK_SERVER_ERRORS | undefined =
-        Object.keys(CREATE_MOCK_SERVER_ERRORS).find(
-          (key) => CREATE_MOCK_SERVER_ERRORS[key] === port
-        ) as keyof typeof CREATE_MOCK_SERVER_ERRORS;
+      const error: keyof typeof CREATE_MOCK_SERVER_ERRORS | undefined = (
+        Object.keys(CREATE_MOCK_SERVER_ERRORS) as Array<
+          keyof typeof CREATE_MOCK_SERVER_ERRORS
+        >
+      ).find((key) => CREATE_MOCK_SERVER_ERRORS[key] === port);
       if (error) {
         if (error === 'ADDRESS_NOT_VALID') {
           logErrorAndThrow(

src/consumer/index.ts

@@ -43,7 +43,7 @@ function getPlatformArchSpecificPackage() {
       resolvedPackagePath = resolvedPackagePath.replace('/package.json', '');
     }
     return resolvedPackagePath;
-  } catch (e) {
+  } catch {
     throw new Error(
       `Couldn't find npm package ${platformArchSpecificPackage} \n 💡 you can tell Pact where the npm package is located with env var $PACT_PREBUILD_PACKAGE_LOCATION`
     );
@@ -151,7 +151,7 @@ const initialiseFfi = (): typeof ffi => {
           return false;
         }
         return true;
-      } catch (error) {
+      } catch {
         return true;
       }
     });

src/ffi/index.ts

@@ -8,7 +8,7 @@ export type FfiMessageHandle = number;
 // TODO: Replace this pattern of type + const + lint disable with enums
 
 export type FfiSpecificationVersion = 0 | 1 | 2 | 3 | 4 | 5;
- 
+
 export const FfiSpecificationVersion: Record<string, FfiSpecificationVersion> =
   {
     SPECIFICATION_VERSION_UNKNOWN: 0,
@@ -20,7 +20,7 @@ export const FfiSpecificationVersion: Record<string, FfiSpecificationVersion> =
   };
 
 export type FfiWritePactResponse = 0 | 1 | 2 | 3;
- 
+
 export const FfiWritePactResponse: Record<string, FfiWritePactResponse> = {
   SUCCESS: 0,
   GENERAL_PANIC: 1,
@@ -29,7 +29,7 @@ export const FfiWritePactResponse: Record<string, FfiWritePactResponse> = {
 };
 
 export type FfiWriteMessagePactResponse = 0 | 1 | 2;
- 
+
 export const FfiWriteMessagePactResponse: Record<
   string,
   FfiWriteMessagePactResponse
@@ -40,7 +40,7 @@ export const FfiWriteMessagePactResponse: Record<
 };
 
 export type FfiConfigurePluginResponse = 0 | 1 | 2 | 3;
- 
+
 export const FfiConfigurePluginResponse: Record<
   string,
   FfiConfigurePluginResponse
@@ -52,7 +52,7 @@ export const FfiConfigurePluginResponse: Record<
 };
 
 export type FfiPluginInteractionResponse = 0 | 1 | 2 | 3 | 4 | 5 | 6;
- 
+
 export const FfiPluginInteractionResponse: Record<
   string,
   FfiPluginInteractionResponse
@@ -87,7 +87,7 @@ export const CREATE_MOCK_SERVER_ERRORS = {
 -5	The address is not valid
 -6	Could not create the TLS configuration with the self-signed certificate
 */
- 
+
 export enum VERIFY_PROVIDER_RESPONSE {
   VERIFICATION_SUCCESSFUL = 0,
   VERIFICATION_FAILED,

src/ffi/types.ts

@@ -1,10 +1,8 @@
-import * as chai from 'chai';
-import index from './index';
+import { expect } from 'chai';
+import pact from './index';
 
-const { expect } = chai;
-
-describe('Index Spec', function() {
-  it('Typescript import should work', function() {
-    expect(index).to.be.ok;
+describe('Index Spec', function () {
+  it('Typescript import should work', function () {
+    expect(pact).to.be.ok;
   });
 });

src/index.spec.ts

@@ -1,6 +1,5 @@
 import pact from './pact';
 
- 
 module.exports = exports = pact;
 
 export default pact;