remove 'invalid cran purl without version' testcases #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
This was referenced Nov 4, 2025
Contributor
Author
|
Anything preventing this from being merged? |
shibumi
approved these changes
Dec 3, 2025
Member
|
Thanks. Technically, the version is always optional for all types. Good catch. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #736
The
versioncomponent is optional forpkg:cranaccording to spec. Therefore it makes no sense to have tests requiring parsing to fail when theversionis missing.