Improve regex

rogervinas · rogervinas · commit f234cc83a338 · 2024-11-29T10:42:12.000+01:00
diff --git a/java-snapshot-testing-core/src/main/java/au/com/origin/snapshots/Snapshot.java b/java-snapshot-testing-core/src/main/java/au/com/origin/snapshots/Snapshot.java
@@ -29,7 +29,7 @@ public String getIdentifier() {
   }
 
   public static Snapshot parse(String rawText) {
-    String regex = "^(?<name>.*?)(\\[(?<scenario>.*)\\])?=(?<header>\\{.*?\\})?(?<snapshot>(.*)$)";
+    String regex = "^(?<name>.*?)(\\[(?<scenario>[^]]*)])?=(?<header>\\{[^}]*?})?(?<snapshot>(.*)$)";
     Pattern p = Pattern.compile(regex, Pattern.DOTALL);
     Matcher m = p.matcher(rawText);
     boolean found = m.find();

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public String getIdentifier() {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`public static Snapshot parse(String rawText) {`
`32`		`- String regex = "^(?<name>.?)(\\[(?<scenario>.)\\])?=(?<header>\\{.?\\})?(?<snapshot>(.)$)";`
	`32`	`+ String regex = "^(?<name>.?)(\\[(?<scenario>[^]])])?=(?<header>\\{[^}]?})?(?<snapshot>(.)$)";`
`33`	`33`	`Pattern p = Pattern.compile(regex, Pattern.DOTALL);`
`34`	`34`	`Matcher m = p.matcher(rawText);`
`35`	`35`	`boolean found = m.find();`