Skip to content

The space lost after the colon in getAllResponseHeaders() #68

@ewfian

Description

@ewfian

I found that The return value of polyfilled getAllResponseHeaders() will not same as native, it will make some thing broken.
I have created a pull request to fix this : #67

  1. The origin http header
    image

  2. Parsed response header
    image

  3. The return value of polyfilled getAllResponseHeaders()
    The space lost here
    image

  4. The FIRST CHAR LOST.
    Some 3rd libraries like azure-sdk-for-js makes http request by using XMLHttpRequest and parses header by itself just like following code
    https://github.com/Azure/azure-sdk-for-js/blob/744e51acb755db2c565c71a8856d8d13e6ec345b/sdk/core/core-https/src/xhrHttpsClient.ts#L129
    If the return value from the polyfilled function XMLHttpRequest.getAllResponseHeaders() is not keeps the exact same format (Date: Thu, 01 Oct 2020 05:18:27 GMT\r\n) as the original value, some thing will broken.
    image

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions