Modify the script to add additional support for network validation #347
Conversation
Merge development branch to main after 25.4.1 release --------- Co-authored-by: Sarada Kommalapati <52939928+skommala@users.noreply.github.com> Co-authored-by: Sarada Kommalapati <sarada.kommalapati@oracle.com> Co-authored-by: Abhijit Paranjpe <109541284+abhijit-paranjpe@users.noreply.github.com> Co-authored-by: telake <tim.lake@oracle.com> Co-authored-by: Roberto Sanchez Herrera <roberto.s.sanchez@oracle.com> Co-authored-by: P M Darshan <p.m.darshan@oracle.com> Co-authored-by: C R Aniruddh Srivatsa <c.r.aniruddh.srivatsa@oracle.com> Co-authored-by: Mahuwa Barman <106961326+Mahuwa-Barman@users.noreply.github.com> Co-authored-by: Chintamani Bhat <chintamani.bhat@oracle.com> Co-authored-by: Sarada Kommalapati <sarada.kommlapati@oracle.com> Co-authored-by: Adrian Padilla Duarte <adrian.padilla@oracle.com> Co-authored-by: Mahuwa-Barman <mahuwa.barman@oracle.com> Co-authored-by: srjanaki <srinath.janakiraman@oracle.com> Co-authored-by: ManviGupta-prog <Manvi.g.gupta@oracle.com> Co-authored-by: Ananya Tripathi <ananya.tripathi@oracle.com> Co-authored-by: Siddharth Sahu <siddharth.y.sahu@oracle.com> Co-authored-by: Siddharth Sahu <sysahu@Mac.lan> Co-authored-by: Rajesh Chavan <rachavan@Rajeshs-MacBook-Pro.local>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
terraform/modules/network-validator/scripts/network_validation.sh
Outdated
Show resolved
Hide resolved
terraform/modules/network-validator/scripts/network_validation.sh
Outdated
Show resolved
Hide resolved
terraform/modules/network-validator/scripts/network_validation.sh
Outdated
Show resolved
Hide resolved
|
Have addressed all other comments. |
terraform/modules/network-validator/scripts/network_validation.sh
Outdated
Show resolved
Hide resolved
terraform/modules/network-validator/scripts/network_validation.sh
Outdated
Show resolved
Hide resolved
terraform/modules/network-validator/scripts/network_validation.sh
Outdated
Show resolved
Hide resolved
oracle-contributor-agreement
bot
added
OCA Verified
roberto-sanchez-herrera
left a comment
roberto-sanchez-herrera
left a comment
There was a problem hiding this comment.
Approved. Added minor comment
terraform/modules/network-validator/scripts/network_validation.sh
Outdated
Show resolved
Hide resolved
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
OCA Required
4 participants
Following are the list of changes that are being done -
a.) Added a check to see if the subnet is created with the option "Use DNS hostnames in this VCN" enabled
b.) Made modification to the code to correctly verify the option for CustomDNSResolver
c.) When the LPG's are peered, they are in the status as "Peered". MAde the code change to check if the status is "Peered" or not.
d.) Ensured that the Route table associated with the subnet of WLS and DB does have a Route rule to the LPG with the corresponding CIDR. Also, it will verify if the CIDR of the Route rule does fall with the VCN's range.
e.) Also added a check to ensure that the WLS Subnet SecList/NSG does have an egress rule to the DB Port and DB CIDR.
f.) Added a new option to specify the WLS LPG OCID and also added a check to make sure that both the LPG OCID's are provided in the command.