Chat app css illustration #147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngumokenneth
commented
Oct 9, 2023
ngumokenneth
commented
almirsarajcic
requested changes
Oct 12, 2023
Member
almirsarajcic
left a comment
almirsarajcic
left a comment
There was a problem hiding this comment.
Big difference between the design proposal and this implementation. Also, images should be inside the challenge directory.
| <div class="mt-3"> | ||
| <a | ||
| class="text-optimum-blue hover:text-optimum-darkblue" | ||
| href="https://github.com/optimumBA/frontend_mentor_challenges/tree/chat_app_css_illustration/challenges/chat_app_css_illustration" |
Member
There was a problem hiding this comment.
Put your username instead of optimumBA.
Author
There was a problem hiding this comment.
Noted. I'll make the changes. Thanks.
…t,changed the conversation bakground color, adjusted the position of the background images
almirsarajcic
requested changes
Oct 25, 2023
Member
almirsarajcic
left a comment
almirsarajcic
left a comment
There was a problem hiding this comment.
You still have some unnecessary file changes.
You shouldn't touch favicons. They aren't a part of challenges.
almirsarajcic
requested changes
Oct 26, 2023
Member
almirsarajcic
left a comment
almirsarajcic
left a comment
There was a problem hiding this comment.
UI needs to be improved.
almirsarajcic
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.