Another try

esrakartalOpt · esrakartalOpt · commit 306d0a8cb5eb · 2025-12-03T15:34:08.000-06:00
diff --git a/lib/optimizely.rb b/lib/optimizely.rb
@@ -1280,7 +1280,8 @@ def send_impression(config, experiment, variation_key, flag_key, rule_key, enabl
       }
       metadata[:cmab_uuid] = cmab_uuid unless cmab_uuid.nil?
 
-      user_event = UserEventFactory.create_impression_event(config, experiment, variation_id, metadata, user_id, attributes)
+      event_attributes = rule_type == Optimizely::DecisionService::DECISION_SOURCES['HOLDOUT'] ? nil : attributes
+      user_event = UserEventFactory.create_impression_event(config, experiment, variation_id, metadata, user_id, event_attributes)
       @event_processor.process(user_event)
       return unless @notification_center.notification_count(NotificationCenter::NOTIFICATION_TYPES[:ACTIVATE]).positive?
 

Original file line number	Diff line number	Diff line change
`@@ -1280,7 +1280,8 @@ def send_impression(config, experiment, variation_key, flag_key, rule_key, enabl`
`1280`	`1280`	`}`
`1281`	`1281`	`metadata[:cmab_uuid] = cmab_uuid unless cmab_uuid.nil?`
`1282`	`1282`
`1283`		`- user_event = UserEventFactory.create_impression_event(config, experiment, variation_id, metadata, user_id, attributes)`
	`1283`	`+ event_attributes = rule_type == Optimizely::DecisionService::DECISION_SOURCES['HOLDOUT'] ? nil : attributes`
	`1284`	`+ user_event = UserEventFactory.create_impression_event(config, experiment, variation_id, metadata, user_id, event_attributes)`
`1284`	`1285`	`@event_processor.process(user_event)`
`1285`	`1286`	`return unless @notification_center.notification_count(NotificationCenter::NOTIFICATION_TYPES[:ACTIVATE]).positive?`
`1286`	`1287`