Skip to content

Commit f251353

Browse files
authored
refactor(utils): [grid,tree] rename log to logger (#2826)
* refactor(utils): rename log to logger * fix(utils): fix
1 parent 4e29aaf commit f251353

File tree

11 files changed

+32
-33
lines changed

11 files changed

+32
-33
lines changed

packages/renderless/src/common/validate/util.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
*/
1212

1313
import { hasOwn, isNull } from '../type'
14-
import { log } from '@opentiny/utils'
14+
import { logger } from '@opentiny/utils'
1515

1616
const formatRegExp = /%[sdj%]/g
1717

@@ -208,7 +208,7 @@ export function asyncMap(objArray, option, func, callback) {
208208
})
209209

210210
// 校验器会报告中,errors fields 同时存在,属于正常,不打印; 代码真异常才打印。
211-
pending.catch((error) => (error.errors && error.fields) || log.logger.error(error))
211+
pending.catch((error) => (error.errors && error.fields) || logger.error(error))
212212
return pending
213213
}
214214

@@ -244,7 +244,7 @@ export function asyncMap(objArray, option, func, callback) {
244244
})
245245

246246
// 校验器会报告中,errors fields 同时存在,属于正常,不打印; 代码真异常才打印。
247-
pending.catch((error) => (error.errors && error.fields) || log.logger.error(error))
247+
pending.catch((error) => (error.errors && error.fields) || logger.error(error))
248248

249249
return pending
250250
}

packages/renderless/src/currency/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
*/
1212

1313
import { isUndefined, isNull } from '../grid/static'
14-
import { log } from '@opentiny/utils'
14+
import { logger } from '@opentiny/utils'
1515

1616
export const init =
1717
({ state, service, api }) =>
@@ -76,7 +76,7 @@ export const fixServiceData =
7676
if (text) {
7777
option[valueField] = text
7878
} else {
79-
log('data error. set it to the default value.', 'warn')
79+
logger.warn('data error. set it to the default value.')
8080
option[textField] = option[valueField] = props.currency
8181
}
8282
}

packages/renderless/src/file-upload/index.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import type {
3030
} from '@/types'
3131

3232
import { extend } from '../common/object'
33-
import { xss, log, crypt } from '@opentiny/utils'
33+
import { xss, logger, crypt } from '@opentiny/utils'
3434
import uploadAjax from '../common/deps/upload-ajax'
3535
import { isObject } from '../common/type'
3636
import { isEmptyObject } from '../common/type'
@@ -555,7 +555,7 @@ export const handleStart =
555555
state,
556556
vm
557557
}: Pick<IFileUploadRenderlessParams, 'api' | 'constants' | 'props' | 'state' | 'vm'>) =>
558-
(rawFiles: IFileUploadFile[], updateId: string, reUpload: boolean = false) => {
558+
(rawFiles: IFileUploadFile[], updateId: string, reUpload = false) => {
559559
if (state.isHwh5) {
560560
rawFiles = handleHwh5Files(rawFiles, props.hwh5)
561561
}
@@ -900,7 +900,7 @@ export const abort =
900900

901901
export const abortDownload =
902902
({ state }: Pick<IFileUploadRenderlessParams, 'state'>) =>
903-
(file: IFileUploadFile, batch: boolean = false) => {
903+
(file: IFileUploadFile, batch = false) => {
904904
const cancel = (docId) => {
905905
if (!docId) return
906906
const cancels = state.downloadCancelToken[docId]
@@ -1685,7 +1685,7 @@ export const afterDownload =
16851685
']'
16861686
]
16871687

1688-
log.logger.warn(msgArray.join(''))
1688+
logger.warn(msgArray.join(''))
16891689
delete state.downloadReplayAtoms[key]
16901690
} else {
16911691
if (state.downloadReplayAtoms[key] === undefined) {
@@ -1694,7 +1694,7 @@ export const afterDownload =
16941694

16951695
const msgArray = ['replay ', countDownloadReplay, '! [docId:', file.docId, ', chunk:', range.index, ']']
16961696

1697-
log.logger.warn(msgArray.join(''))
1697+
logger.warn(msgArray.join(''))
16981698

16991699
state.downloadReplayAtoms[key] += 1
17001700

@@ -1932,7 +1932,7 @@ const afterUpload = ({
19321932
file.chunk,
19331933
']'
19341934
]
1935-
log.logger.warn(msgArray.join(''))
1935+
logger.warn(msgArray.join(''))
19361936

19371937
delete state.replayAtoms[key]
19381938
} else {
@@ -1942,7 +1942,7 @@ const afterUpload = ({
19421942

19431943
const msgArray = ['replay ', countReplay, '! [docId:', file.docId, ', chunk:', file.chunk, ']']
19441944

1945-
log.logger.warn(msgArray.join(''))
1945+
logger.warn(msgArray.join(''))
19461946

19471947
state.replayAtoms[key] += 1
19481948

@@ -2263,7 +2263,7 @@ export const getToken =
22632263

22642264
export const previewFile =
22652265
({ api, props }: Pick<IFileUploadRenderlessParams, 'api' | 'props'>) =>
2266-
(file: IFileUploadFile, open: boolean = false) => {
2266+
(file: IFileUploadFile, open = false) => {
22672267
return new Promise((resolve, reject) => {
22682268
try {
22692269
const tokenParams = { isOnlinePreview: true, file, type: 'preview', token: props.edm.preview.token }

packages/renderless/src/tree/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { on, off } from '../common/deps/dom'
1818
import { getDataset } from '../common/dataset'
1919
import { copyArray } from '../common/object'
2020

21-
import { log } from '@opentiny/utils'
21+
import { logger } from '@opentiny/utils'
2222

2323
export const setChildren = (props) => (data) => (props.data = data)
2424

@@ -823,7 +823,7 @@ export const addNode =
823823
}
824824

825825
if (state.allNodeKeys.includes(nodeId) && !props.editConfig.noWarning) {
826-
log.logger.warn(`the ${props.nodeKey || 'id'} ${nodeId} is already exists. Please check.`)
826+
logger.warn(`the ${props.nodeKey || 'id'} ${nodeId} is already exists. Please check.`)
827827
}
828828

829829
state.allNodeKeys.push(nodeId)

packages/renderless/src/user/index.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import debounce from '../common/deps/debounce'
1414
import { toDateStr } from '../common/date'
1515
import { toJsonStr } from '../common/object'
1616
import { toJson } from '../common/string'
17-
import { log } from '@opentiny/utils'
17+
import { logger } from '@opentiny/utils'
1818

1919
const toLowerCase = (val) => {
2020
return typeof val === 'string' ? val.toLowerCase() : val
@@ -87,7 +87,6 @@ const request = {
8787
},
8888

8989
setCache(data, valueField) {
90-
// eslint-disable-next-line @typescript-eslint/no-this-alias
9190
const me = this
9291

9392
if (valueField && !this.group[valueField]) {
@@ -116,7 +115,6 @@ const request = {
116115
})
117116
},
118117
batchRequest(api) {
119-
// eslint-disable-next-line @typescript-eslint/no-this-alias
120118
const me = this
121119
const reqParamsSeq = me.getParams()
122120
let reqLen = reqParamsSeq.length
@@ -141,7 +139,7 @@ const request = {
141139
}
142140
})
143141
})
144-
errors.length && log.logger.warn(`user [${errors.join(',')}] not found`)
142+
errors.length && logger.warn(`user [${errors.join(',')}] not found`)
145143
this.clearRequest()
146144
}
147145
}

packages/utils/src/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import xss from './xss'
2-
import log from './log'
2+
import logger from './logger'
33
import crypt from './crypt'
44

5-
export { xss, log, crypt }
5+
export { xss, logger, crypt }
66

77
export default {
88
xss,
9-
log,
9+
logger,
1010
crypt
1111
}

packages/utils/src/log/index.ts

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/utils/src/logger/index.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import { getWindow } from '../window'
2+
3+
const _win: any = getWindow()
4+
/** 使用 logger.xxx 代替 window.console.xxx, 避免语法警告 */
5+
export const logger = _win.console as Console
6+
7+
export default logger

packages/vue-common/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,11 @@
3131
"@opentiny/vue-locale": "workspace:~",
3232
"@opentiny/vue-renderless": "workspace:~",
3333
"@opentiny/vue-theme": "workspace:~",
34+
"@opentiny/utils": "workspace:~",
3435
"tailwind-merge": "^1.8.0"
3536
},
3637
"scripts": {
3738
"build": "pnpm -w build:ui $npm_package_name",
3839
"//postversion": "pnpm build"
3940
}
40-
}
41+
}

packages/vue-common/src/breakpoint.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import debounce from '@opentiny/vue-renderless/common/deps/debounce'
77
*
88
* @example
99
* const breakpoint = useBreakpoint()
10-
* watch(breakpoint.current, (current) => { console.log(current) })
10+
* watch(breakpoint.current, (current) => { ...... })
1111
*/
1212
export const useBreakpoint = () => {
1313
const activeBreakpoint = hooks.ref('')

0 commit comments

Comments
 (0)