chore(lint): fix noAccumulatingSpread rule and remove from config

Author: maxmorozoff

biome.jsonc

@@ -32,8 +32,7 @@
         "noBannedTypes": "warn"
       },
       "performance": {
-        "noDelete": "warn",
-        "noAccumulatingSpread": "warn"
+        "noDelete": "warn"
       }
     }
   },

examples/sst/stacks/OpenNextReferenceImplementation.ts

@@ -391,26 +391,24 @@ export class OpenNextCdkReferenceImplementation extends Construct {
         .filter((b) => b.pattern !== "*")
         .reduce(
           (acc, behavior) => {
-            return {
-              ...acc,
-              [behavior.pattern]: {
-                origin: behavior.origin
-                  ? origins[behavior.origin]
-                  : origins.default,
-                viewerProtocolPolicy: ViewerProtocolPolicy.REDIRECT_TO_HTTPS,
-                allowedMethods: AllowedMethods.ALLOW_GET_HEAD_OPTIONS,
-                cachedMethods: CachedMethods.CACHE_GET_HEAD_OPTIONS,
-                cachePolicy:
-                  behavior.origin === "s3"
-                    ? this.staticCachePolicy
-                    : this.serverCachePolicy,
-                originRequestPolicy:
-                  behavior.origin === "s3"
-                    ? undefined
-                    : OriginRequestPolicy.ALL_VIEWER_EXCEPT_HOST_HEADER,
-                functionAssociations: fnAssociations,
-              },
+            acc[behavior.pattern] = {
+              origin: behavior.origin
+                ? origins[behavior.origin]
+                : origins.default,
+              viewerProtocolPolicy: ViewerProtocolPolicy.REDIRECT_TO_HTTPS,
+              allowedMethods: AllowedMethods.ALLOW_GET_HEAD_OPTIONS,
+              cachedMethods: CachedMethods.CACHE_GET_HEAD_OPTIONS,
+              cachePolicy:
+                behavior.origin === "s3"
+                  ? this.staticCachePolicy
+                  : this.serverCachePolicy,
+              originRequestPolicy:
+                behavior.origin === "s3"
+                  ? undefined
+                  : OriginRequestPolicy.ALL_VIEWER_EXCEPT_HOST_HEADER,
+              functionAssociations: fnAssociations,
             };
+            return acc;
           },
           {} as Record<string, BehaviorOptions>,
         ),

packages/open-next/src/core/requestHandler.ts

@@ -55,15 +55,19 @@ export async function openNextHandler(
     "type" in preprocessResult
       ? preprocessResult.headers
       : preprocessResult.internalEvent.headers,
-  ).reduce((acc, [key, value]) => {
-    if (!key.startsWith("x-middleware-response-")) {
+  ).reduce(
+    (acc, [key, value]) => {
+      if (!key.startsWith("x-middleware-response-")) {
+        return acc;
+      }
+      const newKey = key.replace("x-middleware-response-", "");
+      delete headers[key];
+      headers[newKey] = value;
+      acc[newKey] = value;
       return acc;
-    }
-    const newKey = key.replace("x-middleware-response-", "");
-    delete headers[key];
-    headers[newKey] = value;
-    return { ...acc, [newKey]: value };
-  }, {});
+    },
+    {} as Record<string, string | string[]>,
+  );
 
   if ("type" in preprocessResult) {
     // // res is used only in the streaming case

packages/open-next/src/core/routing/matcher.ts

@@ -214,11 +214,11 @@ export function handleRewrites<T extends RewriteDefinition>(
       ),
       // params for the has
       ...rewrite.has?.reduce((acc, cur) => {
-        return { ...acc, ...computeHas(cur) };
+        return Object.assign(acc, computeHas(cur));
       }, {}),
       // params for the missing
       ...rewrite.missing?.reduce((acc, cur) => {
-        return { ...acc, ...computeHas(cur) };
+        return Object.assign(acc, computeHas(cur));
       }, {}),
     };
     const isUsingParams = Object.keys(params).length > 0;

packages/open-next/src/core/routing/util.ts

@@ -31,7 +31,8 @@ export function convertFromQueryString(query: string) {
   return queryParts.reduce(
     (acc, part) => {
       const [key, value] = part.split("=");
-      return { ...acc, [key]: value };
+      acc[key] = value;
+      return acc;
     },
     {} as Record<string, string>,
   );

packages/open-next/src/overrides/converters/aws-apigw-v1.ts

@@ -69,10 +69,14 @@ async function convertFromAPIGatewayProxyEvent(
       event.multiValueQueryStringParameters ?? {},
     ),
     cookies:
-      event.multiValueHeaders?.cookie?.reduce((acc, cur) => {
-        const [key, value] = cur.split("=");
-        return { ...acc, [key]: value };
-      }, {}) ?? {},
+      event.multiValueHeaders?.cookie?.reduce(
+        (acc, cur) => {
+          const [key, value] = cur.split("=");
+          acc[key] = value;
+          return acc;
+        },
+        {} as Record<string, string>,
+      ) ?? {},
   };
 }
 

packages/open-next/src/overrides/converters/aws-apigw-v2.ts

@@ -84,10 +84,14 @@ async function convertFromAPIGatewayProxyEventV2(
     remoteAddress: requestContext.http.sourceIp,
     query: removeUndefinedFromQuery(convertToQuery(rawQueryString)),
     cookies:
-      event.cookies?.reduce((acc, cur) => {
-        const [key, value] = cur.split("=");
-        return { ...acc, [key]: value };
-      }, {}) ?? {},
+      event.cookies?.reduce(
+        (acc, cur) => {
+          const [key, value] = cur.split("=");
+          acc[key] = value;
+          return acc;
+        },
+        {} as Record<string, string>,
+      ) ?? {},
   };
 }
 

packages/open-next/src/overrides/converters/aws-cloudfront.ts

@@ -101,10 +101,14 @@ async function convertFromCloudFrontRequestEvent(
     remoteAddress: clientIp,
     query: convertToQuery(querystring),
     cookies:
-      headers.cookie?.reduce((acc, cur) => {
-        const { key, value } = cur;
-        return { ...acc, [key ?? ""]: value };
-      }, {}) ?? {},
+      headers.cookie?.reduce(
+        (acc, cur) => {
+          const { key = "", value } = cur;
+          acc[key] = value;
+          return acc;
+        },
+        {} as Record<string, string>,
+      ) ?? {},
   };
 }