chore: minor refactoring

Author: vicb

packages/open-next/src/build/createServerBundle.ts

@@ -117,7 +117,6 @@ async function generateBundle(
   //       `node_modules` inside `.next/standalone`, and others inside
   //       `.next/standalone/package/path` (ie. `.next`, `server.js`).
   //       We need to output the handler file inside the package path.
-  const isMonorepo = monorepoRoot !== appPath;
   const packagePath = path.relative(monorepoRoot, appBuildOutputPath);
   fs.mkdirSync(path.join(outputPath, packagePath), { recursive: true });
 
@@ -244,6 +243,7 @@ async function generateBundle(
     options,
   );
 
+  const isMonorepo = monorepoRoot !== appPath;
   if (isMonorepo) {
     addMonorepoEntrypoint(outputPath, packagePath);
   }
@@ -301,7 +301,7 @@ function addMonorepoEntrypoint(outputPath: string, packagePath: string) {
   const packagePosixPath = packagePath.split(path.sep).join(path.posix.sep);
   fs.writeFileSync(
     path.join(outputPath, "index.mjs"),
-    [`export * from "./${packagePosixPath}/index.mjs";`].join(""),
+    `export * from "./${packagePosixPath}/index.mjs";`,
   );
 }
 

packages/open-next/src/build/validateConfig.ts

@@ -99,7 +99,7 @@ export function validateConfig(config: OpenNextConfig) {
   }
   if (config.dangerous?.disableTagCache) {
     logger.warn(
-      `You've disabled tag cache. 
+      `You've disabled tag cache.
        This means that revalidatePath and revalidateTag from next/cache will not work.
        It is safe to disable if you only use page router`,
     );

packages/open-next/src/overrides/converters/aws-apigw-v2.ts

@@ -11,7 +11,8 @@ import { debug } from "../../adapters/logger";
 import { convertToQuery } from "../../core/routing/util";
 import { removeUndefinedFromQuery } from "./utils";
 
-// Not sure which one is reallly needed as this is not documented anywhere but server actions redirect are not working without this, it causes a 500 error from cloudfront itself with a 'x-amzErrortype: InternalFailure' header
+// Not sure which one is really needed as this is not documented anywhere but server actions redirect are not working without this,
+// it causes a 500 error from cloudfront itself with a 'x-amzErrortype: InternalFailure' header
 const CloudFrontBlacklistedHeaders = [
   "connection",
   "expect",

packages/open-next/src/overrides/converters/edge.ts

@@ -16,7 +16,9 @@ const converter: Converter<
   InternalResult | ({ type: "middleware" } & MiddlewareOutputEvent)
 > = {
   convertFrom: async (event: Request) => {
-    const searchParams = new URL(event.url).searchParams;
+    const url = new URL(event.url);
+
+    const searchParams = url.searchParams;
     const query: Record<string, string | string[]> = {};
     for (const [key, value] of searchParams.entries()) {
       if (key in query) {
@@ -29,13 +31,13 @@ const converter: Converter<
         query[key] = value;
       }
     }
-    //Transform body into Buffer
+    // Transform body into Buffer
     const body = await event.arrayBuffer();
     const headers: Record<string, string> = {};
     event.headers.forEach((value, key) => {
       headers[key] = value;
     });
-    const rawPath = new URL(event.url).pathname;
+    const rawPath = url.pathname;
     const method = event.method;
     const shouldHaveBody = method !== "GET" && method !== "HEAD";
     const cookies: Record<string, string> = Object.fromEntries(
@@ -100,9 +102,10 @@ const converter: Converter<
     for (const [key, value] of Object.entries(result.headers)) {
       headers.set(key, Array.isArray(value) ? value.join(",") : value);
     }
+
     return new Response(result.body as ReadableStream, {
       status: result.statusCode,
-      headers: headers,
+      headers,
     });
   },
   name: "edge",