Skip to content

Conversation

@IamMujuziMoses
Copy link
Contributor

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-677

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

ScreenShots

PatientIdentifier from postman

Patient.Identifier.mp4

PersonName from postman

Person.Name.mp4

@IamMujuziMoses
Copy link
Contributor Author

@djazayeri @ibacher @dkayiwa could you please review this PR, your feedback will be appreciated.

@IamMujuziMoses
Copy link
Contributor Author

IamMujuziMoses commented May 29, 2025

You can’t change preferred to false, only to true, and only if personName, personAddress or patientIdentifier items are more than one. For instance if you have more than two items and you change the true one to false, picking randomly the one to update to true isn't ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant