Skip to content

Commit 7eb6881

Browse files
committed
fix some of the reviews
1 parent 867f049 commit 7eb6881

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

omod-2.0/src/test/java/org/openmrs/module/webservices/rest/resource/SubDetailsResource.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,6 @@ public DelegatingResourceDescription getRepresentationDescription(Representation
6464
return new DelegatingResourceDescription();
6565
}
6666

67-
@Override
68-
public DelegatingResourceDescription getCreatableProperties() throws ResourceDoesNotSupportOperationException {
69-
return new DelegatingResourceDescription();
70-
}
71-
7267
@Override
7368
public SubDetails newDelegate() {
7469
return new SubDetails();

omod-common/src/main/java/org/openmrs/module/webservices/docs/swagger/SwaggerGenerationUtil.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -284,14 +284,14 @@ public static String getResourceNameBySupportedClass(Class<?> supportedClass) {
284284
}
285285

286286
public static String getSubResourceNameBySupportedClass(Class<?> supportedClass) {
287-
org.openmrs.module.webservices.rest.web.resource.api.Resource resource = Context.getService(RestService.class).getResourceHandlerForSupportedClass(supportedClass);
287+
org.openmrs.module.webservices.rest.web.resource.api.Resource resourceHandler = Context.getService(RestService.class).getResourceHandlerForSupportedClass(supportedClass);
288288

289-
if (resource == null) {
289+
if (resourceHandler == null) {
290290
return null;
291291
}
292292

293-
Resource annotation = resource.getClass().getAnnotation(Resource.class);
294-
SubResource subResourceAnnotation = resource.getClass().getAnnotation(SubResource.class);
293+
Resource annotation = resourceHandler.getClass().getAnnotation(Resource.class);
294+
SubResource subResourceAnnotation = resourceHandler.getClass().getAnnotation(SubResource.class);
295295

296296
if (annotation != null && annotation.supportedClass().equals(supportedClass)) {
297297
return annotation.name().substring(annotation.name().indexOf('/') + 1);

0 commit comments

Comments
 (0)