(test) Suppress store override warnings and upgrade testing-library (#1487)

Author: denniskigen

packages/apps/esm-implementer-tools-app/jest.config.js

@@ -11,6 +11,7 @@ module.exports = {
     '^lodash-es$': 'lodash',
     '^lodash-es/(.*)$': 'lodash/$1',
     '\\.(s?css)$': 'identity-obj-proxy',
+    '@openmrs/esm-framework/src/internal': '@openmrs/esm-framework/mock',
     '@openmrs/esm-framework': '@openmrs/esm-framework/mock',
     dexie: require.resolve('dexie'),
   },

packages/framework/esm-config/src/setup-tests.js

@@ -1,10 +1,12 @@
 /* eslint-disable no-undef */
+import { vi } from 'vitest';
+
 global.window.System = {
-  import: jest.fn().mockRejectedValue(new Error('config.json not available in import map')),
-  resolve: jest.fn().mockImplementation(() => {
+  import: vi.fn().mockRejectedValue(new Error('config.json not available in import map')),
+  resolve: vi.fn().mockImplementation(() => {
     throw new Error('config.json not available in import map');
   }),
-  register: jest.fn(),
+  register: vi.fn(),
 };
 
 global.window.openmrsBase = '/openmrs';

packages/framework/esm-framework/docs/functions/createGlobalStore.md

@@ -4,7 +4,7 @@
 
 > **createGlobalStore**\<`T`\>(`name`, `initialState`): `StoreApi`\<`T`\>
 
-Defined in: [packages/framework/esm-state/src/state.ts:30](https://github.com/openmrs/openmrs-esm-core/blob/main/packages/framework/esm-state/src/state.ts#L30)
+Defined in: [packages/framework/esm-state/src/state.ts:43](https://github.com/openmrs/openmrs-esm-core/blob/main/packages/framework/esm-state/src/state.ts#L43)
 
 Creates a Zustand store.
 

packages/framework/esm-framework/docs/functions/getGlobalStore.md

@@ -4,7 +4,7 @@
 
 > **getGlobalStore**\<`T`\>(`name`, `fallbackState?`): `StoreApi`\<`T`\>
 
-Defined in: [packages/framework/esm-state/src/state.ts:92](https://github.com/openmrs/openmrs-esm-core/blob/main/packages/framework/esm-state/src/state.ts#L92)
+Defined in: [packages/framework/esm-state/src/state.ts:109](https://github.com/openmrs/openmrs-esm-core/blob/main/packages/framework/esm-state/src/state.ts#L109)
 
 Returns the existing store named `name`,
 or creates a new store named `name` if none exists.

packages/framework/esm-framework/docs/functions/subscribeTo.md

@@ -6,7 +6,7 @@
 
 > **subscribeTo**\<`T`, `U`\>(`store`, `handle`): () => `void`
 
-Defined in: [packages/framework/esm-state/src/state.ts:109](https://github.com/openmrs/openmrs-esm-core/blob/main/packages/framework/esm-state/src/state.ts#L109)
+Defined in: [packages/framework/esm-state/src/state.ts:126](https://github.com/openmrs/openmrs-esm-core/blob/main/packages/framework/esm-state/src/state.ts#L126)
 
 ### Type Parameters
 
@@ -40,7 +40,7 @@ Defined in: [packages/framework/esm-state/src/state.ts:109](https://github.com/o
 
 > **subscribeTo**\<`T`, `U`\>(`store`, `select`, `handle`): () => `void`
 
-Defined in: [packages/framework/esm-state/src/state.ts:110](https://github.com/openmrs/openmrs-esm-core/blob/main/packages/framework/esm-state/src/state.ts#L110)
+Defined in: [packages/framework/esm-state/src/state.ts:127](https://github.com/openmrs/openmrs-esm-core/blob/main/packages/framework/esm-state/src/state.ts#L127)
 
 ### Type Parameters
 

packages/framework/esm-framework/setup-tests.ts

@@ -1,7 +1,13 @@
-import { afterEach } from 'vitest';
-import type {} from '@openmrs/esm-globals';
 import '@testing-library/jest-dom/vitest';
 import { cleanup } from '@testing-library/react';
+import { afterEach } from 'vitest';
+import type {} from '@openmrs/esm-globals';
+
+declare global {
+  interface Window {
+    IS_REACT_ACT_ENVIRONMENT?: boolean;
+  }
+}
 
 // Configure React's act() environment for Vitest
 // See: https://github.com/testing-library/react-testing-library/issues/1061

packages/framework/esm-navigation/src/setup-tests.js

@@ -1,3 +1,6 @@
-window.openmrsBase = '/openmrs';
-window.spaBase = '/spa';
-window.getOpenmrsSpaBase = () => '/openmrs/spa/';
+/* eslint-env node */
+import { vi } from 'vitest';
+
+global.window.openmrsBase = '/openmrs';
+global.window.spaBase = '/spa';
+global.window.getOpenmrsSpaBase = () => '/openmrs/spa/';

packages/framework/esm-state/src/state.ts

@@ -11,10 +11,23 @@ interface StoreEntity {
 
 const availableStores: Record<string, StoreEntity> = {};
 
+// Check if we're in a test environment (Vitest or Jest)
+const isTestEnvironment = () => {
+  try {
+    return (
+      process.env.NODE_ENV === 'test' ||
+      (typeof process !== 'undefined' && (process.env.VITEST === 'true' || process.env.JEST_WORKER_ID !== undefined)) ||
+      (typeof globalThis !== 'undefined' && ('__vitest_worker__' in globalThis || '__jest__' in globalThis))
+    );
+  } catch {
+    return false;
+  }
+};
+
 // spaEnv isn't available immediately. Wait a bit before making stores available
 // on window in development mode.
 setTimeout(() => {
-  if (window && window.spaEnv === 'development') {
+  if (typeof window !== 'undefined' && window.spaEnv === 'development') {
     window['stores'] = availableStores;
   }
 }, 1000);
@@ -32,7 +45,9 @@ export function createGlobalStore<T>(name: string, initialState: T): StoreApi<T>
 
   if (available) {
     if (available.active) {
-      console.error(`Attempted to override the existing store ${name}. Make sure that stores are only created once.`);
+      if (!isTestEnvironment()) {
+        console.error(`Attempted to override the existing store ${name}. Make sure that stores are only created once.`);
+      }
     } else {
       available.value.setState(initialState, true);
     }
@@ -64,7 +79,9 @@ export function registerGlobalStore<T>(name: string, store: StoreApi<T>): StoreA
 
   if (available) {
     if (available.active) {
-      console.error(`Attempted to override the existing store ${name}. Make sure that stores are only created once.`);
+      if (!isTestEnvironment()) {
+        console.error(`Attempted to override the existing store ${name}. Make sure that stores are only created once.`);
+      }
     } else {
       available.value = store;
     }