AC-821 Fix Java and Kotlin deprecation warnings #938

Anshul-9923 · 2022-01-31T06:16:36Z

Description of what I changed

In Travis-ci while building this project many Java and Kotlin deprecation warnings were arising so to fix all those warnings, I have made changes in 4 files.

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-821

Checklist: I completed these to help reviewers :)

My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).

I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)

All new and existing tests passed.

My pull request is based on the latest changes of the master branch.

Anshul-9923 · 2022-01-31T06:18:32Z

@LuGO0 Please review my code and merge PR, if any changes are required let me know.

dino-saurabh · 2022-01-31T19:25:34Z

@Anshul-9923 few warnings are still left just supress them if you think they are not critical

Anshul-9923 · 2022-01-31T19:57:12Z

@LuGO0 Should I also have to fix deprecated build features and can you please tell me which other files are needed to be changed to fix the remaining warnings?
I am not able to get which other files needed to be changed seeing the Travis-ci build.

dino-saurabh · 2022-02-01T20:09:32Z

Oh okay @Anshul-9923 I will look into it if I can find something.

dino-saurabh · 2022-02-02T17:51:07Z

public abstract class AppDatabase extends RoomDatabase {
                ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 warning

I think this is the one which is not related to build warnings is it? ^

w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\activities\dashboard\DashboardFragment.kt: (116, 13): Condition 'root != null' is always 'true'
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\activities\formadmission\FormAdmissionPresenter.kt: (142, 21): Unreachable code
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\activities\formlist\FormListFragment.kt: (57, 51): Parameter 'parent' is never used, could be renamed to _
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\activities\formlist\FormListFragment.kt: (57, 103): Parameter 'id' is never used, could be renamed to _
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\activities\formlist\FormListFragment.kt: (72, 48): Parameter 'v' is never used, could be renamed to _
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\activities\formlist\FormListFragment.kt: (168, 29): Variable 'json' initializer is redundant
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\activities\formlist\FormListFragment.kt: (180, 32): Variable 'obj' initializer is redundant
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\activities\logs\LogsFragment.kt: (51, 30): Parameter 'context' is never used
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\listeners\watcher\PatientBirthdateValidatorWatcher.kt: (39, 13): Unreachable code
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\listeners\watcher\PatientBirthdateValidatorWatcher.kt: (40, 13): Unreachable code
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\listeners\watcher\PatientBirthdateValidatorWatcher.kt: (45, 17): Unreachable code
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\listeners\watcher\PatientBirthdateValidatorWatcher.kt: (46, 17): Unreachable code
w: C:\projects\openmrs-contrib-android-client\openmrs-client\src\main\java\org\openmrs\mobile\utilities\NotificationUtil.kt: (30, 43): 'constructor Builder(Context!)' is deprecated. Deprecated in Java

I came across these warnings as well in the CI build logs can you fix them with this PR only?

openmrs-android-sdk/src/main/java/com/openmrs/android_sdk/utilities/NetworkUtils.kt

…ng from NetworkUtils.kt

Anshul-9923 · 2022-02-03T15:13:02Z

@LuGO0 I have fixed the remaining deprecated warnings. Please review my code.

Anshul-9923 · 2022-02-05T14:56:21Z

@LuGO0 I did changes as told by you. PTAL

dino-saurabh · 2022-02-05T16:09:44Z

Please check the build is failing

Anshul-9923 · 2022-02-05T16:15:35Z

Please check the build is failing

@LuGO0 It is because of changing compileSdkVersion and targetSdkVersion to 30.

dino-saurabh · 2022-02-06T19:31:44Z

Please check the build is failing

@LuGO0 It is because of changing compileSdkVersion and targetSdkVersion to 30.

So

Please check the build is failing

@LuGO0 It is because of changing compileSdkVersion and targetSdkVersion to 30.

I think we dont need this change . We can simply have a build version check and have 2 different implementations for network Utils.
Suppress the older implementation using a method level supress annotation, does it help?

Anshul-9923 · 2022-02-08T15:44:16Z

Please check the build is failing

@LuGO0 It is because of changing compileSdkVersion and targetSdkVersion to 30.

So

Please check the build is failing

@LuGO0 It is because of changing compileSdkVersion and targetSdkVersion to 30.

I think we dont need this change . We can simply have a build version check and have 2 different implementations for network Utils. Suppress the older implementation using a method level supress annotation, does it help?

@LuGO0 So, Should I change library from android.preference.PreferenceManager to androidx.preference.PreferenceManager as it is deprecated warning.

openmrs-android-sdk/src/main/java/com/openmrs/android_sdk/utilities/NetworkUtils.kt

openmrs-client/src/main/java/org/openmrs/mobile/activities/dashboard/DashboardFragment.kt

dino-saurabh · 2022-02-08T16:00:32Z

I think we dont need this change . We can simply have a build version check and have 2 different implementations for network Utils. Suppress the older implementation using a method level supress annotation, does it help?

@LuGO0 So, Should I change library from android.preference.PreferenceManager to androidx.preference.PreferenceManager as it is deprecated warning.

Yes, just add a supress annotation locally if the build is failing and you are unable to fix it.

Anshul-9923 · 2022-02-08T16:16:27Z

I think we dont need this change . We can simply have a build version check and have 2 different implementations for network Utils. Suppress the older implementation using a method level supress annotation, does it help?

@LuGO0 So, Should I change library from android.preference.PreferenceManager to androidx.preference.PreferenceManager as it is deprecated warning.

Yes, just add a supress annotation locally if the build is failing and you are unable to fix it.

@LuGO0 After importing it build fails and asks for changing minCompileSdk to 31.

openmrs-android-sdk/build.gradle

Anshul-9923 · 2022-02-10T16:48:00Z

@LuGO0 Done with the changes as told by you.

dino-saurabh · 2022-02-10T16:51:54Z

openmrs-android-sdk/src/main/java/com/openmrs/android_sdk/utilities/NetworkUtils.kt

-        val prefs = PreferenceManager.getDefaultSharedPreferences(OpenmrsAndroid.getInstance())
-        val toggle = prefs.getBoolean("sync", true)
-        return if (toggle) {
+        val prefs = OpenmrsAndroid.getInstance()?.let { android.preference.PreferenceManager.getDefaultSharedPreferences(it) }


there should be no change here right? after you reverted your changes?

Yes, reverted the changes

openmrs-android-sdk/src/main/java/com/openmrs/android_sdk/utilities/NetworkUtils.kt

Anshul-9923 · 2022-02-10T18:29:27Z

@LuGO0 I have reverted the changes wherever told by you. PTAL

dino-saurabh · 2022-02-11T18:47:14Z

Few warnings are still there but we can merge this will try running the application locally then merge this PR Thanks!

Anshul-9923 · 2022-02-12T04:41:43Z

Few warnings are still there but we can merge this will try running the application locally then merge this PR Thanks!

Ok @LuGO0

Anshul-9923 · 2022-02-16T07:32:07Z

@LuGO0 You have not merged my PR, do I need to do any changes?

dino-saurabh · 2022-02-16T09:53:56Z

Will run it locally then merge it.

dino-saurabh · 2022-02-19T17:50:53Z

@shubhamsgit need some help verifying this PR locally, and let me know if it works fine? Thanks!

Anshul-9923 · 2022-03-01T04:30:12Z

@LuGO0 When will the idealist release for GSoC projects by openmrs?

dino-saurabh · 2022-03-01T18:01:01Z

@LuGO0 When will the idealist release for GSoC projects by openmrs?

Not sure @Anshul-9923, you can find it on OpenMRS Talk or ask the GSOC co-ordinators like Jennifer and Moses !
Also sorry for the delay in this PR's review haven't got a chance to run it locally once !

Anshul-9923 · 2022-03-01T18:37:24Z

@LuGO0 When will the idealist release for GSoC projects by openmrs?

Not sure @Anshul-9923, you can find it on OpenMRS Talk or ask the GSOC co-ordinators like Jennifer and Moses ! Also sorry for the delay in this PR's review haven't got a chance to run it locally once !

Thanks @LuGO0

shubhamsgit · 2022-03-01T18:45:29Z

openmrs-client/src/main/java/org/openmrs/mobile/activities/dashboard/DashboardFragment.kt

-    /**
-     * Starts new Activity depending on which ImageView triggered it
-     */
-    private fun startNewActivity(clazz: Class<out ACBaseActivity?>) {


@Anshul-9923 As I can see, this PR is about fixing Java & Kotlin deprecation warnings but I see some deletions for the redundant code (which is not wrong). @LuGO0 Shouldn't a separate PR be opened for removing redundant code?

or better remove all the redundant code under this PR only? @LuGO0

dino-saurabh · 2022-03-01T19:11:54Z

Please dont delete any unreachable code since these are probably part of some unfinished module. I would be happy to keep them as they are for now with a warning supression.

shubhamsgit

PR title is misleading. PR fixes only two deprecations i.e., Preference Manager & Recycler View. Remaining part of the PR just removes redundant code. @Anshul-9923 Either you should remove all of the project's redundant code in this PR and rename it or if @LuGO0 suggests open a new PR.

shubhamsgit · 2022-03-01T19:00:40Z

...s-client/src/main/java/org/openmrs/mobile/activities/formadmission/FormAdmissionPresenter.kt

 import org.openmrs.mobile.application.OpenMRS
 import com.openmrs.android_sdk.library.listeners.retrofitcallbacks.DefaultResponseCallback

+@Suppress("UNREACHABLE_CODE")


No need to suppress this warning. It can be resolved.

shubhamsgit · 2022-03-01T19:05:59Z

...lient/src/main/java/org/openmrs/mobile/listeners/watcher/PatientBirthdateValidatorWatcher.kt

 import com.openmrs.android_sdk.utilities.ApplicationConstants
 import com.openmrs.android_sdk.utilities.StringUtils.notEmpty

+@Suppress("UNREACHABLE_CODE")


Remove this too. Can be resolved.

shubhamsgit · 2022-03-01T19:13:58Z

Please dont delete any unreachable code since these are probably part of some unfinished module. I would be happy to keep them as they are for now with a warning supression.

No need to delete @LuGO0 The unreachable code's position just has to be changed

shubhamsgit · 2022-03-01T19:15:07Z

Please dont delete any unreachable code since these are probably part of some unfinished module. I would be happy to keep them as they are for now with a warning supression.

You mean 'redundant code' or 'unreachable code'?

dino-saurabh · 2022-03-01T19:21:58Z

Unreachable code, like the formAdmissionPresenter portion.

shubhamsgit · 2022-03-01T19:25:59Z

Unreachable code, like the formAdmissionPresenter portion.

I think that code can be removed as program control never reaches view.enableSubmitButton(true) because error(errorMessage) throws IllegalStateException and program terminates.

shubhamsgit · 2022-03-01T19:31:25Z

and in PatientBirthdateValidatorWatcher, edmonth.text.clear() and edyr.text.clear() these two lines should be moved before the error() function. This can be counted as a bug though. Can open a new PR if you want.

dino-saurabh · 2022-03-02T16:12:00Z

Yupp create new PRs if needed with each one for a specific use case, don't do it in this one!

FaheemorFAB · 2025-01-01T14:52:41Z

I request the maintainer to clarify the exact work that you are looking for.

Fixed deprecation warnings

26df304

Anshul-9923 changed the title ~~AC-821 Fix deprecation warnings~~ AC-821 Fix Java and Kotlin deprecation warnings Jan 31, 2022

Merge branch 'openmrs:master' into AC-821

b9bb900

dino-saurabh reviewed Feb 2, 2022

View reviewed changes

openmrs-android-sdk/src/main/java/com/openmrs/android_sdk/utilities/NetworkUtils.kt Outdated Show resolved Hide resolved

Fixed the remaining deprecated warnings and removed suppression warni…

525c0e0

…ng from NetworkUtils.kt

dino-saurabh reviewed Feb 8, 2022

View reviewed changes

openmrs-android-sdk/src/main/java/com/openmrs/android_sdk/utilities/NetworkUtils.kt Outdated Show resolved Hide resolved

dino-saurabh reviewed Feb 8, 2022

View reviewed changes

openmrs-android-sdk/src/main/java/com/openmrs/android_sdk/utilities/NetworkUtils.kt Outdated Show resolved Hide resolved

dino-saurabh reviewed Feb 8, 2022

View reviewed changes

openmrs-client/src/main/java/org/openmrs/mobile/activities/dashboard/DashboardFragment.kt Show resolved Hide resolved

dino-saurabh reviewed Feb 10, 2022

View reviewed changes

openmrs-android-sdk/build.gradle Outdated Show resolved Hide resolved

dino-saurabh reviewed Feb 10, 2022

View reviewed changes

openmrs-android-sdk/build.gradle Outdated Show resolved Hide resolved

Fixed warnings of NetworkUtils.kt

e062a95

dino-saurabh reviewed Feb 10, 2022

View reviewed changes

Revert back the changes

47fbca6

shubhamsgit reviewed Mar 1, 2022

View reviewed changes

shubhamsgit requested changes Mar 1, 2022

View reviewed changes

shubhamsgit added Changes Required Stale Inactivity for 60 days labels Jun 1, 2023

AC-821 Fix Java and Kotlin deprecation warnings #938

Are you sure you want to change the base?

AC-821 Fix Java and Kotlin deprecation warnings #938

Uh oh!

Conversation

Anshul-9923 commented Jan 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of what I changed

Issue I worked on

Checklist: I completed these to help reviewers :)

Uh oh!

Anshul-9923 commented Jan 31, 2022

Uh oh!

dino-saurabh commented Jan 31, 2022

Uh oh!

Anshul-9923 commented Jan 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dino-saurabh commented Feb 1, 2022

Uh oh!

dino-saurabh commented Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Anshul-9923 commented Feb 3, 2022

Uh oh!

Anshul-9923 commented Feb 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dino-saurabh commented Feb 5, 2022

Uh oh!

Anshul-9923 commented Feb 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dino-saurabh commented Feb 6, 2022

Uh oh!

Anshul-9923 commented Feb 8, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dino-saurabh commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anshul-9923 commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Anshul-9923 commented Feb 10, 2022

Uh oh!

dino-saurabh Feb 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Anshul-9923 Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Anshul-9923 commented Feb 10, 2022

Uh oh!

dino-saurabh commented Feb 11, 2022

Uh oh!

Anshul-9923 commented Feb 12, 2022

Uh oh!

Anshul-9923 commented Feb 16, 2022

Uh oh!

dino-saurabh commented Feb 16, 2022

Uh oh!

dino-saurabh commented Feb 19, 2022

Uh oh!

Anshul-9923 commented Mar 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dino-saurabh commented Mar 1, 2022

Uh oh!

Anshul-9923 commented Mar 1, 2022

Uh oh!

shubhamsgit Mar 1, 2022

Choose a reason for hiding this comment

Anshul-9923 commented Jan 31, 2022 •

edited

Loading

Anshul-9923 commented Jan 31, 2022 •

edited

Loading

dino-saurabh commented Feb 2, 2022 •

edited

Loading

Anshul-9923 commented Feb 5, 2022 •

edited

Loading

Anshul-9923 commented Feb 5, 2022 •

edited

Loading

dino-saurabh commented Feb 8, 2022 •

edited

Loading

Anshul-9923 commented Feb 8, 2022 •

edited

Loading

dino-saurabh Feb 10, 2022 •

edited

Loading

Anshul-9923 commented Mar 1, 2022 •

edited

Loading

shubhamsgit commented Mar 1, 2022 •

edited

Loading