-
Notifications
You must be signed in to change notification settings - Fork 147
8335922: Incorrect @Stable usage of LambdaForm$Name.index #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8335922: Incorrect @stable usage of LambdaForm$Name.index. This commit converts index field to final and updates all usages accordingly. The @stable annotation on the index field is incorrect since it only prevents inlining zero values. Ran the related tests: (Passed) - make test TEST=test/jdk/java/lang/invoke Results are attached. |
Backporting JDK-8335922: Incorrect @stable usage of LambdaForm$Name.index.
Updated all code that uses the
indexfield to work with the new final modifier.Ran GHA Sanity Checks (passed) and related tests (passed).
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2486/head:pull/2486$ git checkout pull/2486Update a local copy of the PR:
$ git checkout pull/2486$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2486/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2486View PR using the GUI difftool:
$ git pr show -t 2486Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2486.diff
Using Webrev
Link to Webrev Comment