chore(build): Update ndm dockerfiles to use ndm build base image (#655)

- update ndm dockerfiles to use ndm build base image
- update seachest cgo build CFLAGS
- remove redundant dependencies from ndm dockerfiles. The ndm build base image is shipped with the packages make and git.

Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>

Author: z0marlin

Makefile.buildx.mk

@@ -61,8 +61,13 @@ docker.buildx:
 	@echo "--> Build docker image: $(DOCKERX_IMAGE_NAME)"
 	@echo
 
+# Install dependencies if NODEPINSTALL arg not passed during invocation
+ifndef NODEPINSTALL
+buildx.ndm buildx.ndo buildx.exporter: install-dep-nonsudo
+endif
+
 .PHONY: buildx.ndm
-buildx.ndm: bootstrap install-dep-nonsudo clean build.common
+buildx.ndm: bootstrap clean build.common
 	@echo '--> Building node-disk-manager binary...'
 	@pwd
 	@CTLNAME=${NODE_DISK_MANAGER} BUILDPATH=${BUILD_PATH_NDM} BUILDX=true sh -c "'$(PWD)/build/build.sh'"
@@ -75,7 +80,7 @@ docker.buildx.ndm: COMPONENT=ndm-daemonset
 docker.buildx.ndm: docker.buildx
 
 .PHONY: buildx.ndo
-buildx.ndo: bootstrap install-dep-nonsudo clean build.common
+buildx.ndo: bootstrap clean build.common
 	@echo '--> Building node-disk-operator binary...'
 	@pwd
 	@CTLNAME=${NODE_DISK_OPERATOR} BUILDPATH=${BUILD_PATH_NDO} BUILDX=true sh -c "'$(PWD)/build/build.sh'"
@@ -88,7 +93,7 @@ docker.buildx.ndo: COMPONENT=ndm-operator
 docker.buildx.ndo: docker.buildx
 
 .PHONY: buildx.exporter
-buildx.exporter: bootstrap install-dep-nonsudo clean build.common
+buildx.exporter: bootstrap clean build.common
 	@echo '--> Building node-disk-exporter binary...'
 	@pwd
 	@CTLNAME=${NODE_DISK_EXPORTER} BUILDPATH=${BUILD_PATH_EXPORTER} BUILDX=true sh -c "'$(PWD)/build/build.sh'"

build/ndm-daemonset/Dockerfile

@@ -14,7 +14,7 @@
 #
 # This Dockerfile builds node-disk-manager daemon
 #
-FROM golang:1.14.7 as build
+FROM ghcr.io/openebs/ndm-build-base:20211202 as build
 
 ARG TARGETOS
 ARG TARGETARCH
@@ -31,12 +31,9 @@ ENV GO111MODULE=on \
   RELEASE_TAG=${RELEASE_TAG}
 
 WORKDIR /go/src/github.com/openebs/node-disk-manager/
-
-RUN apt-get update && apt-get install -y make git
-
 COPY . .
 
-RUN make buildx.ndm
+RUN make NODEPINSTALL=true buildx.ndm
 
 FROM ubuntu
 

build/ndm-exporter/Dockerfile

@@ -14,7 +14,7 @@
 #
 # This Dockerfile builds ndm exporter
 #
-FROM golang:1.14.7 as build
+FROM ghcr.io/openebs/ndm-build-base:20211202 as build
 
 ARG TARGETOS
 ARG TARGETARCH
@@ -31,12 +31,9 @@ ENV GO111MODULE=on \
   RELEASE_TAG=${RELEASE_TAG}
 
 WORKDIR /go/src/github.com/openebs/node-disk-manager/
-
-RUN apt-get update && apt-get install -y make git
-
 COPY . .
 
-RUN make buildx.exporter
+RUN make NODEPINSTALL=true buildx.exporter
 
 FROM ubuntu
 

build/ndm-operator/Dockerfile

@@ -14,7 +14,7 @@
 #
 # This Dockerfile builds ndm operator
 #
-FROM golang:1.14.7 as build
+FROM ghcr.io/openebs/ndm-build-base:20211202 as build
 
 ARG TARGETOS
 ARG TARGETARCH
@@ -31,12 +31,9 @@ ENV GO111MODULE=on \
   RELEASE_TAG=${RELEASE_TAG}
 
 WORKDIR /go/src/github.com/openebs/node-disk-manager/
-
-RUN apt-get update && apt-get install -y make git
-
 COPY . .
 
-RUN make buildx.ndo
+RUN make NODEPINSTALL=true buildx.ndo
 
 FROM ubuntu
 

pkg/seachest/seachest.go

@@ -17,6 +17,7 @@ package seachest
 
 /*
 #cgo LDFLAGS: -lopensea-operations -lopensea-transport -lopensea-common -lm
+#cgo CFLAGS: -I/usr/local/include/openSeaChest -I/usr/local/include/openSeaChest/opensea-common -I/usr/local/include/openSeaChest/opensea-operations -I/usr/local/include/openSeaChest/opensea-transport
 #cgo CFLAGS: -I../../../openSeaChest/include -I../../../openSeaChest/opensea-common/include -I../../../openSeaChest/opensea-operations/include -I../../../openSeaChest/opensea-transport/include
 #include "common.h"
 #include "openseachest_util_options.h"