From aaf187013541729da0ef2b0309518c934880bf61 Mon Sep 17 00:00:00 2001 From: emdneto <9735060+emdneto@users.noreply.github.com> Date: Wed, 6 Nov 2024 16:01:11 -0300 Subject: [PATCH 1/2] fix workflows Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> --- .github/workflows/check-links.yml | 3 +-- .github/workflows/lint_0.yml | 2 +- .github/workflows/misc_0.yml | 4 +++- CHANGELOG.md | 3 +++ tox.ini | 1 + 5 files changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check-links.yml b/.github/workflows/check-links.yml index 770bd241687..9092cbaf789 100644 --- a/.github/workflows/check-links.yml +++ b/.github/workflows/check-links.yml @@ -23,7 +23,6 @@ jobs: check-links: runs-on: ubuntu-latest needs: changedfiles - if: if: | github.event.pull_request.user.login != 'opentelemetrybot' && github.event_name == 'pull_request' && ${{needs.changedfiles.outputs.md}} @@ -34,7 +33,7 @@ jobs: fetch-depth: 0 - name: Install markdown-link-check - run: npm install -g markdown-link-check + run: npm install -g markdown-link-check@v3.12.2 - name: Run markdown-link-check run: | diff --git a/.github/workflows/lint_0.yml b/.github/workflows/lint_0.yml index cd3cd7bda19..71b148c02d5 100644 --- a/.github/workflows/lint_0.yml +++ b/.github/workflows/lint_0.yml @@ -11,7 +11,7 @@ on: env: CORE_REPO_SHA: main - CONTRIB_REPO_SHA: be0c78c8c11d05787edb53104c92a3a959f6a70c + CONTRIB_REPO_SHA: main PIP_EXISTS_ACTION: w jobs: diff --git a/.github/workflows/misc_0.yml b/.github/workflows/misc_0.yml index 3e8aa7cf1b4..e816656b8d0 100644 --- a/.github/workflows/misc_0.yml +++ b/.github/workflows/misc_0.yml @@ -11,7 +11,7 @@ on: env: CORE_REPO_SHA: main - CONTRIB_REPO_SHA: be0c78c8c11d05787edb53104c92a3a959f6a70c + CONTRIB_REPO_SHA: main PIP_EXISTS_ACTION: w jobs: @@ -109,6 +109,8 @@ jobs: docs: name: docs runs-on: ubuntu-latest + if: | + github.event.pull_request.user.login != 'opentelemetrybot' && github.event_name == 'pull_request' steps: - name: Checkout repo @ SHA - ${{ github.sha }} uses: actions/checkout@v4 diff --git a/CHANGELOG.md b/CHANGELOG.md index e7f7bc69004..831dd578e52 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +- Test check-links + ([#4172](https://github.com/open-telemetry/opentelemetry-python/pull/4172)) + ## Version 1.28.0/0.49b0 (2024-11-05) - Removed superfluous py.typed markers and added them where they were missing diff --git a/tox.ini b/tox.ini index 49e2fc7710b..3e92195f9d9 100644 --- a/tox.ini +++ b/tox.ini @@ -334,6 +334,7 @@ commands = python {toxinidir}/scripts/public_symbols_checker.py [testenv:generate-workflows] +recreate = True deps = {env:CONTRIB_REPO}\#egg=generate_workflows_lib&subdirectory=.github/workflows/generate_workflows_lib commands = From 3e7f3ee4d7413142565ad04f65b620005443cc14 Mon Sep 17 00:00:00 2001 From: emdneto <9735060+emdneto@users.noreply.github.com> Date: Wed, 6 Nov 2024 17:42:30 -0300 Subject: [PATCH 2/2] remove changelog line since it's working Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> --- CHANGELOG.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 831dd578e52..e7f7bc69004 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,9 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased -- Test check-links - ([#4172](https://github.com/open-telemetry/opentelemetry-python/pull/4172)) - ## Version 1.28.0/0.49b0 (2024-11-05) - Removed superfluous py.typed markers and added them where they were missing