Fix the type hint of _metrics_data within InMemoryMetricReader

phillipuniverse · phillipuniverse · commit 5b9feb9b9d03 · 2025-12-03T09:55:55.000-06:00
This gets initialized to None, so the type hint should be MetricsData | None
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py
@@ -406,7 +406,7 @@ def __init__(
             preferred_aggregation=preferred_aggregation,
         )
         self._lock = RLock()
-        self._metrics_data: MetricsData = None
+        self._metrics_data: MetricsData | None = None
 
     def get_metrics_data(
         self,

Original file line number	Diff line number	Diff line change
`@@ -406,7 +406,7 @@ def __init__(`
`406`	`406`	`preferred_aggregation=preferred_aggregation,`
`407`	`407`	`)`
`408`	`408`	`self._lock = RLock()`
`409`		`- self._metrics_data: MetricsData = None`
	`409`	`+ self._metrics_data: MetricsData \| None = None`
`410`	`410`
`411`	`411`	`def get_metrics_data(`
`412`	`412`	`self,`