Skip to content

feature: hydrate AsyncPG span attributes at creation (#3643) #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
forafox wants to merge 9 commits into
base: main
Choose a base branch
from
+124 −20
Open

feature: hydrate AsyncPG span attributes at creation (#3643) #3841

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
881bc76
feature: hydrate AsyncPG span attributes at creation (#3643)
forafox Oct 13, 2025
6434e0f
Merge branch 'main' into feature/asyncpg-attribute-hydration
xrmx Nov 28, 2025
6cadc66
opentelemetry-instrumentation-asyncpg: ensure sampler sees span attri…
forafox Dec 7, 2025
e8d192e
Merge branch 'main' into feature/asyncpg-attribute-hydration
forafox Dec 7, 2025
e99879c
tests: fix import order in asyncpg docker tests
forafox Dec 9, 2025
a6670d7
Merge branch 'main' into feature/asyncpg-attribute-hydration
forafox Dec 9, 2025
32136cf
tests: expect net.transport in asyncpg sampler attributes
forafox Dec 9, 2025
2fc1b82
tests: use sdk tracer in asyncpg sampling checks
forafox Dec 9, 2025
8d8eee3
changelog: move asyncpg fix to Unreleased
forafox Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions ...entelemetry-instrumentation-asyncpg/src/opentelemetry/instrumentation/asyncpg/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,18 +178,16 @@ async def _do_execute(self, func, instance, args, kwargs):
except IndexError:
name = ""

# Hydrate attributes before span creation to enable filtering
span_attributes = _hydrate_span_from_args(
instance,
args[0],
args[1:] if self.capture_parameters else None,
)

with self._tracer.start_as_current_span(
name, kind=SpanKind.CLIENT
name, kind=SpanKind.CLIENT, attributes=span_attributes
) as span:
if span.is_recording():
span_attributes = _hydrate_span_from_args(
instance,
args[0],
args[1:] if self.capture_parameters else None,
)
for attribute, value in span_attributes.items():
span.set_attribute(attribute, value)

try:
result = await func(*args, **kwargs)
except Exception as exc: # pylint: disable=W0703
Expand Down Expand Up @@ -217,20 +215,19 @@ async def _do_cursor_execute(self, func, instance, args, kwargs):
except IndexError:
name = ""

# Hydrate attributes before span creation to enable filtering
span_attributes = _hydrate_span_from_args(
instance._connection,
instance._query,
instance._args if self.capture_parameters else None,
)

stop = False
with self._tracer.start_as_current_span(
f"CURSOR: {name}",
kind=SpanKind.CLIENT,
attributes=span_attributes,
) as span:
if span.is_recording():
span_attributes = _hydrate_span_from_args(
instance._connection,
instance._query,
instance._args if self.capture_parameters else None,
)
for attribute, value in span_attributes.items():
span.set_attribute(attribute, value)

try:
result = await func(*args, **kwargs)
except StopAsyncIteration:
Expand Down