Pint works differently on save and when manually calling format

[CicerBro]

I was testing formatting by adding a tab in front of a variable. When I save the file, the tab gets removed (which is good) but when I run Format Document (this calls Pint) it doesn't remove the tab.

I know it calls pint when doing calling Format Document because I can see it on the console: ["INFO" - 14:58:53] Formatting completed in 388ms.

When I do "Format Document With" then Pint is listed as the default.

Any ideas?

.vscode/settings.json:

{
    "laravel-pint.enable": true,
    "editor.formatOnSave": true,
    "[php]": {
        "editor.defaultFormatter": "open-southeners.laravel-pint"
    }
}

pint.json

{
    "preset": "laravel",
    "rules": {
        "array_indentation": true,
        "blank_line_after_namespace": true,
        "blank_line_after_opening_tag": true,
        "combine_consecutive_issets": true,
        "combine_consecutive_unsets": true,
        "concat_space": {
            "spacing": "one"
        },
        "is_null": true,
        "logical_operators": true,
        "mb_str_functions": true,
        "method_chaining_indentation": true,
        "modernize_strpos": true,
        "no_empty_comment": true,
        "ternary_to_null_coalescing": true,
        "trim_array_spaces": true,
        "array_push": true,
        "assign_null_coalescing_to_coalesce_equal": true,
        "method_argument_space": {
            "on_multiline": "ensure_fully_multiline"
        },
        "modernize_types_casting": true,
        "no_superfluous_elseif": true,
        "no_useless_else": true,
        "ordered_imports": {
            "sort_algorithm": "alpha"
        },
        "ordered_class_elements": {
            "order": [
                "use_trait",
                "case",
                "constant",
                "constant_public",
                "constant_protected",
                "constant_private",
                "property_public",
                "property_protected",
                "property_private",
                "construct",
                "destruct",
                "magic",
                "phpunit",
                "method_abstract",
                "method_public_static",
                "method_public",
                "method_protected_static",
                "method_protected",
                "method_private_static",
                "method_private"
            ],
            "sort_algorithm": "none"
        }
    }
}

[kev1ncal]

I thought I was the only one experiencing a bug on this extension. For me, the extensions just doesn't work anymore. Format Document using... option on VSCode does fix the file I'm currently in.

[ellisio]

This extension works, it is just missing some documentation about editor.formatOnSaveMode. Add the following to your <workspaceRoot>/.vscode/settings.json:

  "[php]": {
    "editor.formatOnSave": true,
    "editor.formatOnSaveMode": "file",
    "editor.defaultFormatter": "open-southeners.laravel-pint",
  },

[CicerBro]

Hi @ellisio, that sadly does not fix the issue. Format on Save works and always worked. But when I try to format a file without saving it by pulling up Format Document from the command palette, nothing happens to the file.

Pint Output:

["INFO" - 20:19:43] Formatting completed in 199ms.
["INFO" - 20:19:48] Formatting completed in 137ms.

The first one I did the Format Document command, Pint ran but did nothing to the file. The second line was when I saved the file, Pint ran and actually formatted the file.

[ellisio]

An unsaved file will never work with this extension. Pint requires a <path> argument (see: vendor/bin/pint --help). An unsaved file is in-memory, and not a physical path. Pint would need upstream changes to support the following:

vendor/bin/pint -o path/to/file.php < <<<EOM
<?php
// ... your file
EOM

Edit: I guess this could be refactored to take your current state of unsaved changes, write to a temp file, and then replace with the output. But that may be outside of the scope of what the maintainers want to support.

[CicerBro]

Ah right. PHP-CS-Fixer can do this with the Junstyle plugin, I figured since Pint is based on it, it would work the same.

[d8vjork]

As @ellisio said, this would be out of the scope, as long as it doesn't come as a PR which I will really appreciate and accept

[saade]

This PR fixes this behavior: #79