Skip to content

Commit a1c5ac4

Browse files
committed
fixed: hooks test output and callback field typo
1 parent bdba031 commit a1c5ac4

File tree

6 files changed

+35
-35
lines changed

6 files changed

+35
-35
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
"@types/jest": "^25.2.3",
7373
"@typescript-eslint/eslint-plugin": "^2.33.0",
7474
"@typescript-eslint/parser": "^2.33.0",
75-
"electron": "^10.1.1",
75+
"electron": "^5.0.3",
7676
"electron-builder": "^22.6.1",
7777
"electron-devtools-installer": "^3.0.0",
7878
"enzyme": "^3.10.0",

src/__tests__/Hooks.test.js

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2,39 +2,41 @@ import { renderHook, act, cleanup } from '@testing-library/react-hooks';
22
import useToggleModal from '../components/TestMenu/testMenuHooks';
33

44
afterEach(cleanup);
5-
test('hooks should render', () => {
6-
const { result } = renderHook(() => useToggleModal('redux'));
7-
expect(result.current.title).toBe('redux');
8-
expect(result.current.isModalOpen).toBe(false);
9-
expect(typeof result.current.openModal).toBe('function');
10-
});
5+
describe('asomsdfak', () => {
6+
test('hooks should render', () => {
7+
const { result } = renderHook(() => useToggleModal('redux'));
8+
expect(result.current.title).toBe('redux');
9+
expect(result.current.isModalOpen).toBe(false);
10+
expect(typeof result.current.openModal).toBe('function');
11+
});
1112

12-
test('openModal should work', () => {
13-
const { result } = renderHook(() => useToggleModal('redux'));
13+
test('openModal should work', () => {
14+
const { result } = renderHook(() => useToggleModal('redux'));
1415

15-
act(() => {
16-
result.current.openModal();
16+
act(() => {
17+
result.current.openModal();
18+
});
19+
expect(result.current.title).toBe('New Test');
20+
expect(result.current.isModalOpen).toBe(true);
1721
});
18-
expect(result.current.title).toBe('New Test');
19-
expect(result.current.isModalOpen).toBe(true);
20-
});
2122

22-
test('openScriptModal should work', () => {
23-
const { result } = renderHook(() => useToggleModal('redux'));
23+
test('openScriptModal should work', () => {
24+
const { result } = renderHook(() => useToggleModal('redux'));
2425

25-
act(() => {
26-
result.current.openScriptModal();
26+
act(() => {
27+
result.current.openScriptModal();
28+
});
29+
expect(result.current.title).toBe('redux');
30+
expect(result.current.isModalOpen).toBe(true);
2731
});
28-
expect(result.current.title).toBe('redux');
29-
expect(result.current.isModalOpen).toBe(true);
30-
});
3132

32-
test('closeModal should work', () => {
33-
const { result } = renderHook(() => useToggleModal('redux'));
33+
test('closeModal should work', () => {
34+
const { result } = renderHook(() => useToggleModal('redux'));
3435

35-
act(() => {
36-
result.current.closeModal();
36+
act(() => {
37+
result.current.closeModal();
38+
});
39+
expect(result.current.title).toBe('redux');
40+
expect(result.current.isModalOpen).toBe(false);
3741
});
38-
expect(result.current.title).toBe('redux');
39-
expect(result.current.isModalOpen).toBe(false);
4042
});

src/components/ReactHooksTestComponent/HookUpdates/HookUpdates.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,21 +96,21 @@ const HookUpdates = ({ hookUpdates, index }) => {
9696
<input
9797
type='text'
9898
id='hookParams'
99-
placeholder='eg. false, 0'
99+
placeholder='e.g. false, 0'
100100
onChange={(e) => handleChangeHookUpdatesFields(e, 'hookParams')}
101101
/>
102102
</div>
103103
</div>
104104
{hookUpdates.callbackFunc.map((callbackFunc, i) => {
105105
return (
106106
<div id={styles.cbFlexBox}>
107-
<HooksCallback callbackFunc={callbackFunc} index={index} id={i} />
107+
<HooksCallback callbackFunc={callbackFunc} index={index} id={i} key={'k' + i} />
108108
</div>
109109
);
110110
})}{' '}
111111
<div className={styles.buttonsContainer}></div>
112112
{hookUpdates.assertions.map((assertion, i) => {
113-
return <HooksAssertion assertion={assertion} index={index} id={i} />;
113+
return <HooksAssertion assertion={assertion} index={index} id={i} key={'k' + i} />;
114114
})}
115115
<div className={styles.buttonsContainer} id={styles.stateFlexBox}>
116116
<button onClick={addAssertionHandleClick} className={styles.assertionButton}>

src/components/ReactHooksTestComponent/HooksAssertion.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ const HooksAssertion = ({ assertion, index, id }) => {
5959
return (
6060
<div id={styles.groupFlexboxAssertion}>
6161
<div id={styles.labelInput}>
62-
<label htmlFor='expectedState'>Expect State</label>
62+
<label htmlFor='expectedState'>Expected State</label>
6363
<div id={styles.inputFlexBox}>
6464
<input
6565
type='text'

src/components/ReactHooksTestComponent/HooksCallback.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const HooksCallback = ({ callbackFunc, index, id }) => {
2525
<input
2626
type='text'
2727
list='responseProperties'
28-
value={callbackFunc.callbackFunc}
28+
placeholder='e.g. openModal'
2929
onChange={(e) => handleChangeUpdateCallbackFunc(e, 'callbackFunc')}
3030
/>
3131
</div>

src/context/useGenerateTest.jsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
2-
31
const remote = window.require('electron').remote;
42
const fs = remote.require('fs');
53
const path = remote.require('path');
@@ -660,7 +658,7 @@ function useGenerateTest(test, projectFilePath) {
660658
hookUpdates.assertions.forEach((assertion) => {
661659
testFileCode += `expect(result.current.${assertion.expectedState})${
662660
assertion.not ? '.not' : ''
663-
}.${assertion.matcher}.(${assertion.expectedValue || ''})\n`;
661+
}.${assertion.matcher}(${assertion.expectedValue || ''})\n`;
664662
});
665663
testFileCode += '})\n\n';
666664
};

0 commit comments

Comments
 (0)