|
| 1 | +"""Integration tests validating README examples execute correctly. |
| 2 | +
|
| 3 | +These tests ensure that code examples in README.md work as documented, |
| 4 | +without cluttering the documentation with doctest directives. Each test |
| 5 | +corresponds to a specific example section in the README. |
| 6 | +
|
| 7 | +This addresses issue #14: validating example usage without the overhead |
| 8 | +of doctests. |
| 9 | +""" |
| 10 | + |
| 11 | +from __future__ import annotations |
| 12 | + |
| 13 | +from unittest import TestCase |
| 14 | + |
| 15 | +import pytest |
| 16 | + |
| 17 | +try: |
| 18 | + import pydicom |
| 19 | + |
| 20 | + PYDICOM_AVAILABLE = True |
| 21 | +except ImportError: |
| 22 | + PYDICOM_AVAILABLE = False |
| 23 | + |
| 24 | + |
| 25 | +class TestQuickstartExample(TestCase): |
| 26 | + """Validate the README quickstart example (lines 96-113).""" |
| 27 | + |
| 28 | + @pytest.mark.skipif(not PYDICOM_AVAILABLE, reason="Requires pydicom") |
| 29 | + def test_quickstart_with_example_data(self): |
| 30 | + """Test the main quickstart example from README. |
| 31 | +
|
| 32 | + This validates the code at README lines 96-113: |
| 33 | + - Using fetch_example_dicom() |
| 34 | + - Reading DICOM with pydicom |
| 35 | + - Extracting CSA Series Header (0x29, 0x1020) |
| 36 | + - Parsing with CsaHeader |
| 37 | + """ |
| 38 | + # Import inside test to handle missing dependencies |
| 39 | + from csa_header import CsaHeader |
| 40 | + from csa_header.examples import POOCH_AVAILABLE, fetch_example_dicom |
| 41 | + |
| 42 | + if not POOCH_AVAILABLE: |
| 43 | + pytest.skip("Requires pooch for example data") |
| 44 | + |
| 45 | + # This mirrors the exact code in README quickstart |
| 46 | + dicom_path = fetch_example_dicom() |
| 47 | + dcm = pydicom.dcmread(dicom_path) |
| 48 | + |
| 49 | + # Parse CSA Series Header |
| 50 | + raw_csa = dcm[(0x29, 0x1020)].value |
| 51 | + parsed_csa = CsaHeader(raw_csa).read() |
| 52 | + |
| 53 | + # Validate structure and content (flexible assertions, not exact output) |
| 54 | + self.assertIsInstance(parsed_csa, dict) |
| 55 | + self.assertGreater(len(parsed_csa), 70, "Should have more than 70 CSA tags") |
| 56 | + self.assertIn("MrPhoenixProtocol", parsed_csa, "Should contain MrPhoenixProtocol") |
| 57 | + |
| 58 | + @pytest.mark.skipif(not PYDICOM_AVAILABLE, reason="Requires pydicom") |
| 59 | + def test_tag_count_reasonable(self): |
| 60 | + """Test that the parsed CSA has a reasonable number of tags. |
| 61 | +
|
| 62 | + README shows len(parsed_csa) == 79, but this may vary slightly |
| 63 | + with different example files. We test for a reasonable range. |
| 64 | + """ |
| 65 | + from csa_header import CsaHeader |
| 66 | + from csa_header.examples import POOCH_AVAILABLE, fetch_example_dicom |
| 67 | + |
| 68 | + if not POOCH_AVAILABLE: |
| 69 | + pytest.skip("Requires pooch for example data") |
| 70 | + |
| 71 | + dicom_path = fetch_example_dicom() |
| 72 | + dcm = pydicom.dcmread(dicom_path) |
| 73 | + raw_csa = dcm[(0x29, 0x1020)].value |
| 74 | + parsed_csa = CsaHeader(raw_csa).read() |
| 75 | + |
| 76 | + # Should have between 70-100 tags for a typical Siemens MPRAGE |
| 77 | + tag_count = len(parsed_csa) |
| 78 | + self.assertGreaterEqual(tag_count, 70) |
| 79 | + self.assertLessEqual(tag_count, 100) |
| 80 | + |
| 81 | + |
| 82 | +class TestASCCONVProtocolExample(TestCase): |
| 83 | + """Validate the ASCCONV protocol extraction example (README lines 175-184).""" |
| 84 | + |
| 85 | + @pytest.mark.skipif(not PYDICOM_AVAILABLE, reason="Requires pydicom") |
| 86 | + def test_ascconv_protocol_extraction(self): |
| 87 | + """Test ASCCONV protocol extraction example from README. |
| 88 | +
|
| 89 | + This validates the code at README lines 175-184: |
| 90 | + - Extracting MrPhoenixProtocol from parsed CSA |
| 91 | + - Accessing nested protocol parameters |
| 92 | + """ |
| 93 | + from csa_header import CsaHeader |
| 94 | + from csa_header.examples import POOCH_AVAILABLE, fetch_example_dicom |
| 95 | + |
| 96 | + if not POOCH_AVAILABLE: |
| 97 | + pytest.skip("Requires pooch for example data") |
| 98 | + |
| 99 | + dicom_path = fetch_example_dicom() |
| 100 | + dcm = pydicom.dcmread(dicom_path) |
| 101 | + raw_csa = dcm[(0x29, 0x1020)].value |
| 102 | + parsed_csa = CsaHeader(raw_csa).read() |
| 103 | + |
| 104 | + # Test protocol extraction |
| 105 | + protocol = parsed_csa.get("MrPhoenixProtocol") |
| 106 | + self.assertIsNotNone(protocol, "MrPhoenixProtocol should exist") |
| 107 | + self.assertIn("value", protocol) |
| 108 | + |
| 109 | + # ASCCONV should be parsed as a dictionary |
| 110 | + ascconv = protocol["value"] |
| 111 | + self.assertIsInstance(ascconv, dict, "ASCCONV should be parsed as dict") |
| 112 | + |
| 113 | + @pytest.mark.skipif(not PYDICOM_AVAILABLE, reason="Requires pydicom") |
| 114 | + def test_ascconv_protocol_structure(self): |
| 115 | + """Test that ASCCONV protocol contains expected structure. |
| 116 | +
|
| 117 | + The README example shows accessing alTR[0] and alTE[0]. |
| 118 | + We test that the protocol has typical parameters. |
| 119 | + """ |
| 120 | + from csa_header import CsaHeader |
| 121 | + from csa_header.examples import POOCH_AVAILABLE, fetch_example_dicom |
| 122 | + |
| 123 | + if not POOCH_AVAILABLE: |
| 124 | + pytest.skip("Requires pooch for example data") |
| 125 | + |
| 126 | + dicom_path = fetch_example_dicom() |
| 127 | + dcm = pydicom.dcmread(dicom_path) |
| 128 | + raw_csa = dcm[(0x29, 0x1020)].value |
| 129 | + parsed_csa = CsaHeader(raw_csa).read() |
| 130 | + |
| 131 | + protocol = parsed_csa.get("MrPhoenixProtocol") |
| 132 | + ascconv = protocol["value"] |
| 133 | + |
| 134 | + # ASCCONV should contain common protocol parameters |
| 135 | + # Note: specific parameters like alTR/alTE depend on the sequence type |
| 136 | + # We test for structural elements that should be present |
| 137 | + self.assertIsInstance(ascconv, dict) |
| 138 | + self.assertGreater(len(ascconv), 10, "ASCCONV should contain multiple parameters") |
| 139 | + |
| 140 | + # Check for presence of typical ASCCONV keys |
| 141 | + # ulVersion is a common protocol version identifier |
| 142 | + typical_keys = ["ulVersion", "tProtocolName", "sProtConsistencyInfo"] |
| 143 | + found_keys = [key for key in typical_keys if key in ascconv] |
| 144 | + self.assertGreater( |
| 145 | + len(found_keys), |
| 146 | + 0, |
| 147 | + f"ASCCONV should contain at least one typical key: {typical_keys}", |
| 148 | + ) |
| 149 | + |
| 150 | + |
| 151 | +class TestAPIUsageExample(TestCase): |
| 152 | + """Validate general API usage patterns from README.""" |
| 153 | + |
| 154 | + @pytest.mark.skipif(not PYDICOM_AVAILABLE, reason="Requires pydicom") |
| 155 | + def test_basic_csa_header_workflow(self): |
| 156 | + """Test the basic workflow: raw bytes -> CsaHeader -> parsed dict. |
| 157 | +
|
| 158 | + This validates the core API usage pattern shown throughout README. |
| 159 | + """ |
| 160 | + from csa_header import CsaHeader |
| 161 | + from csa_header.examples import POOCH_AVAILABLE, fetch_example_dicom |
| 162 | + |
| 163 | + if not POOCH_AVAILABLE: |
| 164 | + pytest.skip("Requires pooch for example data") |
| 165 | + |
| 166 | + # 1. Get DICOM file |
| 167 | + dicom_path = fetch_example_dicom() |
| 168 | + dcm = pydicom.dcmread(dicom_path) |
| 169 | + |
| 170 | + # 2. Extract raw CSA bytes |
| 171 | + raw_csa = dcm[(0x29, 0x1020)].value |
| 172 | + self.assertIsInstance(raw_csa, bytes) |
| 173 | + self.assertGreater(len(raw_csa), 0) |
| 174 | + |
| 175 | + # 3. Parse with CsaHeader |
| 176 | + csa = CsaHeader(raw_csa) |
| 177 | + self.assertIsInstance(csa, CsaHeader) |
| 178 | + |
| 179 | + # 4. Read parsed structure |
| 180 | + parsed = csa.read() |
| 181 | + self.assertIsInstance(parsed, dict) |
| 182 | + |
| 183 | + # 5. Verify each tag has expected structure |
| 184 | + for tag_name, tag_data in parsed.items(): |
| 185 | + self.assertIsInstance(tag_name, str) |
| 186 | + self.assertIsInstance(tag_data, dict) |
| 187 | + self.assertIn("index", tag_data) |
| 188 | + self.assertIn("VR", tag_data) |
| 189 | + self.assertIn("VM", tag_data) |
| 190 | + self.assertIn("value", tag_data) |
| 191 | + |
| 192 | + @pytest.mark.skipif(not PYDICOM_AVAILABLE, reason="Requires pydicom") |
| 193 | + def test_both_csa_headers_can_be_parsed(self): |
| 194 | + """Test that both CSA Image and Series headers can be parsed. |
| 195 | +
|
| 196 | + README shows examples with both (0x29, 0x1010) and (0x29, 0x1020). |
| 197 | + """ |
| 198 | + from csa_header import CsaHeader |
| 199 | + from csa_header.examples import POOCH_AVAILABLE, fetch_example_dicom |
| 200 | + |
| 201 | + if not POOCH_AVAILABLE: |
| 202 | + pytest.skip("Requires pooch for example data") |
| 203 | + |
| 204 | + dicom_path = fetch_example_dicom() |
| 205 | + dcm = pydicom.dcmread(dicom_path) |
| 206 | + |
| 207 | + # Test CSA Series Header (0x29, 0x1020) |
| 208 | + if (0x29, 0x1020) in dcm: |
| 209 | + raw_series = dcm[(0x29, 0x1020)].value |
| 210 | + series_csa = CsaHeader(raw_series).read() |
| 211 | + self.assertIsInstance(series_csa, dict) |
| 212 | + self.assertGreater(len(series_csa), 0) |
| 213 | + |
| 214 | + # Test CSA Image Header (0x29, 0x1010) if present |
| 215 | + if (0x29, 0x1010) in dcm: |
| 216 | + raw_image = dcm[(0x29, 0x1010)].value |
| 217 | + image_csa = CsaHeader(raw_image).read() |
| 218 | + self.assertIsInstance(image_csa, dict) |
| 219 | + self.assertGreater(len(image_csa), 0) |
| 220 | + |
| 221 | + |
| 222 | +class TestExampleDataIntegration(TestCase): |
| 223 | + """Test that the example data infrastructure works as documented.""" |
| 224 | + |
| 225 | + def test_fetch_example_dicom_returns_valid_path(self): |
| 226 | + """Test that fetch_example_dicom() returns a valid file path.""" |
| 227 | + from csa_header.examples import POOCH_AVAILABLE, fetch_example_dicom |
| 228 | + |
| 229 | + if not POOCH_AVAILABLE: |
| 230 | + pytest.skip("Requires pooch for example data") |
| 231 | + |
| 232 | + dicom_path = fetch_example_dicom() |
| 233 | + |
| 234 | + # Should return a string path |
| 235 | + self.assertIsInstance(dicom_path, str) |
| 236 | + |
| 237 | + # Path should exist |
| 238 | + from pathlib import Path |
| 239 | + |
| 240 | + self.assertTrue(Path(dicom_path).exists()) |
| 241 | + self.assertTrue(Path(dicom_path).is_file()) |
| 242 | + |
| 243 | + @pytest.mark.skipif(not PYDICOM_AVAILABLE, reason="Requires pydicom") |
| 244 | + def test_example_file_is_siemens_dicom(self): |
| 245 | + """Test that the example file is a valid Siemens DICOM.""" |
| 246 | + from csa_header.examples import POOCH_AVAILABLE, fetch_example_dicom |
| 247 | + |
| 248 | + if not POOCH_AVAILABLE: |
| 249 | + pytest.skip("Requires pooch for example data") |
| 250 | + |
| 251 | + dicom_path = fetch_example_dicom() |
| 252 | + dcm = pydicom.dcmread(dicom_path) |
| 253 | + |
| 254 | + # Should be a Siemens file |
| 255 | + self.assertTrue(hasattr(dcm, "Manufacturer")) |
| 256 | + self.assertIn("SIEMENS", dcm.Manufacturer.upper()) |
| 257 | + |
| 258 | + # Should have CSA headers |
| 259 | + has_csa = (0x29, 0x1010) in dcm or (0x29, 0x1020) in dcm |
| 260 | + self.assertTrue(has_csa, "Example file should contain CSA headers") |
| 261 | + |
| 262 | + def test_example_file_metadata_accessible(self): |
| 263 | + """Test that example file metadata is accessible without downloading.""" |
| 264 | + from csa_header.examples import get_example_info |
| 265 | + |
| 266 | + # Should work without pooch installed |
| 267 | + info = get_example_info() |
| 268 | + |
| 269 | + self.assertIsInstance(info, dict) |
| 270 | + self.assertIn("name", info) |
| 271 | + self.assertIn("checksum", info) |
| 272 | + self.assertIn("url", info) |
| 273 | + self.assertIn("doi", info) |
| 274 | + |
| 275 | + # Verify it's the documented example |
| 276 | + self.assertEqual(info["doi"], "10.5281/zenodo.17482132") |
0 commit comments