Final remaining XMLDoc and code changes.

Author: MrMatthewLayton

OnixLabs.DependencyInjection/Extensions.IServiceCollection.cs

@@ -28,7 +28,7 @@ public readonly partial struct BigDecimal
     /// <returns>Returns the quotient of the specified <see cref="BigDecimal"/> values.</returns>
     public static BigDecimal Divide(BigDecimal left, BigDecimal right, MidpointRounding mode = default)
     {
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
 
         if (right == Zero) throw new DivideByZeroException();
         if (right == One) return left;

OnixLabs.Numerics/BigDecimal.Arithmetic.Division.cs

@@ -30,7 +30,7 @@ public readonly partial struct BigDecimal
     public static BigDecimal SetScale(BigDecimal value, int scale, MidpointRounding mode = default)
     {
         Require(scale >= 0, "Scale must be greater than or equal to zero.", nameof(scale));
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
 
         if (scale == value.Scale) return value;
         if (scale < value.Scale) return Round(value, scale, mode);

OnixLabs.Numerics/BigDecimal.Arithmetic.Scale.cs

@@ -38,7 +38,7 @@ namespace OnixLabs.Numerics;
     public BigDecimal(BigInteger value, int scale = 0, ScaleMode mode = default)
     {
         Require(scale >= 0, "Scale must be greater than or equal to zero.", nameof(scale));
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
         number = value.ToNumberInfo(scale, mode);
     }
 
@@ -49,7 +49,7 @@ public BigDecimal(BigInteger value, int scale = 0, ScaleMode mode = default)
     /// <param name="mode">The conversion mode that determines whether the floating-point value should be converted from its binary or decimal representation.</param>
     public BigDecimal(float value, ConversionMode mode = default)
     {
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
         number = value.ToNumberInfo(mode);
     }
 
@@ -60,7 +60,7 @@ public BigDecimal(float value, ConversionMode mode = default)
     /// <param name="mode">The conversion mode that determines whether the floating-point value should be converted from its binary or decimal representation.</param>
     public BigDecimal(double value, ConversionMode mode = default)
     {
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
         number = value.ToNumberInfo(mode);
     }
 

OnixLabs.Numerics/BigDecimal.cs

@@ -35,7 +35,7 @@ internal static class Ieee754Converter
     public static NumberInfo Convert(float value, ConversionMode mode)
     {
         RequireRealNumber(value);
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
 
         if (IsZeroOrOne(value, out NumberInfo result)) return result;
 
@@ -56,7 +56,7 @@ public static NumberInfo Convert(float value, ConversionMode mode)
     public static NumberInfo Convert(double value, ConversionMode mode)
     {
         RequireRealNumber(value);
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
 
         if (IsZeroOrOne(value, out NumberInfo result)) return result;
 

OnixLabs.Numerics/Ieee754Converter.cs

@@ -71,7 +71,7 @@ public static BigInteger GetUnscaledValue(this decimal value)
     /// <exception cref="ArgumentException"> if <paramref name="scale"/> is negative.</exception>
     public static decimal SetScale(this decimal value, int scale)
     {
-        RequireWithinRangeInclusive(scale, 0, MaxScale, "Scale must be within the inclusive range of 0 to 28.", nameof(scale));
+        RequireWithinRangeInclusive(scale, 0, MaxScale, "Scale must be within the inclusive range of 0 to 28.");
 
         // Determine maximum representable scale given the integer part length
         BigInteger unscaledValue = value.GetUnscaledValue();
@@ -121,7 +121,7 @@ public static decimal SetScale(this decimal value, int scale)
     /// <exception cref="ArgumentException"> if <paramref name="scale"/> is negative.</exception>
     public static decimal SetScale(this decimal value, int scale, MidpointRounding mode)
     {
-        RequireWithinRangeInclusive(scale, 0, MaxScale, "Scale must be within the inclusive range of 0 to 28.", nameof(scale));
+        RequireWithinRangeInclusive(scale, 0, MaxScale, "Scale must be within the inclusive range of 0 to 28.");
 
         // Determine maximum representable scale
         BigInteger unscaledValue = value.GetUnscaledValue();
@@ -170,7 +170,7 @@ public static decimal SetScale(this decimal value, int scale, MidpointRounding m
     private static BigInteger GetUnscaledInteger<T>(this T value, int scale, ScaleMode mode) where T : IBinaryInteger<T>
     {
         Require(scale >= 0, "Scale must be greater than or equal to zero.", nameof(value));
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
 
         BigInteger integer = value.ToBigInteger();
         return scale == 0 || mode == ScaleMode.Fractional ? integer : integer * BigInteger.Pow(10, scale);
@@ -239,7 +239,7 @@ public static BigDecimal ToBigDecimal<T>(this T value, int scale = 0, ScaleMode
     public static decimal ToDecimal<T>(this T value, int scale = 0, ScaleMode mode = default) where T : IBinaryInteger<T>
     {
         Require(scale.IsBetween(0, 28), "Scale must be between 0 and 28.");
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
 
         BigInteger scaled = value.GetUnscaledInteger(scale, mode);
         Check(scaled.IsBetween(MinDecimal, MaxDecimal), $"Value is either too large or too small to convert to {nameof(Decimal)}.");
@@ -263,7 +263,7 @@ public static decimal ToDecimal<T>(this T value, int scale = 0, ScaleMode mode =
     public static NumberInfo ToNumberInfo<T>(this T value, int scale = 0, ScaleMode mode = default) where T : IBinaryInteger<T>
     {
         Require(scale >= 0, "Scale must be greater than or equal to zero", nameof(scale));
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
         BigInteger unscaledValue = value.GetUnscaledInteger(scale, mode);
         return new NumberInfo(unscaledValue, scale);
     }
@@ -276,7 +276,7 @@ public static NumberInfo ToNumberInfo<T>(this T value, int scale = 0, ScaleMode
     /// <returns>Returns a <see cref="NumberInfo"/> representing the current value.</returns>
     public static NumberInfo ToNumberInfo(this float value, ConversionMode mode = default)
     {
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
         return Ieee754Converter.Convert(value, mode);
     }
 
@@ -288,7 +288,7 @@ public static NumberInfo ToNumberInfo(this float value, ConversionMode mode = de
     /// <returns>Returns a <see cref="NumberInfo"/> representing the current value.</returns>
     public static NumberInfo ToNumberInfo(this double value, ConversionMode mode = default)
     {
-        RequireIsDefined(mode, nameof(mode));
+        RequireIsDefined(mode);
         return Ieee754Converter.Convert(value, mode);
     }
 

OnixLabs.Numerics/NumericsExtensions.cs

@@ -20,22 +20,22 @@ namespace OnixLabs.Security.Cryptography;
 public readonly partial struct DigitalSignature
 {
     /// <summary>
-    /// Gets the underlying <see cref="T:Byte[]"/> representation of the current <see cref="DigitalSignature"/> instance as a new <see cref="ReadOnlyMemory{T}"/> instance.
+    /// Gets the underlying <see cref="byte"/> array representation of the current <see cref="DigitalSignature"/> instance as a new <see cref="ReadOnlyMemory{T}"/> instance.
     /// </summary>
-    /// <returns>Return the underlying <see cref="T:Byte[]"/> representation of the current <see cref="DigitalSignature"/> instance as a new <see cref="ReadOnlyMemory{T}"/> instance.</returns>
+    /// <returns>Return the underlying <see cref="byte"/> array representation of the current <see cref="DigitalSignature"/> instance as a new <see cref="ReadOnlyMemory{T}"/> instance.</returns>
     public ReadOnlyMemory<byte> AsReadOnlyMemory() => value;
 
     /// <summary>
-    /// Gets the underlying <see cref="T:Byte[]"/> representation of the current <see cref="DigitalSignature"/> instance as a new <see cref="ReadOnlySpan{T}"/> instance.
+    /// Gets the underlying <see cref="byte"/> array representation of the current <see cref="DigitalSignature"/> instance as a new <see cref="ReadOnlySpan{T}"/> instance.
     /// </summary>
-    /// <returns>Return the underlying <see cref="T:Byte[]"/> representation of the current <see cref="DigitalSignature"/> instance as a new <see cref="ReadOnlySpan{T}"/> instance.</returns>
+    /// <returns>Return the underlying <see cref="byte"/> array representation of the current <see cref="DigitalSignature"/> instance as a new <see cref="ReadOnlySpan{T}"/> instance.</returns>
     public ReadOnlySpan<byte> AsReadOnlySpan() => value;
 
     /// <summary>
-    /// Create a new <see cref="DigitalSignature"/> instance from the specified <see cref="T:byte[]"/> value.
+    /// Create a new <see cref="DigitalSignature"/> instance from the specified <see cref="byte"/> array value.
     /// </summary>
     /// <param name="value">The value from which to create a new <see cref="DigitalSignature"/> instance.</param>
-    /// <returns>Returns a new <see cref="DigitalSignature"/> instance from the specified <see cref="T:byte[]"/> value.</returns>
+    /// <returns>Returns a new <see cref="DigitalSignature"/> instance from the specified <see cref="byte"/> array value.</returns>
     public static implicit operator DigitalSignature(byte[] value) => new(value);
 
     /// <summary>

OnixLabs.Security.Cryptography/DigitalSignature.Convertible.cs

@@ -24,12 +24,12 @@ namespace OnixLabs.Security.Cryptography;
 /// <param name="value">The underlying value of the cryptographic digital signature.</param>
 public readonly partial struct DigitalSignature(ReadOnlySpan<byte> value) : ICryptoPrimitive<DigitalSignature>, ISpanParsable<DigitalSignature>
 {
+    private readonly byte[] value = value.ToArray();
+
     /// <summary>
     /// Initializes a new instance of the <see cref="DigitalSignature"/> struct.
     /// </summary>
     /// <param name="value">The <see cref="ReadOnlySequence{T}"/> with which to initialize the <see cref="DigitalSignature"/> instance.</param>
     // ReSharper disable once MemberCanBePrivate.Global
     public DigitalSignature(ReadOnlySequence<byte> value) : this(ReadOnlySpan<byte>.Empty) => value.CopyTo(out this.value);
-
-    private readonly byte[] value = value.ToArray();
 }

OnixLabs.Security.Cryptography/DigitalSignature.cs

@@ -19,4 +19,5 @@ namespace OnixLabs.Security.Cryptography;
 /// </summary>
 /// <param name="Signature">The underlying cryptographic digital signature.</param>
 /// <param name="Key">The underlying named cryptographic public key.</param>
+// ReSharper disable UnusedType.Global NotAccessedPositionalProperty.Global
 public readonly record struct DigitalSignatureAndPublicKey(DigitalSignature Signature, NamedPublicKey Key);

OnixLabs.Security.Cryptography/DigitalSignatureAndPublicKey.cs

@@ -21,10 +21,10 @@ namespace OnixLabs.Security.Cryptography;
 public sealed partial class EcdhPrivateKey
 {
     /// <summary>
-    /// Create a new <see cref="EcdhPrivateKey"/> instance from the specified <see cref="T:byte[]"/> value.
+    /// Create a new <see cref="EcdhPrivateKey"/> instance from the specified <see cref="byte"/> array value.
     /// </summary>
     /// <param name="value">The value from which to create a new <see cref="EcdhPrivateKey"/> instance.</param>
-    /// <returns>Returns a new <see cref="EcdhPrivateKey"/> instance from the specified <see cref="T:byte[]"/> value.</returns>
+    /// <returns>Returns a new <see cref="EcdhPrivateKey"/> instance from the specified <see cref="byte"/> array value.</returns>
     public static implicit operator EcdhPrivateKey(byte[] value) => new(value);
 
     /// <summary>