Skip to content

Commit 482957a

Browse files
alexander-schranzsaimaz
authored andcommitted
Fixed php 7.3 compatibility (#862)
* fixed php 7.3 compatibility * allow php 7.3
1 parent c65b444 commit 482957a

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ php:
55
- 7.0
66
- 7.1
77
- 7.2
8+
- 7.3
89
env:
910
global:
1011
- ES_VERSION=5.6.8 ES_DOWNLOAD_URL=https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-${ES_VERSION}.tar.gz
@@ -30,4 +31,4 @@ script:
3031
- vendor/bin/phpunit --coverage-clover=coverage.clover
3132
- vendor/bin/phpcs -p --standard=PSR2 --ignore=vendor/,Tests/app/ ./
3233
after_script:
33-
- travis_retry php vendor/bin/coveralls
34+
- travis_retry php vendor/bin/coveralls

Result/Converter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public function assignArrayToObject(array $array, $object, array $aliases)
9494
switch ($aliases[$name]['type']) {
9595
case 'date':
9696
if (is_null($value) || (is_object($value) && $value instanceof \DateTimeInterface)) {
97-
continue;
97+
continue 2;
9898
}
9999
if (is_numeric($value) && (int)$value == $value) {
100100
$time = $value;

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
}
1212
],
1313
"require": {
14-
"php": ">=5.6,<7.3",
14+
"php": ">=5.6,<7.4",
1515
"symfony/framework-bundle": "^2.8|^3.0|^4",
1616
"symfony/console": "^2.8|^3.0|^4",
1717
"symfony/stopwatch": "^2.8|^3.0|^4",

0 commit comments

Comments
 (0)