Skip to content

Commit 0d62688

Browse files
committed
removed unnecessary condition from gh action
1 parent 6b0ee9e commit 0d62688

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

.github/composite-actions/install/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ runs:
77
- name: Setup Node.js
88
uses: actions/setup-node@v4
99
with:
10-
node-version: 20
10+
node-version-file: '.nvmrc'
1111
cache: npm
1212

1313
- name: Install dependencies

.github/workflows/nextjs.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@ jobs:
5252

5353
# Deployment job
5454
deploy:
55-
# Since `workflow_run` only has 3 activity types (`completed`, `requested` and `in_progress`),
56-
# even if `Quality` workflow gets completed by failing, this workflow starts to run.
57-
# To prevent this, we add a condition here.
58-
# https://github.com/orgs/community/discussions/26238#discussioncomment-3250901
59-
if: ${{ github.event.workflow_run.conclusion == 'success' }}
6055
environment:
6156
name: github-pages
6257
url: ${{ steps.deployment.outputs.page_url }}

0 commit comments

Comments
 (0)