fix: fixed slabs being invisible (issue #6) and formatting

ok-coder1 · ok-coder1 · commit 76f97c7633b2 · 2025-06-01T12:33:51.000+05:30
Signed-off-by: ok-coder1 &lt;codershub.code@gmail.com&gt;
diff --git a/src/main/java/com/okcoder1/matrixblocks/ModBlocks.java b/src/main/java/com/okcoder1/matrixblocks/ModBlocks.java
@@ -56,9 +56,6 @@ public static Block register(Block block, String name, boolean shouldRegisterIte
             true
     );
 
-    // TODO(@ok-coder1): Fix slabs not showing if placed on top of each other
-    // labels: todo, bug, help wanted
-    // Issue URL: https://github.com/ok-coder1/matrix-blocks/issues/6
     public static final Block MATRIX_SLAB = register(
             new SlabBlock(AbstractBlock.Settings.create().sounds(BlockSoundGroup.COPPER)),
             "matrix_slab",
diff --git a/src/main/resources/assets/matrix-blocks/blockstates/fading_matrix_slab.json b/src/main/resources/assets/matrix-blocks/blockstates/fading_matrix_slab.json
@@ -1,5 +1,13 @@
 {
-    "variants": {
-        "": { "model": "matrix-blocks:block/fading_matrix_slab" }
+     "variants": {
+      "type=bottom": {
+        "model": "matrix-blocks:block/fading_matrix_slab"
+      },
+      "type=double": {
+        "model": "matrix-blocks:block/fading_matrix_block"
+      },
+      "type=top": {
+        "model": "matrix-blocks:block/fading_matrix_slab_top"
+      }
     }
 }
diff --git a/src/main/resources/assets/matrix-blocks/blockstates/matrix_slab.json b/src/main/resources/assets/matrix-blocks/blockstates/matrix_slab.json
@@ -1,5 +1,13 @@
 {
-    "variants": {
-        "": { "model": "matrix-blocks:block/matrix_slab" }
+     "variants": {
+      "type=bottom": {
+        "model": "matrix-blocks:block/matrix_slab"
+      },
+      "type=double": {
+        "model": "matrix-blocks:block/matrix_block"
+      },
+      "type=top": {
+        "model": "matrix-blocks:block/matrix_slab_top"
+      }
     }
 }
diff --git a/src/main/resources/assets/matrix-blocks/models/block/fading_matrix_slab_top.json b/src/main/resources/assets/matrix-blocks/models/block/fading_matrix_slab_top.json
@@ -0,0 +1,8 @@
+{
+    "parent": "minecraft:block/slab_top",
+    "textures": {
+      "bottom": "matrix-blocks:block/fading_matrix_block",
+      "side": "matrix-blocks:block/fading_matrix_block",
+      "top": "matrix-blocks:block/fading_matrix_block"
+    }
+}
diff --git a/src/main/resources/assets/matrix-blocks/models/block/matrix_slab_top.json b/src/main/resources/assets/matrix-blocks/models/block/matrix_slab_top.json
@@ -0,0 +1,8 @@
+{
+    "parent": "minecraft:block/slab_top",
+    "textures": {
+      "bottom": "matrix-blocks:block/matrix_block",
+      "side": "matrix-blocks:block/matrix_block",
+      "top": "matrix-blocks:block/matrix_block"
+    }
+}
diff --git a/src/main/resources/assets/matrix-blocks/models/item/fading_matrix_block.json b/src/main/resources/assets/matrix-blocks/models/item/fading_matrix_block.json
@@ -0,0 +1,6 @@
+{
+  "parent": "block/cube_all",
+  "textures": {
+    "all": "matrix-blocks:block/fading_matrix_block"
+  }
+}
diff --git a/src/main/resources/assets/matrix-blocks/models/item/fading_matrix_slab_top.json b/src/main/resources/assets/matrix-blocks/models/item/fading_matrix_slab_top.json
@@ -0,0 +1,8 @@
+{
+    "parent": "minecraft:block/slab_top",
+    "textures": {
+      "bottom": "matrix-blocks:block/fading_matrix_block",
+      "side": "matrix-blocks:block/fading_matrix_block",
+      "top": "matrix-blocks:block/fading_matrix_block"
+    }
+}
diff --git a/src/main/resources/assets/matrix-blocks/models/item/matrix_block.json b/src/main/resources/assets/matrix-blocks/models/item/matrix_block.json
@@ -0,0 +1,6 @@
+{
+  "parent": "block/cube_all",
+  "textures": {
+    "all": "matrix-blocks:block/matrix_block"
+  }
+}
diff --git a/src/main/resources/assets/matrix-blocks/models/item/matrix_slab_top.json b/src/main/resources/assets/matrix-blocks/models/item/matrix_slab_top.json
@@ -0,0 +1,8 @@
+{
+    "parent": "minecraft:block/slab_top",
+    "textures": {
+      "bottom": "matrix-blocks:block/matrix_block",
+      "side": "matrix-blocks:block/matrix_block",
+      "top": "matrix-blocks:block/matrix_block"
+    }
+}
diff --git a/src/main/resources/assets/matrix-blocks/textures/block/fading_matrix_stairs.png b/src/main/resources/assets/matrix-blocks/textures/block/fading_matrix_stairs.png
diff --git a/src/main/resources/assets/matrix-blocks/textures/item/fading_matrix_block.png b/src/main/resources/assets/matrix-blocks/textures/item/fading_matrix_block.png
diff --git a/src/main/resources/assets/matrix-blocks/textures/item/fading_matrix_stairs.png b/src/main/resources/assets/matrix-blocks/textures/item/fading_matrix_stairs.png
diff --git a/src/main/resources/assets/matrix-blocks/textures/item/matrix_block.png b/src/main/resources/assets/matrix-blocks/textures/item/matrix_block.png

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,13 @@`
`1`	`1`	`{`
`2`		`- "variants": {`
`3`		`- "": { "model": "matrix-blocks:block/fading_matrix_slab" }`
	`2`	`+ "variants": {`
	`3`	`+ "type=bottom": {`
	`4`	`+ "model": "matrix-blocks:block/fading_matrix_slab"`
	`5`	`+ },`
	`6`	`+ "type=double": {`
	`7`	`+ "model": "matrix-blocks:block/fading_matrix_block"`
	`8`	`+ },`
	`9`	`+ "type=top": {`
	`10`	`+ "model": "matrix-blocks:block/fading_matrix_slab_top"`
	`11`	`+ }`
`4`	`12`	`}`
`5`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,13 @@`
`1`	`1`	`{`
`2`		`- "variants": {`
`3`		`- "": { "model": "matrix-blocks:block/matrix_slab" }`
	`2`	`+ "variants": {`
	`3`	`+ "type=bottom": {`
	`4`	`+ "model": "matrix-blocks:block/matrix_slab"`
	`5`	`+ },`
	`6`	`+ "type=double": {`
	`7`	`+ "model": "matrix-blocks:block/matrix_block"`
	`8`	`+ },`
	`9`	`+ "type=top": {`
	`10`	`+ "model": "matrix-blocks:block/matrix_slab_top"`
	`11`	`+ }`
`4`	`12`	`}`
`5`	`13`	`}`