[IMP] Core: improve perf for modifiers

Author: Gorash

packages/core/src/Modifier.ts

@@ -13,17 +13,11 @@ interface ModifierConstructor {
 export interface Modifier {
     constructor: ModifierConstructor & this;
 }
-export interface ModifierPreserve {
-    after: boolean; // True to preserve modifier after the node that holds it.
-    paragraphBreak: boolean; // True to preserve modifier after a paragraph break.
-    lineBreak: boolean; // True to preserve modifier after a line break.
-}
 export class Modifier extends VersionableObject {
-    preserve: ModifierPreserve = new VersionableObject({
-        after: true,
-        paragraphBreak: true,
-        lineBreak: true,
-    }) as ModifierPreserve;
+    preserveAfterNode = true; // True to preserve modifier after the node that holds it.
+    preserveAfterParagraphBreak = true; // True to preserve modifier after a paragraph break.
+    preserveAfterLineBreak = true; // True to preserve modifier after a line break.
+
     get name(): string {
         return '';
     }

packages/plugin-button/src/ButtonFormat.ts

@@ -1,13 +1,8 @@
 import { Format } from '../../core/src/Format';
-import { VersionableObject } from '../../core/src/Memory/VersionableObject';
-import { ModifierPreserve } from '../../core/src/Modifier';
 
 export class ButtonFormat extends Format {
-    preserve = new VersionableObject({
-        after: true,
-        paragraphBreak: false,
-        lineBreak: false,
-    }) as ModifierPreserve;
+    preserveAfterParagraphBreak = false;
+    preserveAfterLineBreak = false;
     constructor() {
         super('BUTTON');
     }

packages/plugin-char/src/Char.ts

@@ -55,11 +55,11 @@ export class Char<T extends JWPluginConfig = JWPluginConfig> extends JWPlugin<T>
             const isAfterLineBreak = previousSibling instanceof LineBreakNode;
             const preservedModifiers = modifiers.filter(mod => {
                 if (isAfterLineBreak) {
-                    return mod.preserve.lineBreak;
+                    return mod.preserveAfterLineBreak;
                 } else if (previousSibling) {
-                    return mod.preserve.after;
+                    return mod.preserveAfterNode;
                 } else {
-                    return mod.preserve.paragraphBreak;
+                    return mod.preserveAfterParagraphBreak;
                 }
             });
             if (preservedModifiers.length) {

packages/plugin-link/src/LinkFormat.ts

@@ -1,16 +1,11 @@
 import { Format } from '../../core/src/Format';
 import { Attributes } from '../../plugin-xml/src/Attributes';
-import { VersionableObject } from '../../core/src/Memory/VersionableObject';
-import { ModifierPreserve } from '../../core/src/Modifier';
 
 export class LinkFormat extends Format {
+    preserveAfterParagraphBreak = false;
+
     constructor(url = '#', target = '') {
         super('A');
-        this.preserve = new VersionableObject({
-            after: true,
-            paragraphBreak: false,
-            lineBreak: true,
-        }) as ModifierPreserve;
         this.url = url;
         if (target) {
             this.target = target;

packages/plugin-table/src/TableRowXmlDomParser.ts

@@ -3,7 +3,6 @@ import { XmlDomParsingEngine } from '../../plugin-xml/src/XmlDomParsingEngine';
 import { TableRowNode } from './TableRowNode';
 import { nodeName } from '../../utils/src/utils';
 import { Attributes } from '../../plugin-xml/src/Attributes';
-import { Modifiers } from '../../core/src/Modifiers';
 
 export class TableSectionAttributes extends Attributes {}
 

packages/plugin-xml/src/Attributes.ts

@@ -1,19 +1,14 @@
-import { Modifier, ModifierPreserve } from '../../core/src/Modifier';
+import { Modifier } from '../../core/src/Modifier';
 import { CssStyle } from './CssStyle';
 import { ClassList } from './ClassList';
 import { makeVersionable } from '../../core/src/Memory/Versionable';
-import { VersionableObject } from '../../core/src/Memory/VersionableObject';
 
 export class Attributes extends Modifier {
     private _record: Record<string, string>;
     style = new CssStyle();
     // Avoid copiying FontAwesome classes on paragraph break.
     // TODO : need to be improved to better take care of color classes, etc.
-    preserve = new VersionableObject({
-        after: true,
-        paragraphBreak: false,
-        lineBreak: true,
-    }) as ModifierPreserve;
+    preserveAfterParagraphBreak = false;
     classList = new ClassList();
     constructor(attributes?: Attributes | NamedNodeMap | Record<string, string>) {
         super();