perf for attributes + instanceof

Author: Gorash

packages/core/src/VRange.ts

@@ -240,7 +240,7 @@ export class VRange {
         } else if (position === RelativePosition.AFTER) {
             reference = reference.lastLeaf();
         }
-        if (reference.is(ContainerNode) && !reference.hasChildren()) {
+        if (reference instanceof ContainerNode && !reference.hasChildren()) {
             reference.prepend(this.start);
         } else if (position === RelativePosition.AFTER && reference !== this.end) {
             // We check that `reference` isn't `this.end` to avoid a backward
@@ -266,7 +266,7 @@ export class VRange {
         } else if (position === RelativePosition.AFTER) {
             reference = reference.lastLeaf();
         }
-        if (reference.is(ContainerNode) && !reference.hasChildren()) {
+        if (reference instanceof ContainerNode && !reference.hasChildren()) {
             reference.append(this.end);
         } else if (position === RelativePosition.BEFORE && reference !== this.start) {
             // We check that `reference` isn't `this.start` to avoid a backward
@@ -366,7 +366,7 @@ export class VRange {
     empty(): void {
         const removableNodes = this.selectedNodes(node => {
             // TODO: Replace Table check with complex table selection support.
-            return this.mode.is(node, RuleProperty.EDITABLE) && !node.is(TableCellNode);
+            return this.mode.is(node, RuleProperty.EDITABLE) && !(node instanceof TableCellNode);
         });
         // Remove selected nodes without touching the start range's ancestors.
         const startAncestors = this.start.ancestors();

packages/plugin-blockquote/src/BlockquoteXmlDomParser.ts

@@ -13,7 +13,10 @@ export class BlockquoteXmlDomParser extends AbstractParser<Node> {
 
     async parse(item: Element): Promise<BlockquoteNode[]> {
         const blockquote = new BlockquoteNode();
-        blockquote.modifiers.append(this.engine.parseAttributes(item));
+        const attributes = this.engine.parseAttributes(item);
+        if (attributes.length) {
+            blockquote.modifiers.append(attributes);
+        }
         const nodes = await this.engine.parse(...item.childNodes);
         blockquote.append(...nodes);
         return [blockquote];

packages/plugin-bold/src/BoldXmlDomParser.ts

@@ -15,7 +15,10 @@ export class BoldXmlDomParser extends FormatXmlDomParser {
      */
     async parse(item: Element): Promise<VNode[]> {
         const bold = new BoldFormat(nodeName(item) as 'B' | 'STRONG');
-        bold.modifiers.append(this.engine.parseAttributes(item));
+        const attributes = this.engine.parseAttributes(item);
+        if (attributes.length) {
+            bold.modifiers.append(attributes);
+        }
         const children = await this.engine.parse(...item.childNodes);
         this.applyFormat(bold, children);
 

packages/plugin-char/src/CharDomObjectRenderer.ts

@@ -43,11 +43,11 @@ export class CharDomObjectRenderer extends NodeRenderer<DomObject> {
         // Render block edge spaces as non-breakable space (otherwise browsers
         // won't render them).
         const previous = charNodes[0].previousSibling();
-        if (!previous || !previous.is(InlineNode)) {
+        if (!previous || !(previous instanceof InlineNode)) {
             texts[0] = texts[0].replace(/^ /g, '\u00A0');
         }
         const next = charNodes[charNodes.length - 1].nextSibling();
-        if (!next || !next.is(InlineNode)) {
+        if (!next || !(next instanceof InlineNode)) {
             texts[texts.length - 1] = texts[texts.length - 1].replace(/^ /g, '\u00A0');
         }
         const textObject = { text: texts.join('') };

packages/plugin-color/src/Color.ts

@@ -109,7 +109,7 @@ export class Color<T extends ColorConfig = ColorConfig> extends JWPlugin<T> {
                 // Uncolor the children and their formats as well.
                 for (const child of node.children()) {
                     child.modifiers.find(Attributes)?.style.remove(this.styleName);
-                    if (child.is(InlineNode)) {
+                    if (child instanceof InlineNode) {
                         for (const format of child.modifiers.filter(Format)) {
                             format.modifiers.find(Attributes)?.style.remove(this.styleName);
                         }

packages/plugin-devtools/src/components/InfoComponent.ts

@@ -50,9 +50,9 @@ export class InfoComponent extends OwlComponent<{}> {
     propRepr(vNode: VNode, propName: string): string {
         let prop = vNode[propName];
         if (propName === 'atomic') {
-            if (vNode.is(AtomicNode)) {
+            if (vNode instanceof AtomicNode) {
                 return 'true';
-            } else if (vNode.is(ContainerNode)) {
+            } else if (vNode instanceof ContainerNode) {
                 return 'false';
             } else {
                 return '?';

packages/plugin-devtools/src/components/TreeComponent.ts

@@ -126,7 +126,10 @@ export class TreeComponent extends OwlComponent<NodeProps> {
      * @param node
      */
     isFormat(node: VNode, formatName: string): boolean {
-        return node.is(InlineNode) && !!node.modifiers.find(format => format.name === formatName);
+        return (
+            node instanceof InlineNode &&
+            !!node.modifiers.find(format => format.name === formatName)
+        );
     }
 
     //--------------------------------------------------------------------------

packages/plugin-divider/src/DividerXmlDomParser.ts

@@ -13,7 +13,10 @@ export class DividerXmlDomParser extends AbstractParser<Node> {
 
     async parse(item: Element): Promise<DividerNode[]> {
         const divider = new DividerNode();
-        divider.modifiers.append(this.engine.parseAttributes(item));
+        const attributes = this.engine.parseAttributes(item);
+        if (attributes.length) {
+            divider.modifiers.append(attributes);
+        }
 
         const nodes = await this.engine.parse(...item.childNodes);
         divider.append(...nodes);

packages/plugin-heading/src/HeadingXmlDomParser.ts

@@ -15,7 +15,10 @@ export class HeadingXmlDomParser extends AbstractParser<Node> {
 
     async parse(item: Element): Promise<HeadingNode[]> {
         const heading = new HeadingNode({ level: parseInt(nodeName(item)[1], 10) });
-        heading.modifiers.append(this.engine.parseAttributes(item));
+        const attributes = this.engine.parseAttributes(item);
+        if (attributes.length) {
+            heading.modifiers.append(attributes);
+        }
         const nodes = await this.engine.parse(...item.childNodes);
         heading.append(...nodes);
         return [heading];

packages/plugin-iframe/src/IframeDomObjectRenderer.ts

@@ -20,7 +20,7 @@ export class IframeDomObjectRenderer extends NodeRenderer<DomObject> {
                     tag: 'JW-IFRAME',
                     shadowRoot: true,
                     children: iframeNode.childVNodes.filter(
-                        child => child.tangible || child.is(MetadataNode),
+                        child => child.tangible || child instanceof MetadataNode,
                     ),
                     attach: (wrap: HTMLElement): void => {
                         if (wrap.parentElement instanceof HTMLIFrameElement) {