Merge pull request #18 from ockibagusp/test-without-new-session

Test without session

Author: ockibagusp

controllers/home_controller.go

@@ -20,6 +20,7 @@ import (
 func (controller Controller) Home(c echo.Context) error {
 	// Please note the the second parameter "home.html" is the template name and should
 	// be equal to one of the keys in the TemplateRegistry array defined in main.go
+	// ?
 	session, _ := middleware.GetAuth(c)
 	log := log.WithFields(log.Fields{
 		"username": session.Values["username"],

controllers/user_controller.go

@@ -29,11 +29,6 @@ func (controller *Controller) Users(c echo.Context) error {
 	})
 	log.Info("START request method GET for users")
 
-	log.Println(session.ID)
-	log.Println(session.IsNew)
-	log.Println(session.Options)
-	log.Println(session.Values)
-
 	is_auth_type := session.Values["is_auth_type"]
 	if is_auth_type == -1 {
 		log.Warn("for GET to users without no-session [@route: /login]")

golang-website-example.txt

@@ -1,34 +1,82 @@
+[v] success
+[x] failure
+[-] load
+
 # Insyaallah, New tasks:
-[] test main_test.go func setupTestSetCookie(...)
-    admin v
-    sugriwa x
-    subali x
+[] no debug for create models.User
+
+example,
+[6.075ms] [rows:0] INSERT INTO `users` ... VALUES (...'unit-test','unit-test@exemple.com','$2a$10$wyzBl/d31ahlHVU52kgkT.cH1lXI9b0cmdiM9Gw2ciyY9C69bTLh6','Unit Test',0,'',0)
+...
+time="2023-01-14T15:14:14+07:00" level=info msg="START request method POST for create user" route=/users/add username=
+time="2023-01-14T15:14:15+07:00" level=info msg="models.User: [+]success" route=/users/add user_success="{{... example example@example.com $2a$10$1cbJNsJNOXk4hwYYVtlUT.B0MwNwp4sRmI2pS9frCuC.0IBLyRsSO Example 0  0}" username=}}
 
+[] ...
 
 # Completed task:
 1. [-] testing session
-    [-] Set-Cookie headers there isn't any: session
+    [x] Set-Cookie headers there isn't any: session
 
-    [-] 2 missing users
+    [x] 2 missing users
         Func: TestLogin
         Users:
             - admin - ok x
             - sugriwa - ok x
             - subali - ok x
             - ockibagusp - no v
 
-    [-] UndeclaredName: setupTestHandler v
+    [x] UndeclaredName: setupTestHandler v
         https://pkg.go.dev/golang.org/x/tools/internal/typesinternal#UndeclaredName
 
         package tests v
         session.go x
             - for example: setupTestHandler() -> UndeclaredName
         move:
             - session.go to session_test.go v
+    
+    [-] SetSession and GetAuth
+        v login
+        v user controller
+        v home controller
+        v about controller
+        - admin controller
+
+        --- FAIL: TestUsersController
+            - user_controller_test.go:253
+            - user_controller_test.go:263
+
+        http://127.0.0.1:35351/users
+        http://127.0.0.1:35351/users?admin=all
+        http://127.0.0.1:35351/users?user=all
+        http://127.0.0.1:35351/users?false=all
+
+        --- FAIL: TestCreateUserController
+            users_[admin]_to_GET_create_it_success
+            GET http://127.0.0.1:39181/users/add
+
+            - user_controller_test.go:518
+
+        --- FAIL: TestCreateUserController/user_[admin]_to_POST_create_it_success
+
+            POST http://127.0.0.1:39181/users/add
+
+        --- FAIL: TestCreateUserController/users_[admin]_to_POST_create_it_failure:_Duplicate_entry
+
+        --- FAIL: TestReadUserController
+
+        --- FAIL: TestUpdateUserController
+            --- FAIL: TestUpdateUserController/users_[admin]_to_admin_GET_update_it_success:_id=1
+
+            --- FAIL: TestUpdateUserController/users_[admin]_to_user_GET_update_it_success:_id=2
+
+            --- FAIL: TestUpdateUserController/users_[admin]_to_admin_POST_update_it_success:_id=1
+
+        --- FAIL: TestUpdateUserByPasswordUserController
+            --- FAIL: TestUpdateUserByPasswordUserController/users_[admin]_to_GET_update_user_by_password_it_success:_id=1
 
-2. [x] controller UpdateUser: validation
+2. [v] controller UpdateUser: validation
 
-3. [x] test controller DeteleUser: id=3
+3. [v] test controller DeteleUser: id=3
 controllers/user_controller.go:678
 
 name:   "users [subali] to [subali] DELETE it success: id=3",
@@ -40,4 +88,4 @@ time="2022-12-30T14:54:47+07:00" level=info msg="START request method GET for de
 time="2022-12-30T14:54:47+07:00" level=warning msg="for GET to delete user without no-session [@route: /login]" route="/users/delete/:id -> id:1" username=
 ...
 
-4. [x] test without csrf
+4. [v] test without csrf

middleware/session_middleware.go

@@ -1,18 +1,27 @@
 package middleware
 
 import (
+	"os"
+
 	"github.com/gorilla/sessions"
 	"github.com/labstack/echo-contrib/session"
 	"github.com/labstack/echo/v4"
 	"github.com/ockibagusp/golang-website-example/models"
+	"github.com/ockibagusp/golang-website-example/tests/method"
+	modelsTest "github.com/ockibagusp/golang-website-example/tests/models"
 )
 
 // base.html -> {{if eq ((index .session.Values "is_auth_type") | tostring) -1 }}ok{{end}}
 
 // GetAuth: get session to authenticated
 func GetAuth(c echo.Context) (session_gorilla *sessions.Session, err error) {
-	if session_gorilla, err = session.Get("session", c); err != nil {
-		return
+	// Test: session_test = true
+	if os.Getenv("session_test") == "1" && method.SetSession == false {
+		session_gorilla, err = modelsTest.GetAuthSession()
+	} else {
+		if session_gorilla, err = session.Get("session", c); err != nil {
+			return
+		}
 	}
 
 	is_auth_type := session_gorilla.Values["is_auth_type"]
@@ -63,6 +72,11 @@ func GetAdmin(c echo.Context) (session_gorilla *sessions.Session, err error) {
 
 // SetSession: set session from User
 func SetSession(user models.User, c echo.Context) (session_gorilla *sessions.Session, err error) {
+	// Test: session_test = true
+	if os.Getenv("session_test") == "1" {
+		modelsTest.SetAuthSession(&user)
+	}
+
 	session_gorilla, err = session.Get("session", c)
 	if err != nil {
 		return

tests/about_controller_test.go

@@ -6,40 +6,45 @@ import (
 	"testing"
 
 	"github.com/gavv/httpexpect/v2"
+	"github.com/ockibagusp/golang-website-example/tests/method"
+	modelsTest "github.com/ockibagusp/golang-website-example/tests/models"
 	"github.com/stretchr/testify/assert"
 )
 
 func TestAboutSuccess(t *testing.T) {
 	assert := assert.New(t)
 
 	no_auth := setupTestServer(t)
-	auth_admin := setupTestServerAuth(no_auth, 1)
-	auth_sugriwa := setupTestServerAuth(no_auth, 2)
+
+	// test for SetSession = false
+	method.SetSession = false
+	// test for db users
+	truncateUsers(db)
 
 	test_cases := []struct {
 		name        string
-		expect      *httpexpect.Expect // auth_admin, session_sugriwa or no-auth
+		expect      string // admin, sugriwa
 		html_navbar regex
 	}{
 		{
 			name:   "about [no-auth] success",
-			expect: no_auth,
+			expect: "",
 			html_navbar: regex{
 				must_compile: `<a href="/login" class="btn btn-outline-success my-2 my-sm-0">(.*)</a>`,
 				actual:       `<a href="/login" class="btn btn-outline-success my-2 my-sm-0">Login</a>`,
 			},
 		},
 		{
 			name:   "about [admin] success",
-			expect: auth_admin,
+			expect: ADMIN,
 			html_navbar: regex{
 				must_compile: `<a class="btn">(.*)</a>`,
 				actual:       `<a class="btn">ADMIN</a>`,
 			},
 		},
 		{
 			name:   "home [user] success",
-			expect: auth_sugriwa,
+			expect: SUGRIWA,
 			html_navbar: regex{
 				must_compile: `<a href="/users" class="btn btn-outline-secondary my-2 my-sm-0">(.*)</a>`,
 				actual:       `<a href="/users" class="btn btn-outline-secondary my-2 my-sm-0">Users</a>`,
@@ -49,10 +54,10 @@ func TestAboutSuccess(t *testing.T) {
 
 	for _, test := range test_cases {
 		var result *httpexpect.Response
-		expect := test.expect // auth_admin, auth_sugriwa or no-auth
+		modelsTest.UserSelectTest = test.expect // auth_admin, auth_sugriwa or no-auth
 
 		t.Run(test.name, func(t *testing.T) {
-			result = expect.GET("/about").
+			result = no_auth.GET("/about").
 				Expect().
 				Status(http.StatusOK)
 

tests/admin_controller_test.go

@@ -5,19 +5,21 @@ import (
 	"testing"
 
 	"github.com/gavv/httpexpect/v2"
+	"github.com/ockibagusp/golang-website-example/tests/method"
+	modelsTest "github.com/ockibagusp/golang-website-example/tests/models"
 )
 
 func TestAdminDeletePermanently(t *testing.T) {
 	no_auth := setupTestServer(t)
-	auth_admin := setupTestServerAuth(no_auth, 1)
-	// auth_sugriwa := setupTestServerAuth(no_auth, 2)
 
+	// test for SetSession = false
+	method.SetSession = false
 	// test for db users
 	truncateUsers(db)
 
 	test_cases := []struct {
 		name      string
-		expect    *httpexpect.Expect // auth or no-auth
+		expect    string // auth or no-auth
 		url_query string
 		status    int
 	}{
@@ -26,7 +28,7 @@ func TestAdminDeletePermanently(t *testing.T) {
 		*/
 		{
 			name:   "delete permanently [admin] to GET it success: all",
-			expect: auth_admin,
+			expect: ADMIN,
 			// HTTP response status: 200 OK
 			status: http.StatusOK,
 		},
@@ -61,18 +63,18 @@ func TestAdminDeletePermanently(t *testing.T) {
 
 			var expect = test.expect
 		*/
-		var expect *httpexpect.Expect = test.expect
+		modelsTest.UserSelectTest = test.expect // ADMIN and SUGRIWA
 
 		t.Run(test.name, func(t *testing.T) {
 			// @route: exemple "/admin/delete-permanently?admin=all"
 			if test.url_query != "" {
-				result = expect.GET("/admin/delete-permanently").
+				result = no_auth.GET("/admin/delete-permanently").
 					WithQuery(test.url_query, "all").
 					Expect().
 					Status(test.status)
 			} else {
 				// @route: "/admin/delete-permanently"
-				result = expect.GET("/admin/delete-permanently").
+				result = no_auth.GET("/admin/delete-permanently").
 					Expect().
 					Status(test.status)
 			}

tests/home_controller_test.go

@@ -6,25 +6,30 @@ import (
 	"testing"
 
 	"github.com/gavv/httpexpect/v2"
+	"github.com/ockibagusp/golang-website-example/tests/method"
+	modelsTest "github.com/ockibagusp/golang-website-example/tests/models"
 	"github.com/stretchr/testify/assert"
 )
 
 func TestHomeController(t *testing.T) {
 	assert := assert.New(t)
 
 	no_auth := setupTestServer(t)
-	auth_admin := setupTestServerAuth(no_auth, 1)
-	auth_sugriwa := setupTestServerAuth(no_auth, 2)
+
+	// test for SetSession = false
+	method.SetSession = false
+	// test for db users
+	truncateUsers(db)
 
 	test_cases := []struct {
 		name           string
-		expect         *httpexpect.Expect // auth_admin, session_sugriwa or no-auth
+		expect         string // admin, sugriwa
 		html_navbar    regex
 		html_jumbotron regex
 	}{
 		{
 			name:   "home [no-auth] success",
-			expect: no_auth,
+			expect: "",
 			html_navbar: regex{
 				must_compile: `<a href="/login" (.*)</a>`,
 				actual:       `<a href="/login" class="btn btn-outline-success my-2 my-sm-0">Login</a>`,
@@ -36,7 +41,7 @@ func TestHomeController(t *testing.T) {
 		},
 		{
 			name:   "home [admin] success",
-			expect: auth_admin,
+			expect: ADMIN,
 			html_navbar: regex{
 				must_compile: `<a class="btn">(.*)</a>`,
 				actual:       `<a class="btn">ADMIN</a>`,
@@ -48,7 +53,7 @@ func TestHomeController(t *testing.T) {
 		},
 		{
 			name:   "home [user] success",
-			expect: auth_sugriwa,
+			expect: SUGRIWA,
 			html_navbar: regex{
 				must_compile: `<a href="/users" (.*)</a>`,
 				actual:       `<a href="/users" class="btn btn-outline-secondary my-2 my-sm-0">Users</a>`,
@@ -62,10 +67,10 @@ func TestHomeController(t *testing.T) {
 
 	for _, test := range test_cases {
 		var result *httpexpect.Response
-		expect := test.expect // auth_admin, auth_sugriwa or no-auth
+		modelsTest.UserSelectTest = test.expect // auth_admin, auth_sugriwa or no-auth
 
 		t.Run(test.name, func(t *testing.T) {
-			result = expect.GET("/").
+			result = no_auth.GET("/").
 				Expect().
 				Status(http.StatusOK)