[30/12/22] test controller DeteleUser: id=3 x

Author: ockibagusp

.gitignore

@@ -8,5 +8,6 @@ golang-website-example
 golang-website-example.exe
 
 # air
+bin
 .air.toml
 tmp

controllers/home_controller.go

@@ -32,7 +32,7 @@ func (controller Controller) Home(c echo.Context) error {
 		var user models.User
 		if err := controller.DB.Select("name").Where(
 			"username = ?", session.Values["username"],
-		).First(&user); err.Error != nil { // TODO: why?
+		).First(&user); err.Error != nil { // why?
 			log.Warnf(`session values "username" error: %v`, err.Error)
 		}
 

controllers/user_controller.go

@@ -29,6 +29,11 @@ func (controller *Controller) Users(c echo.Context) error {
 	})
 	log.Info("START request method GET for users")
 
+	log.Println(session.ID)
+	log.Println(session.IsNew)
+	log.Println(session.Options)
+	log.Println(session.Values)
+
 	is_auth_type := session.Values["is_auth_type"]
 	if is_auth_type == -1 {
 		log.Warn("for GET to users without no-session [@route: /login]")
@@ -149,7 +154,7 @@ func (controller *Controller) CreateUser(c echo.Context) error {
 		}
 
 		// userForm: type of a user
-		_userForm := types.UserForm{
+		userForm := types.UserForm{
 			Username:        c.FormValue("username"),
 			Email:           c.FormValue("email"),
 			Password:        c.FormValue("password"),
@@ -159,19 +164,19 @@ func (controller *Controller) CreateUser(c echo.Context) error {
 			Photo:           c.FormValue("photo"),
 		}
 
-		// _userForm: Validate of a validate user
+		// userForm: Validate of a validate user
 		err := validation.Errors{
 			"username": validation.Validate(
-				_userForm.Username, validation.Required, validation.Length(4, 15),
+				userForm.Username, validation.Required, validation.Length(4, 15),
 			),
-			"email": validation.Validate(_userForm.Email, validation.Required, is.Email),
+			"email": validation.Validate(userForm.Email, validation.Required, is.EmailFormat),
 			"password": validation.Validate(
-				_userForm.Password, validation.Required, validation.Length(6, 18),
-				validation.By(types.PasswordEquals(_userForm.ConfirmPassword)),
+				userForm.Password, validation.Required, validation.Length(6, 18),
+				validation.By(types.PasswordEquals(userForm.ConfirmPassword)),
 			),
-			"name":  validation.Validate(_userForm.Name, validation.Required),
-			"city":  validation.Validate(_userForm.City),
-			"photo": validation.Validate(_userForm.Photo),
+			"name":  validation.Validate(userForm.Name, validation.Required),
+			"city":  validation.Validate(userForm.City),
+			"photo": validation.Validate(userForm.Photo),
 		}.Filter()
 		/* if err = validation.Errors{...}.Filter(); err != nil {
 			...
@@ -196,20 +201,20 @@ func (controller *Controller) CreateUser(c echo.Context) error {
 		}
 
 		// Password Hash
-		hash, err := middleware.PasswordHash(_userForm.Password)
+		hash, err := middleware.PasswordHash(userForm.Password)
 		if err != nil {
 			log.Warnf("for POST to create user without middleware.PasswordHash error: `%v`", err)
 			log.Warn("END request method POST for create user: [-]failure")
 			return err
 		}
 
 		user := models.User{
-			Username: _userForm.Username,
-			Email:    _userForm.Email,
+			Username: userForm.Username,
+			Email:    userForm.Email,
 			Password: hash,
-			Name:     _userForm.Name,
-			City:     _userForm.City,
-			Photo:    _userForm.Photo,
+			Name:     userForm.Name,
+			City:     userForm.City,
+			Photo:    userForm.Photo,
 		}
 
 		// _, err := user.Save(...): be able
@@ -403,9 +408,9 @@ func (controller *Controller) UpdateUser(c echo.Context) error {
 			Email:    c.FormValue("email"),
 			Name:     c.FormValue("name"),
 			City:     city,
-			// TODO: photo
+			// TODO: photo, insyaallah
 			Photo: "",
-			// TODO: is admin
+			// TODO: is admin, insyaallah
 			IsAdmin: 0,
 		}
 
@@ -666,8 +671,11 @@ func (controller *Controller) DeleteUser(c echo.Context) error {
 		for example:
 		username ockibagusp delete 'ockibagusp': ok
 		username ockibagusp delete 'sugriwa': no
+
+		insyaallah
 	*/
 	_, err = models.User{}.FirstByIDAndUsername(
+		// ???
 		controller.DB, id, session.Values["username"].(string),
 	)
 

golang-website-example.txt

@@ -0,0 +1,40 @@
+# Insyaallah, New tasks:
+[] test without csrf
+
+[] test controller DeteleUser: id=3
+controllers/user_controller.go:678
+...
+time="2022-12-30T14:54:47+07:00" level=info msg="START request method GET for delete user" route="/users/delete/:id -> id:3" username="<nil>"
+{"time":"2022-12-30T14:54:47.752300052+07:00","level":"-","prefix":"echo","file":"recover.go","line":"92","message":"[PANIC RECOVER] interface conversion: interface {} is nil, not string goroutine 289 [running]:\ngithub.com/labstack/echo/v4/middleware.RecoverWithConfig.func1.1.1()\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/labstack/echo/v4/middleware/recover.go:77 +0x10d\npanic({0xaec560, 0xc0004f9680})\n\t/usr/lib/golang/src/runtime/panic.go:884 +0x212\ngithub.com/ockibagusp/golang-website-example/controllers.(*Controller).DeleteUser(0x11273e8, {0xcbfed0, 0xc0000a4280})\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/controllers/user_controller.go:678 +0xc65\ngithub.com/labstack/echo/v4.(*Echo).add.func1({0xcbfed0, 0xc0000a4280})\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/labstack/echo/v4/echo.go:552 +0x51\ngithub.com/labstack/echo-contrib/session.MiddlewareWithConfig.func1.1({0xcbfed0, 0xc0000a4280})\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/labstack/echo-contrib/session/session.go:70 +0x105\ngithub.com/labstack/echo/v4/middleware.RecoverWithConfig.func1.1({0xcbfed0, 0xc0000a4280})\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/labstack/echo/v4/middleware/recover.go:98 +0xf8\ngithub.com/labstack/echo/v4/middleware.LoggerWithConfig.func2.1({0xcbfed0, 0xc0000a4280})\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/labstack/echo/v4/middleware/logger.go:117 +0xe2\ngithub.com/labstack/echo/v4.(*Echo).ServeHTTP(0xc000358d80, {0xcb7450?, 0xc0003f72c0}, 0xc000521200)\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/labstack/echo/v4/echo.go:662 +0x3d1\ngithub.com/gavv/httpexpect/v2.Binder.RoundTrip({{0xcb2620?, 0xc000358d80?}, 0x0?}, 0xc000521100)\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/gavv/httpexpect/v2/binder.go:64 +0x3f4\nnet/http.send(0xc000521100, {0xcb34a0, 0xc000482a38}, {0xb75360?, 0xc00002d501?, 0x0?})\n\t/usr/lib/golang/src/net/http/client.go:251 +0x5f7\nnet/http.(*Client).send(0xc0003935f0, 0xc000521100, {0x29?, 0x36?, 0x0?})\n\t/usr/lib/golang/src/net/http/client.go:175 +0x9b\nnet/http.(*Client).do(0xc0003935f0, 0xc000521100)\n\t/usr/lib/golang/src/net/http/client.go:715 +0x8fc\nnet/http.(*Client).Do(0xc000437a00?, 0x48f5d7?)\n\t/usr/lib/golang/src/net/http/client.go:581 +0x19\ngithub.com/gavv/httpexpect/v2.(*Request).sendRequest.func1()\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/gavv/httpexpect/v2/request.go:1276 +0x2d\ngithub.com/gavv/httpexpect/v2.(*Request).retryRequest.func1(0xc000060bb0?, 0xc000437b88, 0xc000423ae8, 0xc000423b18, 0xc000423ab0)\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/gavv/httpexpect/v2/request.go:1344 +0x19e\ngithub.com/gavv/httpexpect/v2.(*Request).retryRequest(0xc0005042c0, 0x0?)\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/gavv/httpexpect/v2/request.go:1346 +0x2bc\ngithub.com/gavv/httpexpect/v2.(*Request).sendRequest(0xc0005042c0)\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/gavv/httpexpect/v2/request.go:1275 +0x4c\ngithub.com/gavv/httpexpect/v2.(*Request).roundTrip(0xc0005042c0)\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/gavv/httpexpect/v2/request.go:1194 +0x12c\ngithub.com/gavv/httpexpect/v2.(*Request).Expect(0xc0005042c0)\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/vendor/github.com/gavv/httpexpect/v2/request.go:1155 +0x36\ngithub.com/ockibagusp/golang-website-example/tests.TestDeleteUserController.func1(0xc0000cda00)\n\t/home/ockibagusp/go/src/github.com/ockibagusp/golang-website-example/tests/user_controller_test.go:1604 +0xd5\ntesting.tRunner(0xc0000cda00, 0xc0005b05a0)\n\t/usr/lib/golang/src/testing/testing.go:1446 +0x10b\ncreated by testing.(*T).Run\n\t/usr/lib/golang/src/testing/testing.go:1493 +0x35f\n\ngoroutine 1 [chan receive]:\ntesting.(*T).Run(0xc00008a680, {0xba2483?, 0x5234e5?}, 0xbec030)\n\t/usr/lib/golang/src/testing/testing.go:1494 \n"}
+{"time":"2022-12-30T14:54:47.754727104+07:00","id":"","remote_ip":"","host":"127.0.0.1:38137","method":"GET","uri":"/users/delete/3","user_agent":"","status":500,"error":"","latency":4300702,"latency_human":"4.300702ms","bytes_in":0,"bytes_out":36}
+time="2022-12-30T14:54:47+07:00" level=warning msg="for GET to delete user without no-session [@route: /login]" route="/users/delete/:id -> id:1" username=
+...
+
+[] test main_test.go func setupTestSetCookie(...)
+    admin v
+    sugriwa x
+    subali x
+
+
+# Completed task:
+1. [-] testing session
+    [-] Set-Cookie headers there isn't any: session
+
+    [-] 2 missing users
+        Func: TestLogin
+        Users:
+            - admin - ok x
+            - sugriwa - ok x
+            - subali - ok x
+            - ockibagusp - no v
+
+    [-] UndeclaredName: setupTestHandler v
+        https://pkg.go.dev/golang.org/x/tools/internal/typesinternal#UndeclaredName
+
+        package tests v
+        session.go x
+            - for example: setupTestHandler() -> UndeclaredName
+        move:
+            - session.go to session_test.go v
+
+2. [x] controller UpdateUser: validation

main.go

@@ -13,6 +13,8 @@ import (
 )
 
 func main() {
+	os.Setenv("session_test", "0")
+
 	// controllers init
 	controllers := controllers.New()
 

router/router.go

@@ -1,6 +1,8 @@
 package router
 
 import (
+	"os"
+
 	"github.com/gorilla/sessions"
 	"github.com/labstack/echo-contrib/session"
 	"github.com/labstack/echo/v4"
@@ -20,27 +22,35 @@ func New(controllers *controllers.Controller) (router *echo.Echo) {
 	router.Use(middleware.Recover())
 
 	/*
-		set env. "session_test": [all], [session] or [CSRF]
+		Insyaallah, TODO: .env session_test: {1} or {0}
+				   session_test: {true} or {false}
+
+		1. os.Setenv("session_test", ...)
+		@session_test: {true} or {1}
+		os.Setenv("session_test", "true") or,
+		os.Setenv("session_test", "1")
+
+		@session_test: {false} or {0}
+		os.Setenv("session_test", "false") or,
+		os.Setenv("session_test", "0")
 	*/
-	// if os.Getenv("session_test") == "all" || os.Getenv("session_test") == "session" {
 	logrus.Println("Setenv: session_test = session")
-	// TODO: .env cookie store ?
 	router.Use(session.Middleware(sessions.NewCookieStore(
 		[]byte("something-very-secret"),
 	)))
-	// }
 
-	// if os.Getenv("session_test") == "all" || os.Getenv("session_test") == "CSRF" {
-	logrus.Println("Setenv: session_test = CSRF")
-	router.Use(middleware.CSRFWithConfig(middleware.CSRFConfig{
-		// Optional. Default value "header:X-CSRF-Token".
-		// Possible values:
-		// - "header:<name>"
-		// - "form:<name>"
-		// - "query:<name>"
-		TokenLookup: "form:X-CSRF-Token",
-	}))
-	// }
+	// PROD
+	if os.Getenv("session_test") == "0" || os.Getenv("session_test") == "false" {
+		logrus.Println("Setenv: session_test = CSRF")
+		router.Use(middleware.CSRFWithConfig(middleware.CSRFConfig{
+			// Optional. Default value "header:X-CSRF-Token".
+			// Possible values:
+			// - "header:<name>"
+			// - "form:<name>"
+			// - "query:<name>"
+			TokenLookup: "form:X-CSRF-Token",
+		}))
+	}
 
 	// Instantiate a template registry with an array of template set
 	router.Renderer = template.NewTemplates()

template/func_map.go

@@ -5,8 +5,6 @@ import (
 	"strconv"
 )
 
-// TODO: why?
-
 // function map more
 var FuncMapMore = func() template.FuncMap {
 	list := template.FuncMap{
@@ -16,7 +14,7 @@ var FuncMapMore = func() template.FuncMap {
 	return list
 }
 
-// TODO
+// TODO, insyaallah
 //
 // Code: session_gorilla.Values["s_auth_type"]
 // HTML: {{index $.session_gorilla.Values "is_auth_type" | toString}} ?

template/template.go

@@ -136,11 +136,11 @@ func parseFileHTMLOnly(name string) *template.Template {
 func rootedPathName() (dir string) {
 	dir, err := os.Getwd()
 	if err != nil {
-		// TODO: Docker, Kubernetes ex.?
+		// Docker, Kubernetes ex.? insyaallah
 		log.Fatal(err)
 	}
 
-	// TODO: Linux and MacOS: ok. Windows: ...?
+	// Linux and MacOS: ok. Windows: ...? insyaallah
 	regex := regexp.MustCompile("/tests$")
 	match := regex.Match([]byte(dir))
 

tests/home_controller_test.go

@@ -71,7 +71,7 @@ func TestHomeController(t *testing.T) {
 
 			result_body := result.Body().Raw()
 
-			// TODO: why?
+			// why?
 			var regex *regexp.Regexp
 			var match string
 			if test.html_navbar.must_compile != "" {