we're not using the sizes in the sidecar buffer so don't store them

Author: ngoldbaum

stringdtype/stringdtype/src/static_string.c

@@ -109,22 +109,18 @@ char *
 npy_string_arena_malloc(npy_string_arena *arena, npy_string_realloc_func r,
                         size_t size)
 {
-    // one extra size_t to store the size of the allocation
-    size_t string_storage_size = size + sizeof(size_t);
-    // expand size to nearest multiple of 8 bytes to ensure 64 bit alignment
-    string_storage_size += (8 - string_storage_size % 8);
-    if ((arena->size - arena->cursor) <= string_storage_size) {
+    if ((arena->size - arena->cursor) <= size) {
         // realloc the buffer so there is enough room
         // first guess is to double the size of the buffer
         size_t newsize;
         if (arena->size == 0) {
-            newsize = string_storage_size;
+            newsize = size;
         }
-        else if (((2 * arena->size) - arena->cursor) > string_storage_size) {
+        else if (((2 * arena->size) - arena->cursor) > size) {
             newsize = 2 * arena->size;
         }
         else {
-            newsize = arena->size + string_storage_size;
+            newsize = arena->size + size;
         }
         if ((arena->cursor + size) >= newsize) {
             // doubling the current size isn't enough
@@ -139,10 +135,8 @@ npy_string_arena_malloc(npy_string_arena *arena, npy_string_realloc_func r,
         arena->buffer = newbuf;
         arena->size = newsize;
     }
-    size_t *size_loc = (size_t *)&arena->buffer[arena->cursor];
-    *size_loc = size;
-    char *ret = &arena->buffer[arena->cursor + sizeof(size_t)];
-    arena->cursor += string_storage_size;
+    char *ret = &arena->buffer[arena->cursor];
+    arena->cursor += size;
     return ret;
 }