ipn/ipnlocal: fix state_test data race seen in CI

bradfitz · bradfitz · commit 4650061326af · 2025-11-10T17:48:55.000-08:00
Unfortunately I closed the tab and lost it in my sea of CI failures
I'm currently fighting.

Updates #cleanup

Change-Id: I4e3a652d57d52b75238f25d104fc1987add64191
Signed-off-by: Brad Fitzpatrick &lt;bradfitz@tailscale.com&gt;
diff --git a/ipn/ipnlocal/state_test.go b/ipn/ipnlocal/state_test.go
@@ -652,7 +652,9 @@ func runTestStateMachine(t *testing.T, seamless bool) {
 	}
 
 	// undo the state hack above.
+	b.mu.Lock()
 	b.state = ipn.Starting
+	b.mu.Unlock()
 
 	// User wants to logout.
 	store.awaitWrite()

Original file line number	Diff line number	Diff line change
`@@ -652,7 +652,9 @@ func runTestStateMachine(t *testing.T, seamless bool) {`
`652`	`652`	`}`
`653`	`653`
`654`	`654`	`// undo the state hack above.`
	`655`	`+ b.mu.Lock()`
`655`	`656`	`b.state = ipn.Starting`
	`657`	`+ b.mu.Unlock()`
`656`	`658`
`657`	`659`	`// User wants to logout.`
`658`	`660`	`store.awaitWrite()`