Skip to content

Conversation

@liamnichols
Copy link

👋 Nice Action!

I wasn't aware of it until after I was digging into the SwiftLint source code, but there is actually a reporter that formats for the GitHub Action so we can avoid having to sed stdout from now on 🚀

(The reporter wasn't documented in SwiftLint's Readme but I've added it here: realm/SwiftLint/pull/3223)

I ran this on my test project and it seems to work, but please feel free to give it a try yourself first 🙏

@liamnichols
Copy link
Author

Ah, the tests seem to fail because the output is ordered in a different way... I'm not completely sure why though since I see something about sort in the yaml (although I'm not 100% sure if I follow it correctly).

Any suggestions would be helpful 🙏

@hervenivon
Copy link

In case you don't already know,

I had issues with this https://github.com/norio-nomura/action-swiftlint. @sinoru's version https://github.com/sinoru/actions-swiftlint solved most of them, and the code is clearly maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants