Skip to content

Commit 97d3d8d

Browse files
authored
No need for thread safety in most cases. (#136)
1 parent a362e02 commit 97d3d8d

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/GitLabApiClient/Internal/Http/GitLabHttpFacade.cs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ internal sealed class GitLabHttpFacade
1616
{
1717
private const string PrivateToken = "PRIVATE-TOKEN";
1818

19-
private readonly object _locker = new object();
2019
private readonly HttpClient _httpClient;
2120
private GitLabApiRequestor _requestor;
2221
private GitLabApiPagedRequestor _pagedRequestor;
@@ -91,13 +90,10 @@ public async Task<AccessTokenResponse> LoginAsync(AccessTokenRequest accessToken
9190
string url = $"{_httpClient.BaseAddress.GetLeftPart(UriPartial.Authority)}/oauth/token";
9291
var accessTokenResponse = await _requestor.Post<AccessTokenResponse>(url, accessTokenRequest);
9392

94-
lock (_locker)
95-
{
96-
if (_httpClient.DefaultRequestHeaders.Contains(PrivateToken))
97-
_httpClient.DefaultRequestHeaders.Remove(PrivateToken);
93+
if (_httpClient.DefaultRequestHeaders.Contains(PrivateToken))
94+
_httpClient.DefaultRequestHeaders.Remove(PrivateToken);
9895

99-
_httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", accessTokenResponse.AccessToken);
100-
}
96+
_httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", accessTokenResponse.AccessToken);
10197

10298
return accessTokenResponse;
10399
}

0 commit comments

Comments
 (0)