Extend issue with task status info (#121)

Author: WebDucer

src/GitLabApiClient/Internal/Queries/IssuesQueryBuilder.cs

@@ -25,9 +25,13 @@ protected override void BuildCore(IssuesQueryOptions options)
 
             if (options.AuthorId.HasValue)
                 Add("author_id", options.AuthorId.Value);
+            else if (!string.IsNullOrWhiteSpace(options.AuthorUsername))
+                Add("author_username", options.AuthorUsername);
 
             if (options.AssigneeId.HasValue)
                 Add("assignee_id", options.AssigneeId.Value);
+            else if (options.AssigneeUsername.Any())
+                Add("assignee_username", options.AssigneeUsername);
 
             Add(options.IssueIds);
 

src/GitLabApiClient/Models/Issues/Requests/IssuesQueryOptions.cs

@@ -39,11 +39,22 @@ internal IssuesQueryOptions() { }
         /// </summary>
         public int? AuthorId { get; set; }
 
+        /// <summary>
+        /// Return issues created by the given username. Similar to <see cref="AuthorId"/> and mutually exclusive with <see cref="AuthorId"/>.
+        /// </summary>
+        public string AuthorUsername { get; set; }
+
         /// <summary>
         /// Return issues assigned to the given user id (Introduced in GitLab 9.5).
         /// </summary>
         public int? AssigneeId { get; set; }
 
+        /// <summary>
+        /// Return issues assigned to the given username. Similar to <see cref="AssigneeId"/> and mutually exclusive with <see cref="AuthorId"/>.
+        /// In CE version <see cref="AuthorUsername"/> list should only contain a single value or an invalid param error will be returned otherwise.
+        /// </summary>
+        public IList<string> AssigneeUsername { get; set; } = new List<string>();
+
         /// <summary>
         /// Return only the issues having the given iid.
         /// </summary>

src/GitLabApiClient/Models/Issues/Responses/Issue.cs

@@ -57,5 +57,8 @@ public sealed class Issue : ModifiableObject
 
         [JsonProperty("time_stats")]
         public IssueTimeStatistic TimeStats { get; set; }
+
+        [JsonProperty("task_completion_status")]
+        public IssueTaskCompletionStatus TaskCompletionStatus { get; set; }
     }
 }

src/GitLabApiClient/Models/Issues/Responses/IssueTaskCompletionStatus.cs

@@ -0,0 +1,13 @@
+using Newtonsoft.Json;
+
+namespace GitLabApiClient.Models.Issues.Responses
+{
+    public class IssueTaskCompletionStatus
+    {
+        [JsonProperty("count")]
+        public int Count { get; set; }
+
+        [JsonProperty("completed_count")]
+        public int Completed { get; set; }
+    }
+}

test/GitLabApiClient.Test/Internal/Queries/IssuesQueryBuilderTest.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using FluentAssertions;
 using GitLabApiClient.Internal.Queries;
 using GitLabApiClient.Models;
@@ -33,7 +34,9 @@ public void NonDefaultQueryBuilt()
                     CreatedBefore = new DateTime(1991, 12, 12, 2, 2, 2),
                     UpdatedAfter = new DateTime(1991, 4, 4, 4, 4, 4),
                     UpdatedBefore = new DateTime(1991, 5, 5, 5, 5, 5),
-                    IsConfidential = true
+                    IsConfidential = true,
+                    AuthorUsername = "user_1",
+                    AssigneeUsername = new List<string> { "user_1", "user_2" }
                 });
 
             query.Should().BeEquivalentTo("https://gitlab.com/api/v4/issues?" +
@@ -53,5 +56,51 @@ public void NonDefaultQueryBuilt()
                               "updated_before=1991-05-05T05%3a05%3a05.0000000&" +
                               "updated_after=1991-04-04T04%3a04%3a04.0000000");
         }
+
+        [Fact]
+        public void NonDefaultQueryBuiltWithUserNames()
+        {
+            var sut = new IssuesQueryBuilder();
+
+            string query = sut.Build(
+                "https://gitlab.com/api/v4/issues",
+                new IssuesQueryOptions
+                {
+                    State = IssueState.Opened,
+                    Labels = { "label1", "label2" },
+                    MilestoneTitle = "milestone1",
+                    Scope = Scope.All,
+                    AuthorId = null,
+                    AssigneeId = null,
+                    IssueIds = { 3, 4 },
+                    Order = IssuesOrder.UpdatedAt,
+                    SortOrder = SortOrder.Ascending,
+                    Filter = "filter",
+                    CreatedAfter = new DateTime(1991, 11, 11, 1, 1, 1),
+                    CreatedBefore = new DateTime(1991, 12, 12, 2, 2, 2),
+                    UpdatedAfter = new DateTime(1991, 4, 4, 4, 4, 4),
+                    UpdatedBefore = new DateTime(1991, 5, 5, 5, 5, 5),
+                    IsConfidential = true,
+                    AuthorUsername = "user_1",
+                    AssigneeUsername = new List<string> { "user_1", "user_2" }
+                });
+
+            query.Should().BeEquivalentTo("https://gitlab.com/api/v4/issues?" +
+                              "state=opened&" +
+                              "labels=label1%2Clabel2&" +
+                              "milestone=milestone1&" +
+                              "scope=all&" +
+                              "author_username=user_1&" +
+                              "assignee_username=user_1%2Cuser_2&" +
+                              "iids%5B%5D=3&iids%5B%5D=4&" +
+                              "order_by=updated_at&" +
+                              "sort=asc&" +
+                              "search=filter&" +
+                              "confidential=true&" +
+                              "created_before=1991-12-12T02%3a02%3a02.0000000&" +
+                              "created_after=1991-11-11T01%3a01%3a01.0000000&" +
+                              "updated_before=1991-05-05T05%3a05%3a05.0000000&" +
+                              "updated_after=1991-04-04T04%3a04%3a04.0000000");
+        }
     }
 }

test/GitLabApiClient.Test/IssuesClientTest.cs

@@ -163,5 +163,32 @@ public async Task CreatedIssueNoteCanBeUpdated()
             updatedIssueNote.Should().Match<Note>(n =>
                 n.Body == "comment22");
         }
+
+        [Fact]
+        public async Task CreateIssueWithTasks()
+        {
+            //arrange
+            string title = Guid.NewGuid().ToString();
+            await _sut.CreateAsync(TestProjectTextId, new CreateIssueRequest(title)
+            {
+                Description = @"Description1
+- [ ] Task 1
+- [ ] Task 2
+- [x] Task 3
+"
+            });
+
+            //act
+            var listedIssues = await _sut.GetAllAsync(projectId: TestProjectTextId, options: o => o.Filter = title);
+
+            //assert
+            listedIssues.Single().Should().Match<Issue>(i =>
+                i.ProjectId == TestProjectTextId &&
+                i.Title == title &&
+                i.TaskCompletionStatus != null &&
+                i.TaskCompletionStatus.Count == 3 &&
+                i.TaskCompletionStatus.Completed == 1 &&
+                i.TimeStats != null);
+        }
     }
 }