From ef239330b37c53ca425bf8f8d4349be2d898e31c Mon Sep 17 00:00:00 2001 From: Nagashri Date: Wed, 8 Oct 2025 11:22:31 +0000 Subject: [PATCH 1/2] docs: elaborate comments in CompositeData.js for clarity --- src/RoleObjects/CompositeData.js | 36 +++++++++++++++++++++----------- 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/src/RoleObjects/CompositeData.js b/src/RoleObjects/CompositeData.js index ef842276..77b1ab32 100644 --- a/src/RoleObjects/CompositeData.js +++ b/src/RoleObjects/CompositeData.js @@ -2,11 +2,15 @@ import AccessibilityObject from './AccessibilityObject'; export default class CompositeData extends AccessibilityObject { /** - * Sets the currently active descendant of a composite widget + * Sets the currently active descendant of a composite widget. + * This method updates the `aria-activedescendant` property, which is used by assistive technologies + * to indicate which child element of a composite widget (such as a listbox, tree, or grid) is currently active. + * If a DisplayObject is provided, it must have accessibility information attached; otherwise, an error is thrown. + * Passing `undefined` will unset the active descendant, removing the association from the widget. + * * @access public - * @param {createjs.DisplayObject} displayObject - DisplayObject that is the active - descendant of this one. undefined to unset the field. - */ + * @param {createjs.DisplayObject} displayObject - The DisplayObject to set as the active descendant. If undefined, the active descendant is unset. + */ set active(displayObject) { if (displayObject && !displayObject.accessible) { throw new Error( @@ -20,19 +24,27 @@ export default class CompositeData extends AccessibilityObject { } /** - * Retrieves which DisplayObject is the current active descendant - * @access public - * @returns {createjs.DisplayObject} DisplayObject that is the current active descendant - */ + /** + * Gets the current active descendant DisplayObject for this composite widget. + * This is the DisplayObject that has been set as active, typically representing the item + * that is currently focused or selected within the widget for accessibility purposes. + * + * @access public + * @returns {createjs.DisplayObject} The DisplayObject that is the current active descendant, or undefined if none is set. + */ get active() { return this._active; } /** - * Retrieves the DOM id for the tranlated DisplayObject that is the active descendant. - * @access public - * @returns {String} id for the translated DisplayObject that is the active descendant - */ + /** + * Gets the DOM id of the currently active descendant DisplayObject. + * This value is used to set the `aria-activedescendant` attribute on the composite widget's DOM node, + * allowing assistive technologies to track which child element is active. + * + * @access public + * @returns {String} The DOM id of the active descendant DisplayObject, or undefined if none is set. + */ get activeId() { return this._reactProps['aria-activedescendant']; } From 5e4949bce22b9aceeac3e267a49a2aa50b9d5e34 Mon Sep 17 00:00:00 2001 From: Nagashri Date: Wed, 8 Oct 2025 11:27:27 +0000 Subject: [PATCH 2/2] chore: add CODEOWNERS file to require admin review for all changes --- .github/CODEOWNERS | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 00000000..ae01c796 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,5 @@ +# This file designates code owners for the repository. +# All changes to any file must be reviewed by repository admins or authorized users. +# Replace "@nmahesh-cainc" with your admin team or individual usernames as needed. + +* @nmahesh-cainc