TYP: Annotate deprecation, one-time property, and optional package tooling #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.15% // Head: 92.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1188 +/- ##
==========================================
+ Coverage 92.15% 92.16% +0.01%
==========================================
Files 97 97
Lines 12312 12330 +18
Branches 2532 2534 +2
==========================================
+ Hits 11346 11364 +18
Misses 645 645
Partials 321 321
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
effigies
force-pushed
the
type/internal_tools
branch
from
77f3deb to
7b3195d
Compare
Refactor _check_pkg_version to make types clearer. Partial application and lambdas seem hard to mypy.
effigies
force-pushed
the
type/internal_tools
branch
from
7b3195d to
62a95f6
Compare
ZviBaratz
approved these changes
Jan 30, 2023
Co-authored-by: Zvi Baratz <z.baratz@gmail.com>
effigies
force-pushed
the
type/internal_tools
branch
from
47978a2 to
4a676c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mostly self-contained pieces that allow us to transparently handle edge cases. So annotating them is relatively free of rabbit holes and should help avoid unnoticed
Anys as we annotate portions of the code that they do wrap.