Merge pull request #577 from effigies/report/qform_units

ENH: Add units to qform overwrite report

Author: effigies

niworkflows/interfaces/images.py

@@ -529,19 +529,21 @@ def _run_interface(self, runtime):
                 diff = np.linalg.inv(qform) @ new_qform
                 trans, rot, _, _ = transforms3d.affines.decompose44(diff)
                 angle = transforms3d.axangles.mat2axangle(rot)[1]
+                xyz_unit = img.header.get_xyzt_units()[0]
+                if xyz_unit == "unknown":
+                    xyz_unit = "mm"
+
                 total_trans = np.sqrt(
                     np.sum(trans * trans)
                 )  # Add angle and total_trans to report
                 warning_txt = "Note on orientation: qform matrix overwritten"
-                description = """\
+                description = f"""\
     <p class="elem-desc">
     The qform has been copied from sform.
-    The difference in angle is {angle:.02g}.
-    The difference in translation is {total_trans:.02g}.
+    The difference in angle is {angle:.02g} radians.
+    The difference in translation is {total_trans:.02g}{xyz_unit}.
     </p>
-    """.format(
-                    angle=angle, total_trans=total_trans
-                )
+    """
             elif qform_code > 0:
                 # qform code indicates the qform is supposed to be valid. Use more stridency.
                 warning_txt = "WARNING - Invalid qform information"