Better test cases

Author: Nil Portugués

src/Mapping/MappingFactory.php

@@ -40,12 +40,17 @@ class MappingFactory
     public static function fromClass($className)
     {
         /* @var ApiMapping|HalJsonMapping|JsonApiMapping $instance */
-        $className = (string) $className;
+        $className = '\\'.ltrim($className, '\\');
+        if (!class_exists($className, true)) {
+            throw new MappingException(
+                sprintf('Provided class %s could not be loaded.', $className)
+            );
+        }
         $instance = new $className();
 
         if (!in_array(ApiMapping::class, class_implements($instance, true))) {
             throw new MappingException(
-                sprintf('Class %s must implement %s.', get_class($instance), ApiMapping::class)
+                sprintf('Class %s must implement %s.', ltrim($className, '\\'), ApiMapping::class)
             );
         }
 

tests/Dummy/PostApiMapping.php

@@ -2,12 +2,11 @@
 
 namespace NilPortugues\Tests\Api\Dummy;
 
-use NilPortugues\Api\Mappings\ApiMapping;
 use NilPortugues\Api\Mappings\HalJsonMapping;
 use NilPortugues\Api\Mappings\JsonApiMapping;
 use NilPortugues\Tests\Api\Dummy\ComplexObject\Post;
 
-class PostApiMapping implements ApiMapping, JsonApiMapping, HalJsonMapping
+class PostApiMapping implements JsonApiMapping, HalJsonMapping
 {
     /**
      * {@inheritdoc}

tests/Mapping/MapperTest.php

@@ -13,10 +13,21 @@
 use NilPortugues\Api\Mapping\Mapper;
 use NilPortugues\Api\Mapping\MappingException;
 use NilPortugues\Tests\Api\Dummy\ComplexObject\Post;
+use NilPortugues\Tests\Api\Dummy\PostApiMapping;
 
 class MapperTest extends \PHPUnit_Framework_TestCase
 {
-    public function testItCanConstruct()
+    public function testItCanConstructWithClassArray()
+    {
+        $mapping = [
+            PostApiMapping::class,
+        ];
+
+        $mapper = new Mapper($mapping);
+        $this->assertNotEmpty($mapper->getClassMap());
+    }
+
+    public function testItCanConstructWithArray()
     {
         $mapping = [
             [

tests/Mapping/MappingFactoryTest.php

@@ -31,6 +31,18 @@ public function testItCanBuildMappingsFromClass()
         $this->assertEquals('http://example.com/posts/{postId}/relationships/author', $mapping->getRelationshipSelfUrl('author'));
     }
 
+    public function testItCanBuildMappingsFromClassWillThrowExceptionIfAClassIsNotProvided()
+    {
+        $this->setExpectedException(MappingException::class);
+        MappingFactory::fromClass('NotAClass');
+    }
+
+    public function testItCanBuildMappingsFromClassWillThrowExceptionIfClassDoesImplementApiMappingInterface()
+    {
+        $this->setExpectedException(MappingException::class);
+        MappingFactory::fromClass('\DateTime');
+    }
+
     public function testItCanBuildMappingsFromArray()
     {
         $mappedClass = [
@@ -169,7 +181,7 @@ public function testItWillThrowExceptionIfArrayHasNoClassKey()
     public function testItWillThrowExceptionIfArrayHasNoSelfUrlKey()
     {
         $this->setExpectedException(MappingException::class);
-        $mappedClass = ['class' => 'Post', 'id_properties' => ['postId'], 'urls' => []];
+        $mappedClass = ['class' => Post::class, 'id_properties' => ['postId'], 'urls' => []];
         MappingFactory::fromArray($mappedClass);
     }
 }

tests/Mapping/MappingTest.php

@@ -59,6 +59,18 @@ public function testAliasedProperties()
         $this->assertEquals(['oldName' => 'newName', 'oldName2' => 'newName2'], $this->mapping->getAliasedProperties());
     }
 
+    /**
+     *
+     */
+    public function testAliasedPropertiesRenamedIdProperties()
+    {
+        $this->mapping->setPropertyNameAliases(['postId' => 'newId']);
+        $this->assertEquals(
+            ['postId' => 'newId'],
+            $this->mapping->getAliasedProperties()
+        );
+        $this->assertEquals(['newId'], $this->mapping->getIdProperties());
+    }
     /**
      *
      */