Skip to content

Conversation

@mikeprosserni
Copy link
Collaborator

What does this Pull Request accomplish?

I was doing some manual testing and noticed that several of the commands in the example's README.md files were not correct. This PR fixes commands throughout the README.md and CONTRIBUTING.md files, so that all the commands actually work.

Note, one of the commands was failing because of a typo in a folder name: examples/niscope/niscope_ex_fetch_forever was missing an s in niscope, so I've renamed those files.

Why should this Pull Request be merged?

We want the documentation to be correct.

What testing has been done?

Ran all of the commands and verified that they work.

@github-actions
Copy link
Contributor

Test Results

    8 files  ±0      8 suites  ±0   20s ⏱️ -1s
  256 tests ±0    256 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 008 runs  ±0  2 008 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 491ca39. ± Comparison against base commit 13effeb.

@mikeprosserni mikeprosserni merged commit 1a16e71 into main Nov 17, 2025
18 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/fix-example-commands branch November 17, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants