feat: throw an error in case of invalid repository and no token

Author: heenakwag

src/GithubHelper.js

@@ -9,9 +9,8 @@ class GithubHelper {
    * @param {Object} repo - personal access token
    */
   constructor(pkg, config) {
-    if (!isValidRepositoryUrl(pkg) || !hasGithubToken(config.token)) {
-      throw new Error();
-    }
+    isValidRepositoryUrl(pkg);
+    hasGithubToken(config.token);
 
     this.repo = this._getRepo(pkg, config);
     this.config = config;

src/utils.js

@@ -17,8 +17,7 @@ function getRepositoryUrl(pkg) {
   }
 
   if (!GIT_REPO_REGEXP.test(repositoryUrl)) {
-    console.error('Invalid repository url on package.json');
-    repositoryUrl = '';
+    throw new Error('Invalid repository url on package.json');
   }
 
   return repositoryUrl;
@@ -41,7 +40,7 @@ function isValidRepositoryUrl(pkg) {
 function hasGithubToken(token) {
   const isValidToken = typeof token === 'string' && token.length > 0;
   if (!isValidToken) {
-    console.error('Missing TUI_GITHUB_TOKEN environment variable');
+    throw new Error('Missing Github access token');
   }
 
   return isValidToken;

test/utils.spec.js

@@ -21,32 +21,32 @@ describe('utils.isValidRepositoryUrl()', () => {
       })
     ).toBe(true);
 
-    expect(
-      isValidRepositoryUrl({
+    expect(() => {
+      return isValidRepositoryUrl({
         repository: 'https://github.com/user-name/repository-name'
-      })
-    ).toBe(false);
+      });
+    }).toThrow(new Error('Invalid repository url on package.json'));
 
-    expect(
-      isValidRepositoryUrl({
+    expect(() => {
+      return isValidRepositoryUrl({
         repository: ''
-      })
-    ).toBe(false);
+      });
+    }).toThrow(new Error('Invalid repository url on package.json'));
 
-    expect(
-      isValidRepositoryUrl({
+    expect(() => {
+      return isValidRepositoryUrl({
         repository: {
           url: 'https://github.com/user-name/repository-name'
         }
-      })
-    ).toBe(false);
+      });
+    }).toThrow(new Error('Invalid repository url on package.json'));
   });
 });
 
 describe('utils.hasGithubToken()', () => {
   it('should determine a token is valid or not.', () => {
     expect(hasGithubToken('test_token')).toBe(true);
-    expect(hasGithubToken(123123)).toBe(false);
+    expect(() => hasGithubToken(123123)).toThrow(new Error('Missing Github access token'));
   });
 });