[nextest-runner] add verbose flag to display test command lines #2800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangvu0502
changed the title
dangvu0502
force-pushed
the
feat/verbose-flag-command-display
branch
from
4cfe34a to
b00750c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2800 +/- ##
==========================================
- Coverage 80.17% 80.14% -0.03%
==========================================
Files 113 113
Lines 26312 26359 +47
==========================================
+ Hits 21095 21126 +31
- Misses 5217 5233 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+2392
to
+2410
| fn default_builder() -> DisplayReporterBuilder { | ||
| DisplayReporterBuilder { | ||
| default_filter: CompiledDefaultFilter::for_default_config(), | ||
| status_levels: StatusLevels { | ||
| status_level: StatusLevel::Fail, | ||
| final_status_level: FinalStatusLevel::Fail, | ||
| }, | ||
| test_count: 5000, | ||
| success_output: Some(TestOutputDisplay::Immediate), | ||
| failure_output: Some(TestOutputDisplay::Immediate), | ||
| should_colorize: false, | ||
| no_capture: true, | ||
| verbose: false, | ||
| show_progress: ShowProgress::Counter, | ||
| no_output_indent: false, | ||
| max_progress_running: MaxProgressRunning::default(), | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Wouldn't this be better as an impl Default instead of a free standing fn?
| /// | ||
| /// Returns the output written to the reporter. | ||
| fn with_reporter<'a, F>(f: F, out: &'a mut String) | ||
| fn with_reporter<'a, F>(builder: DisplayReporterBuilder, f: F, out: &'a mut String) |
There was a problem hiding this comment.
If you're passing default_builder() at every call site isn't it just better to not have it as an argument and always construct a default builder inside the function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2513