added support for final promoted property

Author: dg

src/PhpGenerator/Extractor.php

@@ -476,10 +476,12 @@ private function setupFunction(GlobalFunction|Method|PropertyHook $function, Nod
 		foreach ($node->getParams() as $item) {
 			$getVisibility = $this->toVisibility($item->flags);
 			$setVisibility = $this->toSetterVisibility($item->flags);
-			if ($getVisibility || $setVisibility) {
+			$final = (bool) ($item->flags & Modifiers::FINAL);
+			if ($getVisibility || $setVisibility || $final) {
 				$param = $function->addPromotedParameter($item->var->name)
 					->setVisibility($getVisibility, $setVisibility)
-					->setReadonly((bool) ($item->flags & Node\Stmt\Class_::MODIFIER_READONLY));
+					->setReadonly((bool) ($item->flags & Node\Stmt\Class_::MODIFIER_READONLY))
+					->setFinal($final);
 				$this->addHooksToProperty($param, $item);
 			} else {
 				$param = $function->addParameter($item->var->name);

src/PhpGenerator/Factory.php

@@ -211,7 +211,8 @@ public function fromParameterReflection(\ReflectionParameter $from): Parameter
 			$property = $from->getDeclaringClass()->getProperty($from->name);
 			$param = (new PromotedParameter($from->name))
 				->setVisibility($this->getVisibility($property))
-				->setReadOnly(PHP_VERSION_ID >= 80100 && $property->isReadonly());
+				->setReadOnly(PHP_VERSION_ID >= 80100 && $property->isReadonly())
+				->setFinal(PHP_VERSION_ID >= 80500 && $property->isFinal() && !$property->isPrivateSet());
 			$this->addHooks($property, $param);
 		} else {
 			$param = new Parameter($from->name);

src/PhpGenerator/Printer.php

@@ -345,7 +345,10 @@ private function formatParameters(Closure|GlobalFunction|Method|PropertyHook $fu
 				$this->printDocComment($param)
 				. ($attrs ? ($multiline ? substr($attrs, 0, -1) . "\n" : $attrs) : '')
 				. ($param instanceof PromotedParameter
-					? $this->printPropertyVisibility($param) . ($param->isReadOnly() && $param->getType() ? ' readonly' : '') . ' '
+					? ($param->isFinal() ? 'final ' : '')
+						. $this->printPropertyVisibility($param)
+						. ($param->isReadOnly() && $param->getType() ? ' readonly' : '')
+						. ' '
 					: '')
 				. ltrim($this->printType($param->getType(), $param->isNullable()) . ' ')
 				. ($param->isReference() ? '&' : '')

src/PhpGenerator/Property.php

@@ -28,7 +28,6 @@ final class Property
 	private ?string $type = null;
 	private bool $nullable = false;
 	private bool $initialized = false;
-	private bool $final = false;
 	private bool $abstract = false;
 
 
@@ -101,19 +100,6 @@ public function isInitialized(): bool
 	}
 
 
-	public function setFinal(bool $state = true): static
-	{
-		$this->final = $state;
-		return $this;
-	}
-
-
-	public function isFinal(): bool
-	{
-		return $this->final;
-	}
-
-
 	public function setAbstract(bool $state = true): static
 	{
 		$this->abstract = $state;

src/PhpGenerator/Traits/PropertyLike.php

@@ -23,6 +23,7 @@ trait PropertyLike
 {
 	/** @var array{'set' => ?string, 'get' => ?string} */
 	private array $visibility = [PropertyAccessMode::Set => null, PropertyAccessMode::Get => null];
+	private bool $final = false;
 	private bool $readOnly = false;
 
 	/** @var array<string, ?PropertyHook> */
@@ -95,6 +96,19 @@ public function isPrivate(string $mode = PropertyAccessMode::Get): bool
 	}
 
 
+	public function setFinal(bool $state = true): static
+	{
+		$this->final = $state;
+		return $this;
+	}
+
+
+	public function isFinal(): bool
+	{
+		return $this->final;
+	}
+
+
 	public function setReadOnly(bool $state = true): static
 	{
 		$this->readOnly = $state;

tests/PhpGenerator/PropertyLike.hooks.phpt

@@ -79,6 +79,14 @@ $method->addPromotedParameter('second')
 		->addParameter('value')
 			->setType('string');
 
+$method->addPromotedParameter('third')
+	->setPublic()
+	->setProtected('set')
+	->setFinal()
+	->setType('string')
+	->addComment('hello')
+	->addAttribute('Example');
+
 same(<<<'XX'
 	class Demo
 	{
@@ -91,6 +99,9 @@ same(<<<'XX'
 			public string $second {
 				final set(string $value) => $value;
 			},
+			/** hello */
+			#[Example]
+			final public protected(set) string $third,
 		) {
 		}
 	}

tests/PhpGenerator/expected/ClassType.from.85.expect

@@ -1,4 +1,10 @@
 class Class85
 {
 	private(set) static string $foo;
+
+
+	public function __construct(
+		final public $final,
+	) {
+	}
 }

tests/PhpGenerator/expected/Extractor.classes.85.expect

@@ -7,4 +7,10 @@ namespace Abc;
 class Class85
 {
 	private(set) static string $foo;
+
+
+	function __construct(
+		final public $final,
+	) {
+	}
 }

tests/PhpGenerator/fixtures/classes.85.php

@@ -7,4 +7,9 @@
 class Class85
 {
 	private(set) static string $foo;
+
+	function __construct(
+		final $final,
+	) {
+	}
 }