Property can be abstract / final

Author: dg

src/PhpGenerator/Printer.php

@@ -380,12 +380,14 @@ private function printProperty(Property $property, bool $readOnlyClass = false,
 	{
 		$property->validate();
 		$type = $property->getType();
-		$def = (($property->getVisibility() ?: 'public')
+		$def = ($property->isAbstract() && !$isInterface ? 'abstract ' : '')
+			. ($property->isFinal() ? 'final ' : '')
+			. ($property->getVisibility() ?: 'public')
 			. ($property->isStatic() ? ' static' : '')
 			. (!$readOnlyClass && $property->isReadOnly() && $type ? ' readonly' : '')
 			. ' '
 			. ltrim($this->printType($type, $property->isNullable()) . ' ')
-			. '$' . $property->getName());
+			. '$' . $property->getName();
 
 		$defaultValue = $property->getValue() === null && !$property->isInitialized()
 			? ''

src/PhpGenerator/Property.php

@@ -29,6 +29,8 @@ final class Property
 	private bool $nullable = false;
 	private bool $initialized = false;
 	private bool $readOnly = false;
+	private bool $final = false;
+	private bool $abstract = false;
 
 	/** @var array<string, ?PropertyHook> */
 	private array $hooks = ['set' => null, 'get' => null];
@@ -116,6 +118,32 @@ public function isReadOnly(): bool
 	}
 
 
+	public function setFinal(bool $state = true): static
+	{
+		$this->final = $state;
+		return $this;
+	}
+
+
+	public function isFinal(): bool
+	{
+		return $this->final;
+	}
+
+
+	public function setAbstract(bool $state = true): static
+	{
+		$this->abstract = $state;
+		return $this;
+	}
+
+
+	public function isAbstract(): bool
+	{
+		return $this->abstract;
+	}
+
+
 	/**
 	 * Replaces all hooks
 	 * @param  PropertyHook[]  $hooks
@@ -161,6 +189,15 @@ public function validate(): void
 	{
 		if ($this->readOnly && !$this->type) {
 			throw new Nette\InvalidStateException("Property \$$this->name: Read-only properties are only supported on typed property.");
+
+		} elseif ($this->abstract && $this->final) {
+			throw new Nette\InvalidStateException("Property \$$this->name cannot be abstract and final at the same time.");
+
+		} elseif (
+			$this->abstract
+			&& !Nette\Utils\Arrays::some($this->getHooks(), fn($hook) => $hook->isAbstract())
+		) {
+			throw new Nette\InvalidStateException("Property \$$this->name: Abstract property must have at least one abstract hook.");
 		}
 	}
 }

tests/PhpGenerator/Property.hooks.classes.phpt

@@ -17,6 +17,7 @@ $class->addProperty('first')
 	->setType('string')
 	->setValue('x')
 	->setPublic()
+	->setFinal()
 	->addHook('set')
 		->setBody('$value . ?', ['x'], short: true)
 		->addComment('comment')
@@ -40,7 +41,7 @@ $prop->addHook('set', '$this->second = $value;')
 same(<<<'XX'
 	class Demo
 	{
-		public string $first = 'x' {
+		final public string $first = 'x' {
 			/** comment */
 			#[Example]
 			set(string $value) => $value . 'x';
@@ -96,3 +97,40 @@ same(<<<'XX'
 	}
 
 	XX, (string) $class);
+
+
+
+// abstract properties
+
+$class = (new ClassType('Demo'))
+	->setAbstract();
+
+$class->addProperty('first')
+	->setType('string')
+	->setAbstract()
+	->addHook('set')
+		->setAbstract();
+
+$prop = $class->addProperty('second')
+	->setType('string')
+	->setAbstract();
+
+$prop->addHook('set')
+	->setAbstract();
+
+$prop->addHook('get', 'return 123;');
+
+same(<<<'XX'
+	abstract class Demo
+	{
+		abstract public string $first { set; }
+
+		abstract public string $second {
+			set;
+			get {
+				return 123;
+			}
+		}
+	}
+
+	XX, (string) $class);

tests/PhpGenerator/Property.validate.phpt

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+use Nette\PhpGenerator\Property;
+use Tester\Assert;
+
+require __DIR__ . '/../bootstrap.php';
+
+
+Assert::exception(function () {
+	$property = new Property('a');
+	$property->setFinal()->setAbstract();
+	$property->validate();
+}, Nette\InvalidStateException::class, 'Property $a cannot be abstract and final at the same time.');
+
+Assert::exception(function () {
+	$property = new Property('a');
+	$property->setAbstract();
+	$property->validate();
+}, Nette\InvalidStateException::class, 'Property $a: Abstract property must have at least one abstract hook.');