Skip to content

Commit d4f43a2

Browse files
authored
Update conan CI version to 1.61.0 and re-enable macos build (#693)
1 parent c9a0ab3 commit d4f43a2

File tree

7 files changed

+48
-51
lines changed

7 files changed

+48
-51
lines changed

.github/actions/build-cpp/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ WORKDIR /pktvisor-src
1515
RUN apt-get update && \
1616
apt-get upgrade --yes --force-yes && \
1717
apt-get install --yes --force-yes --no-install-recommends ${BUILD_DEPS} && \
18-
pip3 install 'conan==1.59.0' --force-reinstall
18+
pip3 install 'conan==1.61.0' --force-reinstall
1919

2020
RUN chmod +x /entrypoint.sh
2121

.github/workflows/build-develop.yml

Lines changed: 39 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,10 @@ jobs:
2424
# cross-platform coverage.
2525
# See: https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#using-a-build-matrix
2626

27-
runs-on: macos-11
27+
runs-on: macos-latest
2828
steps:
2929
- uses: actions/checkout@v3
30-
- name: install gcc 12.2
31-
run: |
32-
gcc --version
33-
brew search gcc
34-
brew install gcc@12
35-
gcc --version
36-
30+
3731
- name: Create Build Environment
3832
# Some projects don't allow in-source building, so create a separate build directory
3933
# We'll use this as our working directory for all subsequent commands
@@ -43,37 +37,40 @@ jobs:
4337
id: conan
4438
uses: turtlebrowser/get-conan@main
4539
with:
46-
version: 1.60.1
47-
48-
# - name: Setup Conan Cache
49-
# uses: actions/cache@v3
50-
# with:
51-
# path: ${{github.workspace}}/build/conan_home/
52-
# key: conan-${{ runner.os }}-${{ hashFiles('conanfile.txt', '*/conanfile.txt') }}
53-
# restore-keys: conan-${{ runner.os }}-
54-
55-
# - name: Configure CMake
56-
# # Use a bash shell so we can use the same syntax for environment variable
57-
# # access regardless of the host operating system
58-
# shell: bash
59-
# working-directory: ${{github.workspace}}/build
60-
# # Note the current convention is to use the -S and -B options here to specify source
61-
# # and build directories, but this is only available with CMake 3.13 and higher.
62-
# # The CMake binaries on the Github Actions machines are (as of this writing) 3.12
63-
# run: PKG_CONFIG_PATH=${{github.workspace}}/local/lib/pkgconfig cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=$BUILD_TYPE
64-
65-
# - name: Build
66-
# working-directory: ${{github.workspace}}/build
67-
# shell: bash
68-
# # Execute the build. You can specify a specific target with "--target <NAME>"
69-
# run: cmake --build . --config $BUILD_TYPE -- -j 2
70-
71-
# - name: Test
72-
# working-directory: ${{github.workspace}}/build
73-
# shell: bash
74-
# # Execute tests defined by the CMake configuration.
75-
# # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
76-
# run: ctest -C $BUILD_TYPE
40+
version: 1.61.0
41+
42+
- name: Setup OSX Environment
43+
run: echo "SDKROOT=$(xcrun --sdk macosx --show-sdk-path)" >> $GITHUB_ENV
44+
45+
- name: Setup Conan Cache
46+
uses: actions/cache@v3
47+
with:
48+
path: ${{github.workspace}}/build/conan_home/
49+
key: conan-${{ runner.os }}-${{ hashFiles('conanfile.txt', '*/conanfile.txt') }}
50+
restore-keys: conan-${{ runner.os }}-
51+
52+
- name: Configure CMake
53+
# Use a bash shell so we can use the same syntax for environment variable
54+
# access regardless of the host operating system
55+
shell: bash
56+
working-directory: ${{github.workspace}}/build
57+
# Note the current convention is to use the -S and -B options here to specify source
58+
# and build directories, but this is only available with CMake 3.13 and higher.
59+
# The CMake binaries on the Github Actions machines are (as of this writing) 3.12
60+
run: PKG_CONFIG_PATH=${{github.workspace}}/local/lib/pkgconfig cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=$BUILD_TYPE
61+
62+
- name: Build
63+
working-directory: ${{github.workspace}}/build
64+
shell: bash
65+
# Execute the build. You can specify a specific target with "--target <NAME>"
66+
run: cmake --build . --config $BUILD_TYPE -- -j 2
67+
68+
- name: Test
69+
working-directory: ${{github.workspace}}/build
70+
shell: bash
71+
# Execute tests defined by the CMake configuration.
72+
# See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
73+
run: ctest -C $BUILD_TYPE
7774

7875
unit-tests-linux:
7976
# The CMake configure and build commands are platform agnostic and should work equally
@@ -99,7 +96,7 @@ jobs:
9996
id: conan
10097
uses: turtlebrowser/get-conan@main
10198
with:
102-
version: 1.59.0
99+
version: 1.61.0
103100

104101
- name: linux package install
105102
run: |
@@ -166,7 +163,7 @@ jobs:
166163
id: conan
167164
uses: turtlebrowser/get-conan@main
168165
with:
169-
version: 1.59.0
166+
version: 1.61.0
170167

171168
- name: Remove libpcap from conanfile
172169
shell: bash
@@ -396,7 +393,7 @@ jobs:
396393
id: conan
397394
uses: turtlebrowser/get-conan@main
398395
with:
399-
version: 1.59.0
396+
version: 1.61.0
400397

401398
- name: Configure CMake to generate VERSION
402399
shell: bash

.github/workflows/build-release.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
id: conan
3333
uses: turtlebrowser/get-conan@main
3434
with:
35-
version: 1.59.0
35+
version: 1.61.0
3636

3737
- name: Setup Conan Cache
3838
uses: actions/cache@v3
@@ -84,7 +84,7 @@ jobs:
8484
id: conan
8585
uses: turtlebrowser/get-conan@main
8686
with:
87-
version: 1.59.0
87+
version: 1.61.0
8888

8989
- name: Configure CMake to generate VERSION
9090
shell: bash
@@ -134,7 +134,7 @@ jobs:
134134
id: conan
135135
uses: turtlebrowser/get-conan@main
136136
with:
137-
version: 1.59.0
137+
version: 1.61.0
138138

139139
- name: Configure CMake to generate VERSION
140140
shell: bash
@@ -279,7 +279,7 @@ jobs:
279279
id: conan
280280
uses: turtlebrowser/get-conan@main
281281
with:
282-
version: 1.59.0
282+
version: 1.61.0
283283

284284
- name: Remove libpcap from conanfile
285285
shell: bash

.github/workflows/build_cross.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
curl -L "${{matrix.toolchain}}" | tar -C toolchain -xz --strip-components=1
7070
7171
- name: Install Conan
72-
run: pip install --no-cache-dir 'conan==1.59.0' --force-reinstall
72+
run: pip install --no-cache-dir 'conan==1.61.0' --force-reinstall
7373

7474
- name: Create Conan configuration
7575
run: |

.github/workflows/build_debug.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
id: conan
3434
uses: turtlebrowser/get-conan@main
3535
with:
36-
version: 1.59.0
36+
version: 1.61.0
3737

3838
- name: Setup Conan Cache
3939
uses: actions/cache@v3

.github/workflows/code-ql.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
- run: |
6161
# Run Build - set up dependencies, env vars, compile, and make test
6262
#install conan
63-
pip install --no-cache-dir 'conan==1.59.0' --force-reinstall
63+
pip install --no-cache-dir 'conan==1.61.0' --force-reinstall
6464
# create conan config
6565
CONAN_V2_MODE=1 conan config init
6666
conan config set general.revisions_enabled=1

docker/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ RUN \
66
apt-get update && \
77
apt-get upgrade --yes --force-yes && \
88
apt-get install --yes --force-yes --no-install-recommends ${BUILD_DEPS} && \
9-
pip3 install "conan==1.59.0"
9+
pip3 install "conan==1.61.0"
1010

1111
# need git for current hash for VERSION
1212
COPY ./.git/ /pktvisor-src/.git/

0 commit comments

Comments
 (0)