Merge pull request #278 from pheus/277-add-NetBox-v4-4-support

Closes #277 - Add support for NetBox v4.4

Author: cruse1977

Dockerfile

@@ -1,4 +1,4 @@
-ARG NETBOX_VARIANT=v4.3
+ARG NETBOX_VARIANT=v4.4
 
 FROM netboxcommunity/netbox:${NETBOX_VARIANT}
 

netbox_acls/__init__.py

@@ -2,21 +2,23 @@
 Define the NetBox Plugin
 """
 
-from netbox.plugins import PluginConfig
 import importlib.metadata
 
+from netbox.plugins import PluginConfig
+
+
 class NetBoxACLsConfig(PluginConfig):
     """
     Plugin specifc configuration
     """
 
     name = "netbox_acls"
     verbose_name = "Access Lists"
-    version = importlib.metadata.version('netbox-acls')
+    version = importlib.metadata.version("netbox-acls")
     description = "Manage simple ACLs in NetBox"
     base_url = "access-lists"
     min_version = "4.3.0"
-    max_version = "4.3.99"
+    max_version = "4.4.99"
 
 
 config = NetBoxACLsConfig

netbox_acls/tests/api/test_access_list_rules.py

@@ -3,8 +3,13 @@
 from utilities.testing import APIViewTestCases
 from virtualization.models import Cluster, ClusterType, VirtualMachine
 
-from netbox_acls.choices import *
-from netbox_acls.models import *
+from netbox_acls.choices import (
+    ACLActionChoices,
+    ACLProtocolChoices,
+    ACLRuleActionChoices,
+    ACLTypeChoices,
+)
+from netbox_acls.models import AccessList, ACLExtendedRule, ACLStandardRule
 
 
 class ACLStandardRuleAPIViewTestCase(APIViewTestCases.APIViewTestCase):

netbox_acls/tests/api/test_access_lists.py

@@ -4,8 +4,12 @@
 from utilities.testing import APIViewTestCases
 from virtualization.models import Cluster, ClusterType, VirtualMachine, VMInterface
 
-from netbox_acls.choices import *
-from netbox_acls.models import *
+from netbox_acls.choices import (
+    ACLActionChoices,
+    ACLAssignmentDirectionChoices,
+    ACLTypeChoices,
+)
+from netbox_acls.models import AccessList, ACLInterfaceAssignment
 
 
 class AccessListAPIViewTestCase(APIViewTestCases.APIViewTestCase):
@@ -116,7 +120,7 @@ def setUpTestData(cls):
             },
         ]
         cls.bulk_update_data = {
-            "default_action": ACLActionChoices.ACTION_PERMIT,
+            "comments": "Rule bulk update",
         }