update remove order and overlay defaults check

Author: mtarking

plugins/action/common/prepare_plugins/prep_001_list_defaults.py

@@ -130,7 +130,7 @@ def prepare(self):
         # Check vxlan.overlay_services list elements
         parent_keys = ['vxlan', 'overlay_services']
         dm_check = data_model_key_check(self.model_data, parent_keys)
-        if 'overlay_services' in dm_check['keys_no_data']:
+        if 'overlay_services' in dm_check['keys_not_found'] or 'overlay_services' in dm_check['keys_no_data']:
             self.model_data['vxlan']['overlay_services'] = {'vrfs': []}
             self.model_data['vxlan']['overlay_services'] = {'vrf_attach_groups': []}
             self.model_data['vxlan']['overlay_services'] = {'networks': []}

roles/dtc/remove/tasks/sub_main.yml

@@ -63,18 +63,18 @@
   when:
     - changes_detected_vrfs
 
-- name: Remove Fabric vPC Peering
-  ansible.builtin.import_tasks: vpc_peers.yml
-  tags: "{{ nac_tags.remove_vpc_peers }}"
-  when:
-    - changes_detected_vpc_peering
-
 - name: Remove Fabric Links
   ansible.builtin.import_tasks: links.yml
   tags: "{{ nac_tags.remove_links }}"
   when:
     - changes_detected_link_vpc_peering
 
+- name: Remove Fabric vPC Peering
+  ansible.builtin.import_tasks: vpc_peers.yml
+  tags: "{{ nac_tags.remove_vpc_peers }}"
+  when:
+    - changes_detected_vpc_peering
+
 - name: Remove Fabric Switches
   ansible.builtin.import_tasks: switches.yml
   tags: "{{ nac_tags.remove_switches }}"