Fix lab execution: align robot template and CI pipeline (#62)

* Fix lab execution: robot template and CI pipeline

Author: dacasti2mx

.gitlab-ci.yml

@@ -1,5 +1,5 @@
 ---
-image: mtarking/nac-vxlan:24.0.1
+image: mtarking/nac-vxlan:0.5.1rc1
 stages:
   - validate
   - deploy
@@ -28,7 +28,7 @@ validate:
   rules:
     - if: $CI_COMMIT_TAG == null
   script:
-    - set -o pipefail && ansible-playbook -i inventory.yml ndfc_validate.yml |& tee validate_output.txt
+    - set -o pipefail && ansible-playbook -i inventory.yaml validate.yaml |& tee validate_output.txt
   artifacts:
     paths:
       - validate_output.txt
@@ -42,7 +42,7 @@ deploy:
     - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
       when: manual
   script:
-    - set -o pipefail && ansible-playbook -i inventory.yml vxlan.yml |& tee deploy_output.txt
+    - set -o pipefail && ansible-playbook -i inventory.yaml vxlan.yaml |& tee deploy_output.txt
 
 test-integration:
   stage: test
@@ -53,7 +53,7 @@ test-integration:
   rules:
     - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
   script:
-    - set -o pipefail && iac-test -d ./host_vars/nac-ndfc1 -d ./group_vars/ndfc/defaults.yaml -t ./tests/templates -f ./tests/filters -o ./tests/results/ndfc |& tee test_output.txt
+    - set -o pipefail && nac-test -d ./host_vars/nac-fabric1 -d ./group_vars/ndfc/defaults.yaml -t ./tests/templates -o ./tests/results/ndfc |& tee test_output.txt
   artifacts:
     when: always
     paths:

tests/templates/config/fabric/fabric.robot

@@ -73,8 +73,8 @@ Verify Fabric {{ fabric }} Underlay BGP Parameters
     Should Be Equal Value Json String   ${r.json()}   $..BGP_AUTH_KEY_TYPE     {{ vxlan.underlay.bgp.authentication_key_type | default(defaults.vxlan.underlay.bgp.authentication_key_type) }}   msg=BGP_AUTH_KEY_TYPE
     Should Be Equal Value Json String   ${r.json()}   $..BGP_AUTH_KEY     {{ vxlan.underlay.bgp.authentication_key | default(omit) }}   msg=BGP_AUTH_KEY
 {% endif %}
-
-{% if not (vxlan.global.ibgp.vpc.advertise_pip | default(defaults.vxlan.global.ibgp.vpc.advertise_pip) | bool) %}
+{% if not (vxlan.global.ibgp.vpc.advertise_pip
+           | default(defaults.vxlan.global.ibgp.vpc.advertise_pip)) %}
     Should Be Equal Value Json String   ${r.json()}   $..ADVERTISE_PIP_ON_BORDER   {{ vxlan.global.ibgp.vpc.advertise_pip_border_only | default(defaults.vxlan.global.ibgp.vpc.advertise_pip_border_only) | lower}}   msg=ADVERTISE_PIP_ON_BORDER
 {% endif %}
     Should Be Equal Value Json String   ${r.json()}   $..VPC_DOMAIN_ID_RANGE   {{ vxlan.global.ibgp.vpc.domain_id_range | default(defaults.vxlan.global.ibgp.vpc.domain_id_range) }}     msg=VPC_DOMAIN_ID_RANGE

validate.yaml

@@ -1,7 +1,7 @@
 ---
 # This is the main entry point playbook for calling the various
 # roles in this collection.
-- hosts: nac-ndfc1
+- hosts: nac-fabric1
   any_errors_fatal: true
   gather_facts: false